Re: Review Request 40104: Callback should only be called on drained hosts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40104/#review105769 --- Ship it! Ship It! - Maxim Khutornenko On Nov. 9, 2015, 9:33 p.m., David Robinson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40104/ > --- > > (Updated Nov. 9, 2015, 9:33 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-1537 > https://issues.apache.org/jira/browse/AURORA-1537 > > > Repository: aurora > > > Description > --- > > Callback should only be called on drained hosts. > > > Diffs > - > > src/main/python/apache/aurora/admin/host_maintenance.py > cfb13de6fad726dbf8e20671f1ef4245f9a6408b > src/test/python/apache/aurora/admin/test_host_maintenance.py > 6264d0cf2c4378dd5476589ce84c3072636de07e > > Diff: https://reviews.apache.org/r/40104/diff/ > > > Testing > --- > > == test session starts === > platform linux2 -- Python 2.7.8, pytest-2.8.2, py-1.4.30, pluggy-0.3.1 > rootdir: > /home/drobinson/workspace/aurora_oss/src/test/python/apache/aurora/admin, > inifile: > plugins: cov-2.2.0, timeout-0.5 > collected 12 items > > src/test/python/apache/aurora/admin/test_host_maintenance.py > > == 12 passed, 1 pytest-warnings in 0.31 seconds == > > > Thanks, > > David Robinson > >
Re: Review Request 40104: Callback should only be called on drained hosts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40104/#review105757 --- Ship it! Master (ec61b8b) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 9, 2015, 9:33 p.m., David Robinson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40104/ > --- > > (Updated Nov. 9, 2015, 9:33 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-1537 > https://issues.apache.org/jira/browse/AURORA-1537 > > > Repository: aurora > > > Description > --- > > Callback should only be called on drained hosts. > > > Diffs > - > > src/main/python/apache/aurora/admin/host_maintenance.py > cfb13de6fad726dbf8e20671f1ef4245f9a6408b > src/test/python/apache/aurora/admin/test_host_maintenance.py > 6264d0cf2c4378dd5476589ce84c3072636de07e > > Diff: https://reviews.apache.org/r/40104/diff/ > > > Testing > --- > > == test session starts === > platform linux2 -- Python 2.7.8, pytest-2.8.2, py-1.4.30, pluggy-0.3.1 > rootdir: > /home/drobinson/workspace/aurora_oss/src/test/python/apache/aurora/admin, > inifile: > plugins: cov-2.2.0, timeout-0.5 > collected 12 items > > src/test/python/apache/aurora/admin/test_host_maintenance.py > > == 12 passed, 1 pytest-warnings in 0.31 seconds == > > > Thanks, > > David Robinson > >
Re: Review Request 40104: Callback should only be called on drained hosts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40104/#review105752 --- Ship it! Ship It! - Zameer Manji On Nov. 9, 2015, 1:33 p.m., David Robinson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40104/ > --- > > (Updated Nov. 9, 2015, 1:33 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-1537 > https://issues.apache.org/jira/browse/AURORA-1537 > > > Repository: aurora > > > Description > --- > > Callback should only be called on drained hosts. > > > Diffs > - > > src/main/python/apache/aurora/admin/host_maintenance.py > cfb13de6fad726dbf8e20671f1ef4245f9a6408b > src/test/python/apache/aurora/admin/test_host_maintenance.py > 6264d0cf2c4378dd5476589ce84c3072636de07e > > Diff: https://reviews.apache.org/r/40104/diff/ > > > Testing > --- > > == test session starts === > platform linux2 -- Python 2.7.8, pytest-2.8.2, py-1.4.30, pluggy-0.3.1 > rootdir: > /home/drobinson/workspace/aurora_oss/src/test/python/apache/aurora/admin, > inifile: > plugins: cov-2.2.0, timeout-0.5 > collected 12 items > > src/test/python/apache/aurora/admin/test_host_maintenance.py > > == 12 passed, 1 pytest-warnings in 0.31 seconds == > > > Thanks, > > David Robinson > >
Re: Review Request 40104: Callback should only be called on drained hosts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40104/ --- (Updated Nov. 9, 2015, 9:33 p.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Changes --- Fixed indentation. Bugs: AURORA-1537 https://issues.apache.org/jira/browse/AURORA-1537 Repository: aurora Description --- Callback should only be called on drained hosts. Diffs (updated) - src/main/python/apache/aurora/admin/host_maintenance.py cfb13de6fad726dbf8e20671f1ef4245f9a6408b src/test/python/apache/aurora/admin/test_host_maintenance.py 6264d0cf2c4378dd5476589ce84c3072636de07e Diff: https://reviews.apache.org/r/40104/diff/ Testing --- == test session starts === platform linux2 -- Python 2.7.8, pytest-2.8.2, py-1.4.30, pluggy-0.3.1 rootdir: /home/drobinson/workspace/aurora_oss/src/test/python/apache/aurora/admin, inifile: plugins: cov-2.2.0, timeout-0.5 collected 12 items src/test/python/apache/aurora/admin/test_host_maintenance.py == 12 passed, 1 pytest-warnings in 0.31 seconds == Thanks, David Robinson
Re: Review Request 40104: Callback should only be called on drained hosts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40104/#review105737 --- Master (ec61b8b) is red with this patch. ./build-support/jenkins/build.sh Using cached twitter.common.process-0.3.0.tar.gz Collecting twitter.common.log==0.3.0 (from twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) Using cached twitter.common.log-0.3.0.tar.gz Collecting twitter.common.util==0.3.0 (from twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) Using cached twitter.common.util-0.3.0.tar.gz Collecting twitter.common.collections==0.3.0 (from twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) Using cached twitter.common.collections-0.3.0.tar.gz Collecting smmap>=0.8.5 (from gitdb>=0.5.1->GitPython==0.3.2.RC1->twitter.checkstyle==0.1.0) Using cached smmap-0.9.0.tar.gz Collecting twitter.common.string==0.3.0 (from twitter.common.process==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) Using cached twitter.common.string-0.3.0.tar.gz Collecting twitter.common.options==0.3.0 (from twitter.common.log==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) Using cached twitter.common.options-0.3.0.tar.gz Collecting twitter.common.dirutil==0.3.0 (from twitter.common.log==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) Using cached twitter.common.dirutil-0.3.0.tar.gz Collecting twitter.common.contextutil==0.3.0 (from twitter.common.util==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) Using cached twitter.common.contextutil-0.3.0.tar.gz Collecting twitter.common.lang==0.3.0 (from twitter.common.collections==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0) Using cached twitter.common.lang-0.3.0.tar.gz Installing collected packages: pyflakes, pep8, smmap, gitdb, GitPython, twitter.common.lang, twitter.common.string, twitter.common.process, twitter.common.options, twitter.common.dirutil, twitter.common.log, twitter.common.contextutil, twitter.common.util, twitter.common.collections, twitter.common.app, twitter.checkstyle Running setup.py install for pyflakes Running setup.py install for pep8 Running setup.py install for smmap Running setup.py install for gitdb Running setup.py install for GitPython Running setup.py install for twitter.common.lang Running setup.py install for twitter.common.string Running setup.py install for twitter.common.process Running setup.py install for twitter.common.options Running setup.py install for twitter.common.dirutil Running setup.py install for twitter.common.log Running setup.py install for twitter.common.contextutil Running setup.py install for twitter.common.util Running setup.py install for twitter.common.collections Running setup.py install for twitter.common.app Running setup.py install for twitter.checkstyle Successfully installed GitPython-0.3.2rc1 gitdb-0.6.4 pep8-1.4.5 pyflakes-0.7.2 smmap-0.9.0 twitter.checkstyle-0.1.0 twitter.common.app-0.3.0 twitter.common.collections-0.3.0 twitter.common.contextutil-0.3.0 twitter.common.dirutil-0.3.0 twitter.common.lang-0.3.0 twitter.common.log-0.3.0 twitter.common.options-0.3.0 twitter.common.process-0.3.0 twitter.common.string-0.3.0 twitter.common.util-0.3.0 T100:ERROR src/test/python/apache/aurora/admin/test_host_maintenance.py:198 Indentation of 4 instead of 2 |return drain_hosts_results.pop(0) I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 9, 2015, 9:08 p.m., David Robinson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40104/ > --- > > (Updated Nov. 9, 2015, 9:08 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-1537 > https://issues.apache.org/jira/browse/AURORA-1537 > > > Repository: aurora > > > Description > --- > > Callback should only be called on drained hosts. > > > Diffs > - > > src/main/python/apache/aurora/admin/host_maintenance.py > cfb13de6fad726dbf8e20671f1ef4245f9a6408b > src/test/python/apache/aurora/admin/test_host_maintenance.py > 6264d0cf2c4378dd5476589ce84c3072636de07e > > Diff: https://reviews.apache.org/r/40104/diff/ > > > Testing > --- > > == test session starts === > platform linux2 -- Python 2.7.8, pytest-2.8.2, py-1.4.30, pluggy-0.3.1 > rootdir: > /home/drobinson/workspace/aurora_oss/src/test/python/apache/aurora/admin, > inifile: > plugins: cov-2.2.0, timeout-0.5 > collected 12 items > > src/test/python/apache/aurora/admin/test_host_maintenance.py > > == 12 passed, 1 pytest-warnings in 0.31 seconds == > > > Th
