Re: Review Request 40149: Create ExecutorSettings creation closer to command line arguments.

2015-11-11 Thread Bill Farner
> On Nov. 10, 2015, 2:07 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java, line 227 > > > > > > Is there a reason why we are not using Java's URI type to do this sort >

Re: Review Request 40149: Create ExecutorSettings creation closer to command line arguments.

2015-11-11 Thread Bill Farner
> On Nov. 10, 2015, 1:29 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java, line 219 > > > > > > Any reason you couldn't use ResourceSlot.makeMesosResource instead?

Re: Review Request 40149: Create ExecutorSettings creation closer to command line arguments.

2015-11-10 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40149/#review105966 --- Ship it! src/main/java/org/apache/aurora/scheduler/app/SchedulerM

Re: Review Request 40149: Create ExecutorSettings creation closer to command line arguments.

2015-11-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40149/#review105956 --- Ship it! src/main/java/org/apache/aurora/scheduler/app/SchedulerM

Re: Review Request 40149: Create ExecutorSettings creation closer to command line arguments.

2015-11-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40149/#review105957 --- Ship it! Master (3ea1b26) is green with this patch. ./build-supp