Re: Review Request 40219: Replace Twitter checkstyle with pants checkstyle.

2015-11-13 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40219/#review106527 --- Replacement RB using official plugin is here: https://reviews.apac

Re: Review Request 40219: Replace Twitter checkstyle with pants checkstyle.

2015-11-12 Thread John Sirois
> On Nov. 12, 2015, 12:05 p.m., Zameer Manji wrote: > > Although the end result LGTM, I'm not sure if having our own custom pants > > plugin is the way to go here. Historically we have been very bad at > > upgrading pants and maintaining it, I'm afraid that if we add a custom > > plugin here w

Re: Review Request 40219: Replace Twitter checkstyle with pants checkstyle.

2015-11-12 Thread John Sirois
> On Nov. 12, 2015, 12:05 p.m., Zameer Manji wrote: > > Although the end result LGTM, I'm not sure if having our own custom pants > > plugin is the way to go here. Historically we have been very bad at > > upgrading pants and maintaining it, I'm afraid that if we add a custom > > plugin here w

Re: Review Request 40219: Replace Twitter checkstyle with pants checkstyle.

2015-11-12 Thread John Sirois
> On Nov. 12, 2015, 12:05 p.m., Zameer Manji wrote: > > Although the end result LGTM, I'm not sure if having our own custom pants > > plugin is the way to go here. Historically we have been very bad at > > upgrading pants and maintaining it, I'm afraid that if we add a custom > > plugin here w

Re: Review Request 40219: Replace Twitter checkstyle with pants checkstyle.

2015-11-12 Thread John Sirois
> On Nov. 12, 2015, 12:05 p.m., Zameer Manji wrote: > > Although the end result LGTM, I'm not sure if having our own custom pants > > plugin is the way to go here. Historically we have been very bad at > > upgrading pants and maintaining it, I'm afraid that if we add a custom > > plugin here w

Re: Review Request 40219: Replace Twitter checkstyle with pants checkstyle.

2015-11-12 Thread Zameer Manji
> On Nov. 12, 2015, 11:05 a.m., Zameer Manji wrote: > > Although the end result LGTM, I'm not sure if having our own custom pants > > plugin is the way to go here. Historically we have been very bad at > > upgrading pants and maintaining it, I'm afraid that if we add a custom > > plugin here w

Re: Review Request 40219: Replace Twitter checkstyle with pants checkstyle.

2015-11-12 Thread John Sirois
> On Nov. 12, 2015, 12:05 p.m., Zameer Manji wrote: > > Although the end result LGTM, I'm not sure if having our own custom pants > > plugin is the way to go here. Historically we have been very bad at > > upgrading pants and maintaining it, I'm afraid that if we add a custom > > plugin here w

Re: Review Request 40219: Replace Twitter checkstyle with pants checkstyle.

2015-11-12 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40219/#review106301 --- Although the end result LGTM, I'm not sure if having our own custom

Re: Review Request 40219: Replace Twitter checkstyle with pants checkstyle.

2015-11-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40219/#review106213 --- Ship it! Master (48aedae) is green with this patch. ./build-supp

Re: Review Request 40219: Replace Twitter checkstyle with pants checkstyle.

2015-11-12 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40219/ --- (Updated Nov. 12, 2015, 1:54 a.m.) Review request for Aurora, Joshua Cohen, Joe

Re: Review Request 40219: Replace Twitter checkstyle with pants checkstyle.

2015-11-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40219/#review106207 --- Ship it! Master (48aedae) is green with this patch. ./build-supp