Re: Review Request 40249: [cli] Remove unused --local flag to job inspect command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40249/#review106317 --- Master (b4102de) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 12, 2015, 7:46 p.m., Paul Cavallaro wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40249/ > --- > > (Updated Nov. 12, 2015, 7:46 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > --- > > [cli] Remove unused --local flag to job inspect command > > > Diffs > - > > src/main/python/apache/aurora/client/cli/jobs.py > 6dd9dec76a6cb2420469e4502ece60854b85155a > > Diff: https://reviews.apache.org/r/40249/diff/ > > > Testing > --- > > ./pants binary src/main/python/apache/aurora/client:aurora > ./dist/aurora.pex job inspect --help > ./dist/aurora.pex job inspect 'ed a config and looked correct > > > Didn't find any python_tests targets under the CLI [edit: incorrect] > > EDIT: > > Tested with: > ./pants test src/test/python/apache/aurora/client: > > Had failures in: > src/test/python/apache/aurora/client/cli/test_update.py > > Ran just those tests, and passed again, so perhaps flaky? > ./pants test src/test/python/apache/aurora/client/cli:update [passes] > > > Thanks, > > Paul Cavallaro > >
Re: Review Request 40249: [cli] Remove unused --local flag to job inspect command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40249/ --- (Updated Nov. 12, 2015, 7:46 p.m.) Review request for Aurora. Changes --- Updated testing Repository: aurora Description --- [cli] Remove unused --local flag to job inspect command Diffs - src/main/python/apache/aurora/client/cli/jobs.py 6dd9dec76a6cb2420469e4502ece60854b85155a Diff: https://reviews.apache.org/r/40249/diff/ Testing (updated) --- ./pants binary src/main/python/apache/aurora/client:aurora ./dist/aurora.pex job inspect --help ./dist/aurora.pex job inspect 'ed a config and looked correct Didn't find any python_tests targets under the CLI [edit: incorrect] EDIT: Tested with: ./pants test src/test/python/apache/aurora/client: Had failures in: src/test/python/apache/aurora/client/cli/test_update.py Ran just those tests, and passed again, so perhaps flaky? ./pants test src/test/python/apache/aurora/client/cli:update [passes] Thanks, Paul Cavallaro
Re: Review Request 40249: [cli] Remove unused --local flag to job inspect command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40249/#review106359 --- Ship it! Ship It! - Bill Farner On Nov. 12, 2015, 11:46 a.m., Paul Cavallaro wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40249/ > --- > > (Updated Nov. 12, 2015, 11:46 a.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > --- > > [cli] Remove unused --local flag to job inspect command > > > Diffs > - > > src/main/python/apache/aurora/client/cli/jobs.py > 6dd9dec76a6cb2420469e4502ece60854b85155a > > Diff: https://reviews.apache.org/r/40249/diff/ > > > Testing > --- > > ./pants binary src/main/python/apache/aurora/client:aurora > ./dist/aurora.pex job inspect --help > ./dist/aurora.pex job inspect 'ed a config and looked correct > > > Didn't find any python_tests targets under the CLI [edit: incorrect] > > EDIT: > > Tested with: > ./pants test src/test/python/apache/aurora/client: > > Had failures in: > src/test/python/apache/aurora/client/cli/test_update.py > > Ran just those tests, and passed again, so perhaps flaky? > ./pants test src/test/python/apache/aurora/client/cli:update [passes] > > > Thanks, > > Paul Cavallaro > >
