Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/#review107689 --- Ship it! Stepping in for Maxim. - Bill Farner On Nov. 16,

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/#review106674 --- pants.ini (line 19)

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/ --- (Updated Nov. 16, 2015, 10:30 a.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/#review106689 --- Ship it! Master (7b494f4) is green with this patch.

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/#review106694 --- Ship it! Ship It! - Joshua Cohen On Nov. 16, 2015, 5:30 p.m.,

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

> On Nov. 16, 2015, 9:27 a.m., Joshua Cohen wrote: > > src/test/python/apache/aurora/admin/test_admin.py, lines 158-160 > > > > > > Why kill this? It seems like the intention was to ensure that set quota > > is

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/ --- (Updated Nov. 16, 2015, 1:09 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

> On Nov. 16, 2015, 12:43 p.m., Zameer Manji wrote: > > pants.ini, line 49 > > > > > > Out of curiosity, could we replace isort with this functionality? I > > like the idea of collapsing all of that functionality

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/ --- (Updated Nov. 16, 2015, 1:11 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/#review106710 --- Ship it! LGTM. pants.ini (line 49)

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/#review106572 --- This is now rebased against https://reviews.apache.org/r/40334/ in

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/#review106576 --- Ship it! Master (7b494f4) is green with this patch.

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/ --- (Updated Nov. 15, 2015, 4:34 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/ --- (Updated Nov. 15, 2015, 9:02 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/#review106505 --- Ship it! Master (ba9819e) is green with this patch.

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/ --- (Updated Nov. 13, 2015, 4:27 p.m.) Review request for Aurora, Joshua Cohen,