Re: Review Request 40391: Introduce a utility class to read executor configurations in JSON.

2015-11-17 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40391/#review106946
---

Ship it!


Ship It!

- Zameer Manji


On Nov. 17, 2015, 9:51 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40391/
> ---
> 
> (Updated Nov. 17, 2015, 9:51 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Bugs: AURORA-1376
> https://issues.apache.org/jira/browse/AURORA-1376
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Another bit-sized chunk towards AURORA-1376.  The follow-up will allow an 
> executor configuration file to be provided on the scheduler command line.
> 
> 
> Diffs
> -
> 
>   build.gradle 17dbd2575138880e8ecbbee2b9daf0f1631172c3 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 
> 556a3f80236971f6b6cf443d9d1de9394a3aae2d 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoaderTest.java
>  PRE-CREATION 
>   
> src/test/resources/org/apache/aurora/scheduler/configuration/executor/test-missing-field.json
>  PRE-CREATION 
>   
> src/test/resources/org/apache/aurora/scheduler/configuration/executor/test-thermos-executor.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40391/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 40391: Introduce a utility class to read executor configurations in JSON.

2015-11-17 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40391/#review106901
---

Ship it!


Master (7b1e848) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 17, 2015, 5:51 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40391/
> ---
> 
> (Updated Nov. 17, 2015, 5:51 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Bugs: AURORA-1376
> https://issues.apache.org/jira/browse/AURORA-1376
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Another bit-sized chunk towards AURORA-1376.  The follow-up will allow an 
> executor configuration file to be provided on the scheduler command line.
> 
> 
> Diffs
> -
> 
>   build.gradle 17dbd2575138880e8ecbbee2b9daf0f1631172c3 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 
> 556a3f80236971f6b6cf443d9d1de9394a3aae2d 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoaderTest.java
>  PRE-CREATION 
>   
> src/test/resources/org/apache/aurora/scheduler/configuration/executor/test-missing-field.json
>  PRE-CREATION 
>   
> src/test/resources/org/apache/aurora/scheduler/configuration/executor/test-thermos-executor.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40391/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 40391: Introduce a utility class to read executor configurations in JSON.

2015-11-17 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40391/#review106895
---

Ship it!


Ship It!

- John Sirois


On Nov. 17, 2015, 10:51 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40391/
> ---
> 
> (Updated Nov. 17, 2015, 10:51 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Bugs: AURORA-1376
> https://issues.apache.org/jira/browse/AURORA-1376
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Another bit-sized chunk towards AURORA-1376.  The follow-up will allow an 
> executor configuration file to be provided on the scheduler command line.
> 
> 
> Diffs
> -
> 
>   build.gradle 17dbd2575138880e8ecbbee2b9daf0f1631172c3 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 
> 556a3f80236971f6b6cf443d9d1de9394a3aae2d 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoaderTest.java
>  PRE-CREATION 
>   
> src/test/resources/org/apache/aurora/scheduler/configuration/executor/test-missing-field.json
>  PRE-CREATION 
>   
> src/test/resources/org/apache/aurora/scheduler/configuration/executor/test-thermos-executor.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40391/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 40391: Introduce a utility class to read executor configurations in JSON.

2015-11-17 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40391/
---

(Updated Nov. 17, 2015, 9:51 a.m.)


Review request for Aurora, John Sirois and Zameer Manji.


Bugs: AURORA-1376
https://issues.apache.org/jira/browse/AURORA-1376


Repository: aurora


Description
---

Another bit-sized chunk towards AURORA-1376.  The follow-up will allow an 
executor configuration file to be provided on the scheduler command line.


Diffs (updated)
-

  build.gradle 17dbd2575138880e8ecbbee2b9daf0f1631172c3 
  
src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java
 PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 
556a3f80236971f6b6cf443d9d1de9394a3aae2d 
  
src/test/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoaderTest.java
 PRE-CREATION 
  
src/test/resources/org/apache/aurora/scheduler/configuration/executor/test-missing-field.json
 PRE-CREATION 
  
src/test/resources/org/apache/aurora/scheduler/configuration/executor/test-thermos-executor.json
 PRE-CREATION 

Diff: https://reviews.apache.org/r/40391/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 40391: Introduce a utility class to read executor configurations in JSON.

2015-11-17 Thread Bill Farner 


> On Nov. 17, 2015, 8:57 a.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java,
> >  line 79
> > 
> >
> > Isn't Schema.class enough?  No type parameter to capture here.

Right, thanks.  Fixed.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40391/#review106882
---


On Nov. 17, 2015, 8:28 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40391/
> ---
> 
> (Updated Nov. 17, 2015, 8:28 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Bugs: AURORA-1376
> https://issues.apache.org/jira/browse/AURORA-1376
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Another bit-sized chunk towards AURORA-1376.  The follow-up will allow an 
> executor configuration file to be provided on the scheduler command line.
> 
> 
> Diffs
> -
> 
>   build.gradle 17dbd2575138880e8ecbbee2b9daf0f1631172c3 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 
> 556a3f80236971f6b6cf443d9d1de9394a3aae2d 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoaderTest.java
>  PRE-CREATION 
>   
> src/test/resources/org/apache/aurora/scheduler/configuration/executor/test-missing-field.json
>  PRE-CREATION 
>   
> src/test/resources/org/apache/aurora/scheduler/configuration/executor/test-thermos-executor.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40391/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 40391: Introduce a utility class to read executor configurations in JSON.

2015-11-17 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40391/#review106882
---

Ship it!



src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java
 (line 79)


Isn't Schema.class enough?  No type parameter to capture here.


- John Sirois


On Nov. 17, 2015, 9:28 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40391/
> ---
> 
> (Updated Nov. 17, 2015, 9:28 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Bugs: AURORA-1376
> https://issues.apache.org/jira/browse/AURORA-1376
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Another bit-sized chunk towards AURORA-1376.  The follow-up will allow an 
> executor configuration file to be provided on the scheduler command line.
> 
> 
> Diffs
> -
> 
>   build.gradle 17dbd2575138880e8ecbbee2b9daf0f1631172c3 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 
> 556a3f80236971f6b6cf443d9d1de9394a3aae2d 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoaderTest.java
>  PRE-CREATION 
>   
> src/test/resources/org/apache/aurora/scheduler/configuration/executor/test-missing-field.json
>  PRE-CREATION 
>   
> src/test/resources/org/apache/aurora/scheduler/configuration/executor/test-thermos-executor.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40391/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 40391: Introduce a utility class to read executor configurations in JSON.

2015-11-17 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40391/#review106878
---

Ship it!


Master (7b1e848) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 17, 2015, 4:28 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40391/
> ---
> 
> (Updated Nov. 17, 2015, 4:28 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Bugs: AURORA-1376
> https://issues.apache.org/jira/browse/AURORA-1376
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Another bit-sized chunk towards AURORA-1376.  The follow-up will allow an 
> executor configuration file to be provided on the scheduler command line.
> 
> 
> Diffs
> -
> 
>   build.gradle 17dbd2575138880e8ecbbee2b9daf0f1631172c3 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 
> 556a3f80236971f6b6cf443d9d1de9394a3aae2d 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoaderTest.java
>  PRE-CREATION 
>   
> src/test/resources/org/apache/aurora/scheduler/configuration/executor/test-missing-field.json
>  PRE-CREATION 
>   
> src/test/resources/org/apache/aurora/scheduler/configuration/executor/test-thermos-executor.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40391/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>