Re: Review Request 41528: Fixup `getJobSummary` for cron jobs with invalid next run dates.

2015-12-18 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41528/#review57 --- Ship it! Thanks for looking into this! - Stephan Erb On Dec.

Re: Review Request 41528: Fixup `getJobSummary` for cron jobs with invalid next run dates.

2015-12-17 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41528/ --- (Updated Dec. 17, 2015, 1:34 p.m.) Review request for Aurora, Stephan Erb,

Re: Review Request 41528: Fixup `getJobSummary` for cron jobs with invalid next run dates.

2015-12-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41528/#review111037 --- Ship it! Ship It! - Bill Farner On Dec. 17, 2015, 12:34 p.m.,

Re: Review Request 41528: Fixup `getJobSummary` for cron jobs with invalid next run dates.

2015-12-17 Thread John Sirois
> On Dec. 17, 2015, 2:17 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/cron/CronPredictor.java, line 29 > > > > > > nit: is enough to split paragraphs. Thanks - fixed. I could have

Re: Review Request 41528: Fixup `getJobSummary` for cron jobs with invalid next run dates.

2015-12-17 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41528/#review111098 --- Ship it! Master (93fb2c7) is green with this patch.