Re: Review Request 41659: Support in-flight review chains via `depends-on`.

2015-12-27 Thread John Sirois
> On Dec. 23, 2015, 9:48 a.m., Joshua Cohen wrote: > > build-support/jenkins/review_feedback.py, lines 142-143 > > > > > > Not sure there's anything we can do about it, but if the review has > > been committed but t

Re: Review Request 41659: Support in-flight review chains via `depends-on`.

2015-12-24 Thread Joshua Cohen
> On Dec. 23, 2015, 4:48 p.m., Joshua Cohen wrote: > > build-support/jenkins/review_feedback.py, lines 142-143 > > > > > > Not sure there's anything we can do about it, but if the review has > > been committed but t

Re: Review Request 41659: Support in-flight review chains via `depends-on`.

2015-12-23 Thread John Sirois
> On Dec. 23, 2015, 9:48 a.m., Joshua Cohen wrote: > > build-support/jenkins/review_feedback.py, lines 142-143 > > > > > > Not sure there's anything we can do about it, but if the review has > > been committed but t

Re: Review Request 41659: Support in-flight review chains via `depends-on`.

2015-12-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41659/#review111791 --- Ship it! Ship It! - Bill Farner On Dec. 22, 2015, 1:34 p.m., Jo

Re: Review Request 41659: Support in-flight review chains via `depends-on`.

2015-12-23 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41659/#review111790 --- Ship it! lgtm, thanks for adding this! Let me know what you think

Re: Review Request 41659: Support in-flight review chains via `depends-on`.

2015-12-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41659/#review111667 --- Ship it! Master (e75cdba) is green with this patch. ./build-supp

Re: Review Request 41659: Support in-flight review chains via `depends-on`.

2015-12-22 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41659/ --- (Updated Dec. 22, 2015, 2:34 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 41659: Support in-flight review chains via `depends-on`.

2015-12-22 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41659/#review111663 --- One assumption I used in testing this against my local server was t