Re: Review Request 41711: Move all command line argument declarations to modules or SchedulerMain.

2015-12-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41711/ --- (Updated Dec. 28, 2015, 11:46 a.m.) Review request for Aurora and Zameer Manji.

Re: Review Request 41711: Move all command line argument declarations to modules or SchedulerMain.

2015-12-28 Thread Bill Farner
> On Dec. 28, 2015, 7:20 a.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/Thresholds.java, line 19 > > > > > > Please add a `toString` method to this class. Done. - Bill

Re: Review Request 41711: Move all command line argument declarations to modules or SchedulerMain.

2015-12-28 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41711/#review111980 --- Ship it! LGTM. Removing the access of global state is good as it i

Re: Review Request 41711: Move all command line argument declarations to modules or SchedulerMain.

2015-12-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41711/#review111883 --- Ship it! Master (1ae77d5) is green with this patch. ./build-supp