Re: Review Request 41717: Add jittering to TruncatedBinaryBackoff.

2016-01-03 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41717/#review112459
---


Master (4a9f2ff) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 3, 2016, 3:39 p.m., Tony Dong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41717/
> ---
> 
> (Updated Jan. 3, 2016, 3:39 p.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add jittering to TruncatedBinaryBackoff.
> 
> 
> Diffs
> -
> 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/EnumParser.java 
> 9f6a3ff977ef6a0e2d472a8e2cf90e7f9a63a985 
>   
> commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java
>  fd74b9f37c6cc24c7ea1cb239ba6354661d931e2 
>   
> commons/src/test/java/org/apache/aurora/common/util/TruncatedBinaryBackoffTest.java
>  127a60331f8560d98733bd16654087f840abef72 
>   src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 
> fbc589e9a7592cce6d92c4e987cde2e056406c3a 
>   
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java
>  291bf5f0baefef6dd10d19ec89e173ce495e6380 
> 
> Diff: https://reviews.apache.org/r/41717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tony Dong
> 
>

Re: Review Request 41717: Add jittering to TruncatedBinaryBackoff.

2016-01-03 Thread Tony Dong 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41717/
---

(Updated Jan. 3, 2016, 3:24 p.m.)


Review request for Aurora, Stephan Erb and Bill Farner.


Summary (updated)
-

Add jittering to TruncatedBinaryBackoff.


Repository: aurora


Description (updated)
---

Add jittering to TruncatedBinaryBackoff.


Diffs
-

  commons/src/main/java/org/apache/aurora/common/args/parsers/EnumParser.java 
9f6a3ff977ef6a0e2d472a8e2cf90e7f9a63a985 
  
commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java 
fd74b9f37c6cc24c7ea1cb239ba6354661d931e2 
  
commons/src/test/java/org/apache/aurora/common/util/TruncatedBinaryBackoffTest.java
 127a60331f8560d98733bd16654087f840abef72 
  src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 
fbc589e9a7592cce6d92c4e987cde2e056406c3a 
  
src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 
291bf5f0baefef6dd10d19ec89e173ce495e6380 

Diff: https://reviews.apache.org/r/41717/diff/


Testing
---


Thanks,

Tony Dong

Re: Review Request 41717: Add jittering to TruncatedBinaryBackoff.

2016-01-03 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41717/#review112469
---

Ship it!


LGTM after Stephan's comment is addressed.


commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java 
(line 53)


convention nit: `checkNotNull(random)`


- Bill Farner


On Jan. 3, 2016, 7:39 a.m., Tony Dong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41717/
> ---
> 
> (Updated Jan. 3, 2016, 7:39 a.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add jittering to TruncatedBinaryBackoff.
> 
> 
> Diffs
> -
> 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/EnumParser.java 
> 9f6a3ff977ef6a0e2d472a8e2cf90e7f9a63a985 
>   
> commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java
>  fd74b9f37c6cc24c7ea1cb239ba6354661d931e2 
>   
> commons/src/test/java/org/apache/aurora/common/util/TruncatedBinaryBackoffTest.java
>  127a60331f8560d98733bd16654087f840abef72 
>   src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 
> fbc589e9a7592cce6d92c4e987cde2e056406c3a 
>   
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java
>  291bf5f0baefef6dd10d19ec89e173ce495e6380 
> 
> Diff: https://reviews.apache.org/r/41717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tony Dong
> 
>

Re: Review Request 41717: Add jittering to TruncatedBinaryBackoff.

2016-01-03 Thread Tony Dong 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41717/
---

(Updated Jan. 3, 2016, 5:51 p.m.)


Review request for Aurora, Stephan Erb and Bill Farner.


Repository: aurora


Description
---

Add jittering to TruncatedBinaryBackoff.


Diffs (updated)
-

  commons/src/main/java/org/apache/aurora/common/args/parsers/EnumParser.java 
9f6a3ff977ef6a0e2d472a8e2cf90e7f9a63a985 
  
commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java 
fd74b9f37c6cc24c7ea1cb239ba6354661d931e2 
  
commons/src/test/java/org/apache/aurora/common/util/TruncatedBinaryBackoffTest.java
 127a60331f8560d98733bd16654087f840abef72 
  src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 
fbc589e9a7592cce6d92c4e987cde2e056406c3a 
  
src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 
291bf5f0baefef6dd10d19ec89e173ce495e6380 

Diff: https://reviews.apache.org/r/41717/diff/


Testing
---


Thanks,

Tony Dong

Re: Review Request 41717: Add jittering to TruncatedBinaryBackoff.

2016-01-03 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41717/#review112470
---


Doh!  I'm ready to apply this, but i can't land the patch and give you credit 
on the commit log without access to your e-mail in ReviewBoard.

Please go here: https://reviews.apache.org/account/preferences/#profile
and untick `Keep profile information private`

- Bill Farner


On Jan. 3, 2016, 9:51 a.m., Tony Dong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41717/
> ---
> 
> (Updated Jan. 3, 2016, 9:51 a.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add jittering to TruncatedBinaryBackoff.
> 
> 
> Diffs
> -
> 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/EnumParser.java 
> 9f6a3ff977ef6a0e2d472a8e2cf90e7f9a63a985 
>   
> commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java
>  fd74b9f37c6cc24c7ea1cb239ba6354661d931e2 
>   
> commons/src/test/java/org/apache/aurora/common/util/TruncatedBinaryBackoffTest.java
>  127a60331f8560d98733bd16654087f840abef72 
>   src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 
> fbc589e9a7592cce6d92c4e987cde2e056406c3a 
>   
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java
>  291bf5f0baefef6dd10d19ec89e173ce495e6380 
> 
> Diff: https://reviews.apache.org/r/41717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tony Dong
> 
>

Re: Review Request 41717: Add jittering to TruncatedBinaryBackoff.

2016-01-03 Thread Tony Dong 


> On Jan. 3, 2016, 5:55 p.m., Bill Farner wrote:
> > Doh!  I'm ready to apply this, but i can't land the patch and give you 
> > credit on the commit log without access to your e-mail in ReviewBoard.
> > 
> > Please go here: https://reviews.apache.org/account/preferences/#profile
> > and untick `Keep profile information private`

unchecked, Thanks!


- Tony


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41717/#review112470
---


On Jan. 3, 2016, 5:51 p.m., Tony Dong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41717/
> ---
> 
> (Updated Jan. 3, 2016, 5:51 p.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add jittering to TruncatedBinaryBackoff.
> 
> 
> Diffs
> -
> 
>   commons/src/main/java/org/apache/aurora/common/args/parsers/EnumParser.java 
> 9f6a3ff977ef6a0e2d472a8e2cf90e7f9a63a985 
>   
> commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java
>  fd74b9f37c6cc24c7ea1cb239ba6354661d931e2 
>   
> commons/src/test/java/org/apache/aurora/common/util/TruncatedBinaryBackoffTest.java
>  127a60331f8560d98733bd16654087f840abef72 
>   src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 
> fbc589e9a7592cce6d92c4e987cde2e056406c3a 
>   
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java
>  291bf5f0baefef6dd10d19ec89e173ce495e6380 
> 
> Diff: https://reviews.apache.org/r/41717/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tony Dong
> 
>