Re: Review Request 41732: Slight documentation overhaul

2015-12-28 Thread Stephan Erb 


> On Dec. 27, 2015, 11:20 p.m., Stephan Erb wrote:
> > Looks like you have pushed the previous version without the review changes.
> 
> Bill Farner wrote:
> Oy, sorry about that.  I yanked it from your branch (since i can't pull 
> the patch with binaries) and neglected to check if it matched the review 
> patch.  I don't suppose you can post a new review with that last round?

I will post another review request the comming days with some more 
documentation work. I'll include the changes in there.


- Stephan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41732/#review111944
---


On Dec. 27, 2015, 10:46 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41732/
> ---
> 
> (Updated Dec. 27, 2015, 10:46 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've updated the documentation in a few places. The most important changes 
> include:
> 
> * Add logo to README to make the github frontpage a little bit more inviting
> * Slim down the README, especially by moving build instructions to the 
> corresponding documentation file
> * Add a list of tools related to Aurora
> * Add missing documentation files to index. They should now show up on the 
> website
> * Removing slight duplication or outdated information
> 
> 
> Diffs
> -
> 
>   README.md 143ee06f45afc5164cb5f22c86af7f62f2d1527b 
>   docs/README.md 1ace7f7909c7ee2deaeb02bc298ce6e14aed8325 
>   docs/client-cluster-configuration.md 
> 86bd17cf2ca84d0e467be18fd957ce1d6f35e37c 
>   docs/developing-aurora-client.md 09abc009cf1922692b69f05cad9226a753fc2b16 
>   docs/developing-aurora-scheduler.md 
> f52c76e2c2fe9ebca75c5f5db4ac2de842879f01 
>   docs/images/aurora_logo.png PRE-CREATION 
>   docs/tools.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41732/diff/
> 
> 
> Testing
> ---
> 
> Rendered version is available at 
> https://github.com/StephanErb/aurora/tree/docu-update
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 41732: Slight documentation overhaul

2015-12-27 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41732/
---

(Updated Dec. 27, 2015, 12:57 p.m.)


Review request for Aurora and Bill Farner.


Repository: aurora


Description
---

I've updated the documentation in a few places. The most important changes 
include:

* Add logo to README to make the github frontpage a little bit more inviting
* Slim down the README, especially by moving build instructions to the 
corresponding documentation file
* Add a list of tools related to Aurora
* Add missing documentation files to index. They should now show up on the 
website
* Removing slight duplication or outdated information


Diffs (updated)
-

  README.md 143ee06f45afc5164cb5f22c86af7f62f2d1527b 
  docs/README.md 1ace7f7909c7ee2deaeb02bc298ce6e14aed8325 
  docs/client-cluster-configuration.md 86bd17cf2ca84d0e467be18fd957ce1d6f35e37c 
  docs/developing-aurora-client.md 09abc009cf1922692b69f05cad9226a753fc2b16 
  docs/developing-aurora-scheduler.md f52c76e2c2fe9ebca75c5f5db4ac2de842879f01 
  docs/images/aurora_logo.png PRE-CREATION 
  docs/tools.md PRE-CREATION 

Diff: https://reviews.apache.org/r/41732/diff/


Testing
---

Rendered version is available at 
https://github.com/StephanErb/aurora/tree/docu-update


Thanks,

Stephan Erb

Re: Review Request 41732: Slight documentation overhaul

2015-12-27 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41732/#review111934
---


Thanks!  This was sorely needed.  Only a few very minor issues.


README.md (line 12)


This appears out of place.  Perhaps turn `Apache Aurora` in the first line 
to an anchor?



README.md (line 17)


s/build/built/



docs/README.md (line 22)


Typo on 'configuration'



docs/developing-aurora-scheduler.md (line 59)


`./` instead of `bash `



docs/tools.md (line 3)


s/There is/Is there/


- Bill Farner


On Dec. 27, 2015, 3:57 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41732/
> ---
> 
> (Updated Dec. 27, 2015, 3:57 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've updated the documentation in a few places. The most important changes 
> include:
> 
> * Add logo to README to make the github frontpage a little bit more inviting
> * Slim down the README, especially by moving build instructions to the 
> corresponding documentation file
> * Add a list of tools related to Aurora
> * Add missing documentation files to index. They should now show up on the 
> website
> * Removing slight duplication or outdated information
> 
> 
> Diffs
> -
> 
>   README.md 143ee06f45afc5164cb5f22c86af7f62f2d1527b 
>   docs/README.md 1ace7f7909c7ee2deaeb02bc298ce6e14aed8325 
>   docs/client-cluster-configuration.md 
> 86bd17cf2ca84d0e467be18fd957ce1d6f35e37c 
>   docs/developing-aurora-client.md 09abc009cf1922692b69f05cad9226a753fc2b16 
>   docs/developing-aurora-scheduler.md 
> f52c76e2c2fe9ebca75c5f5db4ac2de842879f01 
>   docs/images/aurora_logo.png PRE-CREATION 
>   docs/tools.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41732/diff/
> 
> 
> Testing
> ---
> 
> Rendered version is available at 
> https://github.com/StephanErb/aurora/tree/docu-update
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 41732: Slight documentation overhaul

2015-12-27 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41732/
---

(Updated Dec. 27, 2015, 10:46 p.m.)


Review request for Aurora and Bill Farner.


Changes
---

Bill's suggestions


Repository: aurora


Description
---

I've updated the documentation in a few places. The most important changes 
include:

* Add logo to README to make the github frontpage a little bit more inviting
* Slim down the README, especially by moving build instructions to the 
corresponding documentation file
* Add a list of tools related to Aurora
* Add missing documentation files to index. They should now show up on the 
website
* Removing slight duplication or outdated information


Diffs (updated)
-

  README.md 143ee06f45afc5164cb5f22c86af7f62f2d1527b 
  docs/README.md 1ace7f7909c7ee2deaeb02bc298ce6e14aed8325 
  docs/client-cluster-configuration.md 86bd17cf2ca84d0e467be18fd957ce1d6f35e37c 
  docs/developing-aurora-client.md 09abc009cf1922692b69f05cad9226a753fc2b16 
  docs/developing-aurora-scheduler.md f52c76e2c2fe9ebca75c5f5db4ac2de842879f01 
  docs/images/aurora_logo.png PRE-CREATION 
  docs/tools.md PRE-CREATION 

Diff: https://reviews.apache.org/r/41732/diff/


Testing
---

Rendered version is available at 
https://github.com/StephanErb/aurora/tree/docu-update


Thanks,

Stephan Erb

Re: Review Request 41732: Slight documentation overhaul

2015-12-27 Thread Bill Farner 


> On Dec. 27, 2015, 2:20 p.m., Stephan Erb wrote:
> > Looks like you have pushed the previous version without the review changes.

Oy, sorry about that.  I yanked it from your branch (since i can't pull the 
patch with binaries) and neglected to check if it matched the review patch.  I 
don't suppose you can post a new review with that last round?


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41732/#review111944
---


On Dec. 27, 2015, 1:46 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41732/
> ---
> 
> (Updated Dec. 27, 2015, 1:46 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've updated the documentation in a few places. The most important changes 
> include:
> 
> * Add logo to README to make the github frontpage a little bit more inviting
> * Slim down the README, especially by moving build instructions to the 
> corresponding documentation file
> * Add a list of tools related to Aurora
> * Add missing documentation files to index. They should now show up on the 
> website
> * Removing slight duplication or outdated information
> 
> 
> Diffs
> -
> 
>   README.md 143ee06f45afc5164cb5f22c86af7f62f2d1527b 
>   docs/README.md 1ace7f7909c7ee2deaeb02bc298ce6e14aed8325 
>   docs/client-cluster-configuration.md 
> 86bd17cf2ca84d0e467be18fd957ce1d6f35e37c 
>   docs/developing-aurora-client.md 09abc009cf1922692b69f05cad9226a753fc2b16 
>   docs/developing-aurora-scheduler.md 
> f52c76e2c2fe9ebca75c5f5db4ac2de842879f01 
>   docs/images/aurora_logo.png PRE-CREATION 
>   docs/tools.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41732/diff/
> 
> 
> Testing
> ---
> 
> Rendered version is available at 
> https://github.com/StephanErb/aurora/tree/docu-update
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 41732: Slight documentation overhaul

2015-12-27 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41732/#review111941
---


This patch does not apply cleanly against master (1b43126), do you need to 
rebase?

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Dec. 27, 2015, 9:46 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41732/
> ---
> 
> (Updated Dec. 27, 2015, 9:46 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've updated the documentation in a few places. The most important changes 
> include:
> 
> * Add logo to README to make the github frontpage a little bit more inviting
> * Slim down the README, especially by moving build instructions to the 
> corresponding documentation file
> * Add a list of tools related to Aurora
> * Add missing documentation files to index. They should now show up on the 
> website
> * Removing slight duplication or outdated information
> 
> 
> Diffs
> -
> 
>   README.md 143ee06f45afc5164cb5f22c86af7f62f2d1527b 
>   docs/README.md 1ace7f7909c7ee2deaeb02bc298ce6e14aed8325 
>   docs/client-cluster-configuration.md 
> 86bd17cf2ca84d0e467be18fd957ce1d6f35e37c 
>   docs/developing-aurora-client.md 09abc009cf1922692b69f05cad9226a753fc2b16 
>   docs/developing-aurora-scheduler.md 
> f52c76e2c2fe9ebca75c5f5db4ac2de842879f01 
>   docs/images/aurora_logo.png PRE-CREATION 
>   docs/tools.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41732/diff/
> 
> 
> Testing
> ---
> 
> Rendered version is available at 
> https://github.com/StephanErb/aurora/tree/docu-update
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 41732: Slight documentation overhaul

2015-12-27 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41732/#review111944
---


Looks like you have pushed the previous version without the review changes.

- Stephan Erb


On Dec. 27, 2015, 10:46 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41732/
> ---
> 
> (Updated Dec. 27, 2015, 10:46 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've updated the documentation in a few places. The most important changes 
> include:
> 
> * Add logo to README to make the github frontpage a little bit more inviting
> * Slim down the README, especially by moving build instructions to the 
> corresponding documentation file
> * Add a list of tools related to Aurora
> * Add missing documentation files to index. They should now show up on the 
> website
> * Removing slight duplication or outdated information
> 
> 
> Diffs
> -
> 
>   README.md 143ee06f45afc5164cb5f22c86af7f62f2d1527b 
>   docs/README.md 1ace7f7909c7ee2deaeb02bc298ce6e14aed8325 
>   docs/client-cluster-configuration.md 
> 86bd17cf2ca84d0e467be18fd957ce1d6f35e37c 
>   docs/developing-aurora-client.md 09abc009cf1922692b69f05cad9226a753fc2b16 
>   docs/developing-aurora-scheduler.md 
> f52c76e2c2fe9ebca75c5f5db4ac2de842879f01 
>   docs/images/aurora_logo.png PRE-CREATION 
>   docs/tools.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41732/diff/
> 
> 
> Testing
> ---
> 
> Rendered version is available at 
> https://github.com/StephanErb/aurora/tree/docu-update
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 41732: Slight documentation overhaul

2015-12-26 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41732/#review111913
---

Ship it!


Master (1ae77d5) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Dec. 27, 2015, 1:04 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41732/
> ---
> 
> (Updated Dec. 27, 2015, 1:04 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've updated the documentation in a few places. The most important changes 
> include:
> 
> * Add logo to README to make the github frontpage a little bit more inviting
> * Slim down the README, especially by moving build instructions to the 
> corresponding documentation file
> * Add a list of tools related to Aurora
> * Add missing documentation files to index. They should now show up on the 
> website
> * Removing slight duplication or outdated information
> 
> 
> Diffs
> -
> 
>   README.md 143ee06f45afc5164cb5f22c86af7f62f2d1527b 
>   docs/README.md 1ace7f7909c7ee2deaeb02bc298ce6e14aed8325 
>   docs/client-cluster-configuration.md 
> 86bd17cf2ca84d0e467be18fd957ce1d6f35e37c 
>   docs/developing-aurora-client.md 09abc009cf1922692b69f05cad9226a753fc2b16 
>   docs/developing-aurora-scheduler.md 
> f52c76e2c2fe9ebca75c5f5db4ac2de842879f01 
>   docs/images/aurora_logo.png PRE-CREATION 
>   docs/tools.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41732/diff/
> 
> 
> Testing
> ---
> 
> Rendered version is available at 
> https://github.com/StephanErb/aurora/tree/docu-update
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>