Re: Review Request 41917: Avoid zk 3.4.7 to fix test hangs.

2016-01-05 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41917/#review112874
---

Ship it!


Ship It!

- Bill Farner


On Jan. 4, 2016, 11:37 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41917/
> ---
> 
> (Updated Jan. 4, 2016, 11:37 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko, Stephan Erb, and Bill Farner.
> 
> 
> Bugs: ZOOKEEPER-2347
> https://issues.apache.org/jira/browse/ZOOKEEPER-2347
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The commons tests hang under CI after bumping from zk 3.4.2 to 3.4.7.
> Although not root-caused, this zk bug introduced in 3.4.7 seems like a
> match for this sort of hang:
>   https://issues.apache.org/jira/browse/ZOOKEEPER-2347
> 
> Downgrade to 3.4.6 with a note about why 3.4.7 should be skipped.
> 
>  NEWS | 2 +-
>  build.gradle | 4 +++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> 
> Diffs
> -
> 
>   NEWS a4775adb18938ad80ee752e37d3f7c10549d3b70 
>   build.gradle 14ebf6b1d295e0780b7e390d00efadb25d30fc79 
> 
> Diff: https://reviews.apache.org/r/41917/diff/
> 
> 
> Testing
> ---
> 
> Locally green: `./build-support/jenkins/build.sh`.
> 
> That said - I could not reproduce the CI 120 minute timeouts as seen 
> here:
>   https://builds.apache.org/job/Aurora/1312/
>   https://builds.apache.org/job/Aurora/1313/
> 
> 
> Thanks,
> 
> John Sirois
> 
>



Re: Review Request 41917: Avoid zk 3.4.7 to fix test hangs.

2016-01-05 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41917/#review112872
---

Ship it!


Ship It!

- Maxim Khutornenko


On Jan. 5, 2016, 7:37 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41917/
> ---
> 
> (Updated Jan. 5, 2016, 7:37 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko, Stephan Erb, and Bill Farner.
> 
> 
> Bugs: ZOOKEEPER-2347
> https://issues.apache.org/jira/browse/ZOOKEEPER-2347
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The commons tests hang under CI after bumping from zk 3.4.2 to 3.4.7.
> Although not root-caused, this zk bug introduced in 3.4.7 seems like a
> match for this sort of hang:
>   https://issues.apache.org/jira/browse/ZOOKEEPER-2347
> 
> Downgrade to 3.4.6 with a note about why 3.4.7 should be skipped.
> 
>  NEWS | 2 +-
>  build.gradle | 4 +++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> 
> Diffs
> -
> 
>   NEWS a4775adb18938ad80ee752e37d3f7c10549d3b70 
>   build.gradle 14ebf6b1d295e0780b7e390d00efadb25d30fc79 
> 
> Diff: https://reviews.apache.org/r/41917/diff/
> 
> 
> Testing
> ---
> 
> Locally green: `./build-support/jenkins/build.sh`.
> 
> That said - I could not reproduce the CI 120 minute timeouts as seen 
> here:
>   https://builds.apache.org/job/Aurora/1312/
>   https://builds.apache.org/job/Aurora/1313/
> 
> 
> Thanks,
> 
> John Sirois
> 
>



Re: Review Request 41917: Avoid zk 3.4.7 to fix test hangs.

2016-01-05 Thread Joshua Cohen


> On Jan. 5, 2016, 5 p.m., Joshua Cohen wrote:
> > Ship It!

We're seeing similar timeouts on our internal build as well.


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41917/#review112868
---


On Jan. 5, 2016, 7:37 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41917/
> ---
> 
> (Updated Jan. 5, 2016, 7:37 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko, Stephan Erb, and Bill Farner.
> 
> 
> Bugs: ZOOKEEPER-2347
> https://issues.apache.org/jira/browse/ZOOKEEPER-2347
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The commons tests hang under CI after bumping from zk 3.4.2 to 3.4.7.
> Although not root-caused, this zk bug introduced in 3.4.7 seems like a
> match for this sort of hang:
>   https://issues.apache.org/jira/browse/ZOOKEEPER-2347
> 
> Downgrade to 3.4.6 with a note about why 3.4.7 should be skipped.
> 
>  NEWS | 2 +-
>  build.gradle | 4 +++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> 
> Diffs
> -
> 
>   NEWS a4775adb18938ad80ee752e37d3f7c10549d3b70 
>   build.gradle 14ebf6b1d295e0780b7e390d00efadb25d30fc79 
> 
> Diff: https://reviews.apache.org/r/41917/diff/
> 
> 
> Testing
> ---
> 
> Locally green: `./build-support/jenkins/build.sh`.
> 
> That said - I could not reproduce the CI 120 minute timeouts as seen 
> here:
>   https://builds.apache.org/job/Aurora/1312/
>   https://builds.apache.org/job/Aurora/1313/
> 
> 
> Thanks,
> 
> John Sirois
> 
>



Re: Review Request 41917: Avoid zk 3.4.7 to fix test hangs.

2016-01-05 Thread Joshua Cohen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41917/#review112868
---

Ship it!


Ship It!

- Joshua Cohen


On Jan. 5, 2016, 7:37 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41917/
> ---
> 
> (Updated Jan. 5, 2016, 7:37 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko, Stephan Erb, and Bill Farner.
> 
> 
> Bugs: ZOOKEEPER-2347
> https://issues.apache.org/jira/browse/ZOOKEEPER-2347
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The commons tests hang under CI after bumping from zk 3.4.2 to 3.4.7.
> Although not root-caused, this zk bug introduced in 3.4.7 seems like a
> match for this sort of hang:
>   https://issues.apache.org/jira/browse/ZOOKEEPER-2347
> 
> Downgrade to 3.4.6 with a note about why 3.4.7 should be skipped.
> 
>  NEWS | 2 +-
>  build.gradle | 4 +++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> 
> Diffs
> -
> 
>   NEWS a4775adb18938ad80ee752e37d3f7c10549d3b70 
>   build.gradle 14ebf6b1d295e0780b7e390d00efadb25d30fc79 
> 
> Diff: https://reviews.apache.org/r/41917/diff/
> 
> 
> Testing
> ---
> 
> Locally green: `./build-support/jenkins/build.sh`.
> 
> That said - I could not reproduce the CI 120 minute timeouts as seen 
> here:
>   https://builds.apache.org/job/Aurora/1312/
>   https://builds.apache.org/job/Aurora/1313/
> 
> 
> Thanks,
> 
> John Sirois
> 
>



Re: Review Request 41917: Avoid zk 3.4.7 to fix test hangs.

2016-01-04 Thread John Sirois

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41917/
---

(Updated Jan. 5, 2016, 12:37 a.m.)


Review request for Aurora, Maxim Khutornenko, Stephan Erb, and Bill Farner.


Bugs: ZOOKEEPER-2347
https://issues.apache.org/jira/browse/ZOOKEEPER-2347


Repository: aurora


Description
---

The commons tests hang under CI after bumping from zk 3.4.2 to 3.4.7.
Although not root-caused, this zk bug introduced in 3.4.7 seems like a
match for this sort of hang:
  https://issues.apache.org/jira/browse/ZOOKEEPER-2347

Downgrade to 3.4.6 with a note about why 3.4.7 should be skipped.

 NEWS | 2 +-
 build.gradle | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)


Diffs
-

  NEWS a4775adb18938ad80ee752e37d3f7c10549d3b70 
  build.gradle 14ebf6b1d295e0780b7e390d00efadb25d30fc79 

Diff: https://reviews.apache.org/r/41917/diff/


Testing
---

Locally green: `./build-support/jenkins/build.sh`.

That said - I could not reproduce the CI 120 minute timeouts as seen 
here:
  https://builds.apache.org/job/Aurora/1312/
  https://builds.apache.org/job/Aurora/1313/


Thanks,

John Sirois



Re: Review Request 41917: Avoid zk 3.4.7 to fix test hangs.

2016-01-04 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41917/#review112776
---

Ship it!


Master (227a3a6) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 5, 2016, 6:06 a.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41917/
> ---
> 
> (Updated Jan. 5, 2016, 6:06 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko, Stephan Erb, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> The commons tests hang under CI after bumping from zk 3.4.2 to 3.4.7.
> Although not root-caused, this zk bug introduced in 3.4.7 seems like a
> match for this sort of hang:
>   https://issues.apache.org/jira/browse/ZOOKEEPER-2347
> 
> Downgrade to 3.4.6 with a note about why 3.4.7 should be skipped.
> 
>  NEWS | 2 +-
>  build.gradle | 4 +++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> 
> Diffs
> -
> 
>   NEWS a4775adb18938ad80ee752e37d3f7c10549d3b70 
>   build.gradle 14ebf6b1d295e0780b7e390d00efadb25d30fc79 
> 
> Diff: https://reviews.apache.org/r/41917/diff/
> 
> 
> Testing
> ---
> 
> Locally green: `./build-support/jenkins/build.sh`.
> 
> That said - I could not reproduce the CI 120 minute timeouts as seen 
> here:
>   https://builds.apache.org/job/Aurora/1312/
>   https://builds.apache.org/job/Aurora/1313/
> 
> 
> Thanks,
> 
> John Sirois
> 
>