Re: Review Request 42041: Enable H2 query statistics collection.

2016-01-09 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42041/#review113622 --- Ship it! Ship It! - John Sirois On Jan. 8, 2016, 2:52 p.m.,

Re: Review Request 42041: Enable H2 query statistics collection.

2016-01-09 Thread John Sirois
> On Jan. 7, 2016, 4:21 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 126 > > > > > > Are there any perf implications from having it ON by default?

Re: Review Request 42041: Enable H2 query statistics collection.

2016-01-08 Thread Zameer Manji
> On Jan. 7, 2016, 3:21 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 126 > > > > > > Are there any perf implications from having it ON by default?

Re: Review Request 42041: Enable H2 query statistics collection.

2016-01-08 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42041/ --- (Updated Jan. 8, 2016, 1:52 p.m.) Review request for Aurora, John Sirois and

Re: Review Request 42041: Enable H2 query statistics collection.

2016-01-08 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42041/#review113552 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 8, 2016, 9:52

Re: Review Request 42041: Enable H2 query statistics collection.

2016-01-07 Thread John Sirois
> On Jan. 7, 2016, 4:21 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 126 > > > > > > Are there any perf implications from having it ON by default?

Re: Review Request 42041: Enable H2 query statistics collection.

2016-01-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42041/#review113355 ---

Re: Review Request 42041: Enable H2 query statistics collection.

2016-01-07 Thread Zameer Manji
> On Jan. 7, 2016, 3:21 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 126 > > > > > > Are there any perf implications from having it ON by default?

Re: Review Request 42041: Enable H2 query statistics collection.

2016-01-07 Thread Zameer Manji
> On Jan. 7, 2016, 3:21 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 126 > > > > > > Are there any perf implications from having it ON by default?

Re: Review Request 42041: Enable H2 query statistics collection.

2016-01-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42041/#review113359 --- Master (206a48b) is green with this patch.

Re: Review Request 42041: Enable H2 query statistics collection.

2016-01-07 Thread John Sirois
> On Jan. 7, 2016, 4:21 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 126 > > > > > > Are there any perf implications from having it ON by default?