Re: Review Request 42117: Change release script to use rel/ tag prefix.

2016-01-10 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42117/#review113653
---

Ship it!


Master (6b768bd) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 10, 2016, 6:26 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42117/
> ---
> 
> (Updated Jan. 10, 2016, 6:26 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is in response to the e-mail below regarding git server-side policy 
> enforcement rendering `rel/` tags immutable.
> 
> ```
> Greeting PMCs:
> (bcc to p...@apache.org)
> 
> Following direction from the Board, Infrastructure has modified git to
> permit force pushes, and branch/tag deletion.
> 
> In accordance with the guidance that the Board we've implemented a few
> changes you should be aware of:
> 
> First, If a forced commit is pushed, the subsequent commit email will
> contain '[Forced Update!]' in the subject line. The hope here is that
> it draws extra attention to the situation for a project community to
> be aware, and take appropriate action if needed.
> 
> Second, we've changed the 'protected' portions of git to primarily
> focus on refs/tags/rel - thus any tags under rel, will have their
> entire commit history. This provides the provenance that the ASF needs
> for releases, while still giving projects the ability to mold their
> repository in the way they see fit.
> 
> Thus when a release vote is successful - part of the release process
> should become tagging the voted upon commit SHA under rel/ to make it
> indelible. ('# git tag rel/v15.4.2 ' or something similar.)
> 
> 
> If you have questions, please feel free to email infrastruct...@apache.org
> 
> 
> --David
> on behalf of Apache Infrastructure
> ```
> 
> 
> Diffs
> -
> 
>   build-support/release/release 9e8dd41209b8d687974d1cdc731c945afab3946e 
> 
> Diff: https://reviews.apache.org/r/42117/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>



Re: Review Request 42117: Change release script to use rel/ tag prefix.

2016-01-10 Thread Bill Farner


> On Jan. 10, 2016, 10:43 a.m., Zameer Manji wrote:
> > Will we also retroactively push `rel/` tags for previous releases?

Once this patch lands, yes - i will do this retroactively for old releases, 
update the website, etc.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42117/#review113651
---


On Jan. 10, 2016, 10:26 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42117/
> ---
> 
> (Updated Jan. 10, 2016, 10:26 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is in response to the e-mail below regarding git server-side policy 
> enforcement rendering `rel/` tags immutable.
> 
> ```
> Greeting PMCs:
> (bcc to p...@apache.org)
> 
> Following direction from the Board, Infrastructure has modified git to
> permit force pushes, and branch/tag deletion.
> 
> In accordance with the guidance that the Board we've implemented a few
> changes you should be aware of:
> 
> First, If a forced commit is pushed, the subsequent commit email will
> contain '[Forced Update!]' in the subject line. The hope here is that
> it draws extra attention to the situation for a project community to
> be aware, and take appropriate action if needed.
> 
> Second, we've changed the 'protected' portions of git to primarily
> focus on refs/tags/rel - thus any tags under rel, will have their
> entire commit history. This provides the provenance that the ASF needs
> for releases, while still giving projects the ability to mold their
> repository in the way they see fit.
> 
> Thus when a release vote is successful - part of the release process
> should become tagging the voted upon commit SHA under rel/ to make it
> indelible. ('# git tag rel/v15.4.2 ' or something similar.)
> 
> 
> If you have questions, please feel free to email infrastruct...@apache.org
> 
> 
> --David
> on behalf of Apache Infrastructure
> ```
> 
> 
> Diffs
> -
> 
>   build-support/release/release 9e8dd41209b8d687974d1cdc731c945afab3946e 
> 
> Diff: https://reviews.apache.org/r/42117/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>



Re: Review Request 42117: Change release script to use rel/ tag prefix.

2016-01-10 Thread John Sirois

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42117/#review113655
---



build-support/release/release (line 137)


IIUC, this commit will be pushed and reachable from the tag, but not from 
master.  Even if thats not right its not clear to me what branching above helps.



build-support/release/release (line 140)


No longer true.


- John Sirois


On Jan. 10, 2016, 11:26 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42117/
> ---
> 
> (Updated Jan. 10, 2016, 11:26 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is in response to the e-mail below regarding git server-side policy 
> enforcement rendering `rel/` tags immutable.
> 
> ```
> Greeting PMCs:
> (bcc to p...@apache.org)
> 
> Following direction from the Board, Infrastructure has modified git to
> permit force pushes, and branch/tag deletion.
> 
> In accordance with the guidance that the Board we've implemented a few
> changes you should be aware of:
> 
> First, If a forced commit is pushed, the subsequent commit email will
> contain '[Forced Update!]' in the subject line. The hope here is that
> it draws extra attention to the situation for a project community to
> be aware, and take appropriate action if needed.
> 
> Second, we've changed the 'protected' portions of git to primarily
> focus on refs/tags/rel - thus any tags under rel, will have their
> entire commit history. This provides the provenance that the ASF needs
> for releases, while still giving projects the ability to mold their
> repository in the way they see fit.
> 
> Thus when a release vote is successful - part of the release process
> should become tagging the voted upon commit SHA under rel/ to make it
> indelible. ('# git tag rel/v15.4.2 ' or something similar.)
> 
> 
> If you have questions, please feel free to email infrastruct...@apache.org
> 
> 
> --David
> on behalf of Apache Infrastructure
> ```
> 
> 
> Diffs
> -
> 
>   build-support/release/release 9e8dd41209b8d687974d1cdc731c945afab3946e 
> 
> Diff: https://reviews.apache.org/r/42117/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>



Re: Review Request 42117: Change release script to use rel/ tag prefix.

2016-01-10 Thread John Sirois

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42117/#review113660
---

Ship it!


Ship It!

- John Sirois


On Jan. 10, 2016, 11:26 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42117/
> ---
> 
> (Updated Jan. 10, 2016, 11:26 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is in response to the e-mail below regarding git server-side policy 
> enforcement rendering `rel/` tags immutable.
> 
> ```
> Greeting PMCs:
> (bcc to p...@apache.org)
> 
> Following direction from the Board, Infrastructure has modified git to
> permit force pushes, and branch/tag deletion.
> 
> In accordance with the guidance that the Board we've implemented a few
> changes you should be aware of:
> 
> First, If a forced commit is pushed, the subsequent commit email will
> contain '[Forced Update!]' in the subject line. The hope here is that
> it draws extra attention to the situation for a project community to
> be aware, and take appropriate action if needed.
> 
> Second, we've changed the 'protected' portions of git to primarily
> focus on refs/tags/rel - thus any tags under rel, will have their
> entire commit history. This provides the provenance that the ASF needs
> for releases, while still giving projects the ability to mold their
> repository in the way they see fit.
> 
> Thus when a release vote is successful - part of the release process
> should become tagging the voted upon commit SHA under rel/ to make it
> indelible. ('# git tag rel/v15.4.2 ' or something similar.)
> 
> 
> If you have questions, please feel free to email infrastruct...@apache.org
> 
> 
> --David
> on behalf of Apache Infrastructure
> ```
> 
> 
> Diffs
> -
> 
>   build-support/release/release 9e8dd41209b8d687974d1cdc731c945afab3946e 
> 
> Diff: https://reviews.apache.org/r/42117/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>



Re: Review Request 42117: Change release script to use rel/ tag prefix.

2016-01-10 Thread John Sirois


> On Jan. 10, 2016, 12:08 p.m., John Sirois wrote:
> > build-support/release/release, line 137
> > 
> >
> > IIUC, this commit will be pushed and reachable from the tag, but not 
> > from master.  Even if thats not right its not clear to me what branching 
> > above helps.
> 
> Bill Farner wrote:
> The contents of `.auroraversion` is not entirely straightforward.  On 
> master, it is always `.${NEXT_REL}-SNAPSHOT`, and only releases or release 
> candidate trees omit the `-SNAPSHOT`.
> 
> As for the branch, i was on the fence about creating a branch.  The 
> reason i went with one was to avoid leaving the user with a modified release 
> candidate branch that they might accidentally push.  Thinking more about 
> this, it probably also makes sense to apply this change to RC 
> generation/tagging as well.
> 
> So - does the above clear things up?  If so, what do you think about the 
> proposal above?

Makes sense and agreed it should be applied to RCs as well.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42117/#review113655
---


On Jan. 10, 2016, 11:26 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42117/
> ---
> 
> (Updated Jan. 10, 2016, 11:26 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is in response to the e-mail below regarding git server-side policy 
> enforcement rendering `rel/` tags immutable.
> 
> ```
> Greeting PMCs:
> (bcc to p...@apache.org)
> 
> Following direction from the Board, Infrastructure has modified git to
> permit force pushes, and branch/tag deletion.
> 
> In accordance with the guidance that the Board we've implemented a few
> changes you should be aware of:
> 
> First, If a forced commit is pushed, the subsequent commit email will
> contain '[Forced Update!]' in the subject line. The hope here is that
> it draws extra attention to the situation for a project community to
> be aware, and take appropriate action if needed.
> 
> Second, we've changed the 'protected' portions of git to primarily
> focus on refs/tags/rel - thus any tags under rel, will have their
> entire commit history. This provides the provenance that the ASF needs
> for releases, while still giving projects the ability to mold their
> repository in the way they see fit.
> 
> Thus when a release vote is successful - part of the release process
> should become tagging the voted upon commit SHA under rel/ to make it
> indelible. ('# git tag rel/v15.4.2 ' or something similar.)
> 
> 
> If you have questions, please feel free to email infrastruct...@apache.org
> 
> 
> --David
> on behalf of Apache Infrastructure
> ```
> 
> 
> Diffs
> -
> 
>   build-support/release/release 9e8dd41209b8d687974d1cdc731c945afab3946e 
> 
> Diff: https://reviews.apache.org/r/42117/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>



Re: Review Request 42117: Change release script to use rel/ tag prefix.

2016-01-10 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42117/#review113650
---



build-support/release/release (line 138)


Please note this subtle difference on our end.  We used to create a branch 
*and* tag for the release.  With this change, the script will no longer create 
a release branch.  I feel this is the right thing to do - i don't see an 
obvious benefit to having both a release tag and branch, and the mutability 
differences further motivate discontinuing the use of a release branch.


- Bill Farner


On Jan. 10, 2016, 10:26 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42117/
> ---
> 
> (Updated Jan. 10, 2016, 10:26 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is in response to the e-mail below regarding git server-side policy 
> enforcement rendering `rel/` tags immutable.
> 
> ```
> Greeting PMCs:
> (bcc to p...@apache.org)
> 
> Following direction from the Board, Infrastructure has modified git to
> permit force pushes, and branch/tag deletion.
> 
> In accordance with the guidance that the Board we've implemented a few
> changes you should be aware of:
> 
> First, If a forced commit is pushed, the subsequent commit email will
> contain '[Forced Update!]' in the subject line. The hope here is that
> it draws extra attention to the situation for a project community to
> be aware, and take appropriate action if needed.
> 
> Second, we've changed the 'protected' portions of git to primarily
> focus on refs/tags/rel - thus any tags under rel, will have their
> entire commit history. This provides the provenance that the ASF needs
> for releases, while still giving projects the ability to mold their
> repository in the way they see fit.
> 
> Thus when a release vote is successful - part of the release process
> should become tagging the voted upon commit SHA under rel/ to make it
> indelible. ('# git tag rel/v15.4.2 ' or something similar.)
> 
> 
> If you have questions, please feel free to email infrastruct...@apache.org
> 
> 
> --David
> on behalf of Apache Infrastructure
> ```
> 
> 
> Diffs
> -
> 
>   build-support/release/release 9e8dd41209b8d687974d1cdc731c945afab3946e 
> 
> Diff: https://reviews.apache.org/r/42117/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>



Re: Review Request 42117: Change release script to use rel/ tag prefix.

2016-01-10 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42117/#review113651
---

Ship it!


Will we also retroactively push `rel/` tags for previous releases?

- Zameer Manji


On Jan. 10, 2016, 10:26 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42117/
> ---
> 
> (Updated Jan. 10, 2016, 10:26 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is in response to the e-mail below regarding git server-side policy 
> enforcement rendering `rel/` tags immutable.
> 
> ```
> Greeting PMCs:
> (bcc to p...@apache.org)
> 
> Following direction from the Board, Infrastructure has modified git to
> permit force pushes, and branch/tag deletion.
> 
> In accordance with the guidance that the Board we've implemented a few
> changes you should be aware of:
> 
> First, If a forced commit is pushed, the subsequent commit email will
> contain '[Forced Update!]' in the subject line. The hope here is that
> it draws extra attention to the situation for a project community to
> be aware, and take appropriate action if needed.
> 
> Second, we've changed the 'protected' portions of git to primarily
> focus on refs/tags/rel - thus any tags under rel, will have their
> entire commit history. This provides the provenance that the ASF needs
> for releases, while still giving projects the ability to mold their
> repository in the way they see fit.
> 
> Thus when a release vote is successful - part of the release process
> should become tagging the voted upon commit SHA under rel/ to make it
> indelible. ('# git tag rel/v15.4.2 ' or something similar.)
> 
> 
> If you have questions, please feel free to email infrastruct...@apache.org
> 
> 
> --David
> on behalf of Apache Infrastructure
> ```
> 
> 
> Diffs
> -
> 
>   build-support/release/release 9e8dd41209b8d687974d1cdc731c945afab3946e 
> 
> Diff: https://reviews.apache.org/r/42117/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>



Re: Review Request 42117: Change release script to use rel/ tag prefix.

2016-01-10 Thread Bill Farner


> On Jan. 10, 2016, 11:08 a.m., John Sirois wrote:
> > build-support/release/release, line 137
> > 
> >
> > IIUC, this commit will be pushed and reachable from the tag, but not 
> > from master.  Even if thats not right its not clear to me what branching 
> > above helps.

The contents of `.auroraversion` is not entirely straightforward.  On master, 
it is always `.${NEXT_REL}-SNAPSHOT`, and only releases or release candidate 
trees omit the `-SNAPSHOT`.

As for the branch, i was on the fence about creating a branch.  The reason i 
went with one was to avoid leaving the user with a modified release candidate 
branch that they might accidentally push.  Thinking more about this, it 
probably also makes sense to apply this change to RC generation/tagging as well.

So - does the above clear things up?  If so, what do you think about the 
proposal above?


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42117/#review113655
---


On Jan. 10, 2016, 10:26 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42117/
> ---
> 
> (Updated Jan. 10, 2016, 10:26 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is in response to the e-mail below regarding git server-side policy 
> enforcement rendering `rel/` tags immutable.
> 
> ```
> Greeting PMCs:
> (bcc to p...@apache.org)
> 
> Following direction from the Board, Infrastructure has modified git to
> permit force pushes, and branch/tag deletion.
> 
> In accordance with the guidance that the Board we've implemented a few
> changes you should be aware of:
> 
> First, If a forced commit is pushed, the subsequent commit email will
> contain '[Forced Update!]' in the subject line. The hope here is that
> it draws extra attention to the situation for a project community to
> be aware, and take appropriate action if needed.
> 
> Second, we've changed the 'protected' portions of git to primarily
> focus on refs/tags/rel - thus any tags under rel, will have their
> entire commit history. This provides the provenance that the ASF needs
> for releases, while still giving projects the ability to mold their
> repository in the way they see fit.
> 
> Thus when a release vote is successful - part of the release process
> should become tagging the voted upon commit SHA under rel/ to make it
> indelible. ('# git tag rel/v15.4.2 ' or something similar.)
> 
> 
> If you have questions, please feel free to email infrastruct...@apache.org
> 
> 
> --David
> on behalf of Apache Infrastructure
> ```
> 
> 
> Diffs
> -
> 
>   build-support/release/release 9e8dd41209b8d687974d1cdc731c945afab3946e 
> 
> Diff: https://reviews.apache.org/r/42117/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>



Re: Review Request 42117: Change release script to use rel/ tag prefix.

2016-01-10 Thread Bill Farner


> On Jan. 10, 2016, 11:08 a.m., John Sirois wrote:
> > build-support/release/release, line 140
> > 
> >
> > No longer true.

Removed comment and `refs/tags` prefix.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42117/#review113655
---


On Jan. 10, 2016, 10:26 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42117/
> ---
> 
> (Updated Jan. 10, 2016, 10:26 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This is in response to the e-mail below regarding git server-side policy 
> enforcement rendering `rel/` tags immutable.
> 
> ```
> Greeting PMCs:
> (bcc to p...@apache.org)
> 
> Following direction from the Board, Infrastructure has modified git to
> permit force pushes, and branch/tag deletion.
> 
> In accordance with the guidance that the Board we've implemented a few
> changes you should be aware of:
> 
> First, If a forced commit is pushed, the subsequent commit email will
> contain '[Forced Update!]' in the subject line. The hope here is that
> it draws extra attention to the situation for a project community to
> be aware, and take appropriate action if needed.
> 
> Second, we've changed the 'protected' portions of git to primarily
> focus on refs/tags/rel - thus any tags under rel, will have their
> entire commit history. This provides the provenance that the ASF needs
> for releases, while still giving projects the ability to mold their
> repository in the way they see fit.
> 
> Thus when a release vote is successful - part of the release process
> should become tagging the voted upon commit SHA under rel/ to make it
> indelible. ('# git tag rel/v15.4.2 ' or something similar.)
> 
> 
> If you have questions, please feel free to email infrastruct...@apache.org
> 
> 
> --David
> on behalf of Apache Infrastructure
> ```
> 
> 
> Diffs
> -
> 
>   build-support/release/release 9e8dd41209b8d687974d1cdc731c945afab3946e 
> 
> Diff: https://reviews.apache.org/r/42117/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>



Re: Review Request 42117: Change release script to use rel/ tag prefix.

2016-01-10 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42117/
---

(Updated Jan. 10, 2016, 11:58 a.m.)


Review request for Aurora, John Sirois and Zameer Manji.


Repository: aurora


Description
---

This is in response to the e-mail below regarding git server-side policy 
enforcement rendering `rel/` tags immutable.

```
Greeting PMCs:
(bcc to p...@apache.org)

Following direction from the Board, Infrastructure has modified git to
permit force pushes, and branch/tag deletion.

In accordance with the guidance that the Board we've implemented a few
changes you should be aware of:

First, If a forced commit is pushed, the subsequent commit email will
contain '[Forced Update!]' in the subject line. The hope here is that
it draws extra attention to the situation for a project community to
be aware, and take appropriate action if needed.

Second, we've changed the 'protected' portions of git to primarily
focus on refs/tags/rel - thus any tags under rel, will have their
entire commit history. This provides the provenance that the ASF needs
for releases, while still giving projects the ability to mold their
repository in the way they see fit.

Thus when a release vote is successful - part of the release process
should become tagging the voted upon commit SHA under rel/ to make it
indelible. ('# git tag rel/v15.4.2 ' or something similar.)


If you have questions, please feel free to email infrastruct...@apache.org


--David
on behalf of Apache Infrastructure
```


Diffs (updated)
-

  build-support/release/release 9e8dd41209b8d687974d1cdc731c945afab3946e 

Diff: https://reviews.apache.org/r/42117/diff/


Testing
---


Thanks,

Bill Farner