Re: Review Request 42475: Fixup broken jmh benchmarks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42475/#review115203 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 18, 2016, 10:37 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42475/ > --- > > (Updated Jan. 18, 2016, 10:37 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Repository: aurora > > > Description > --- > > The `TierConfig` binding fix for the `SchedulingBenchmarks` in > https://reviews.apache.org/r/42073 was also needed for the > `StatusUpdateBenchmarks` and a binding for `ConfigurationManager` was > missing for the `ThriftApiBenchmarks` as-of > https://reviews.apache.org/r/41711/. > > While debugging these failures I noticed a new version of jmh had been > released recently, so also upgraded to that. No changes of import, but > the changelog can be read here: > http://hg.openjdk.java.net/code-tools/jmh/ > > build.gradle| 4 ++-- > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java | 8 > > src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java | 6 > ++ > 3 files changed, 12 insertions(+), 6 deletions(-) > > > Diffs > - > > build.gradle 169fb2535c6faddd0546d12d070cbaab1830c832 > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java > 3898596f6a657a6908d4f6fb9fde952186827aa7 > src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java > fd182aa60b90a26fc073cd5821c64b7129439741 > > Diff: https://reviews.apache.org/r/42475/diff/ > > > Testing > --- > > Both of these now work on master: > `./gradlew jmh -Pbenchmarks='StatusUpdateBenchmark.*'` > `./gradlew jmh -Pbenchmarks='ThriftApiBenchmark.*'` > > I also checked that a full run of `./gradlew jmh` was now green for > all benchmarks. > > > Thanks, > > John Sirois > >
Re: Review Request 42475: Fixup broken jmh benchmarks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42475/#review115071 --- Ship it! Master (b563679) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 18, 2016, 10:37 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42475/ > --- > > (Updated Jan. 18, 2016, 10:37 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Repository: aurora > > > Description > --- > > The `TierConfig` binding fix for the `SchedulingBenchmarks` in > https://reviews.apache.org/r/42073 was also needed for the > `StatusUpdateBenchmarks` and a binding for `ConfigurationManager` was > missing for the `ThriftApiBenchmarks` as-of > https://reviews.apache.org/r/41711/. > > While debugging these failures I noticed a new version of jmh had been > released recently, so also upgraded to that. No changes of import, but > the changelog can be read here: > http://hg.openjdk.java.net/code-tools/jmh/ > > build.gradle| 4 ++-- > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java | 8 > > src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java | 6 > ++ > 3 files changed, 12 insertions(+), 6 deletions(-) > > > Diffs > - > > build.gradle 169fb2535c6faddd0546d12d070cbaab1830c832 > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java > 3898596f6a657a6908d4f6fb9fde952186827aa7 > src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java > fd182aa60b90a26fc073cd5821c64b7129439741 > > Diff: https://reviews.apache.org/r/42475/diff/ > > > Testing > --- > > Both of these now work on master: > `./gradlew jmh -Pbenchmarks='StatusUpdateBenchmark.*'` > `./gradlew jmh -Pbenchmarks='ThriftApiBenchmark.*'` > > I also checked that a full run of `./gradlew jmh` was now green for > all benchmarks. > > > Thanks, > > John Sirois > >
Re: Review Request 42475: Fixup broken jmh benchmarks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42475/#review115066 --- Ship it! Ship It! - Bill Farner On Jan. 18, 2016, 2:37 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42475/ > --- > > (Updated Jan. 18, 2016, 2:37 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Repository: aurora > > > Description > --- > > The `TierConfig` binding fix for the `SchedulingBenchmarks` in > https://reviews.apache.org/r/42073 was also needed for the > `StatusUpdateBenchmarks` and a binding for `ConfigurationManager` was > missing for the `ThriftApiBenchmarks` as-of > https://reviews.apache.org/r/41711/. > > While debugging these failures I noticed a new version of jmh had been > released recently, so also upgraded to that. No changes of import, but > the changelog can be read here: > http://hg.openjdk.java.net/code-tools/jmh/ > > build.gradle| 4 ++-- > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java | 8 > > src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java | 6 > ++ > 3 files changed, 12 insertions(+), 6 deletions(-) > > > Diffs > - > > build.gradle 169fb2535c6faddd0546d12d070cbaab1830c832 > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java > 3898596f6a657a6908d4f6fb9fde952186827aa7 > src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java > fd182aa60b90a26fc073cd5821c64b7129439741 > > Diff: https://reviews.apache.org/r/42475/diff/ > > > Testing > --- > > Both of these now work on master: > `./gradlew jmh -Pbenchmarks='StatusUpdateBenchmark.*'` > `./gradlew jmh -Pbenchmarks='ThriftApiBenchmark.*'` > > I also checked that a full run of `./gradlew jmh` was now green for > all benchmarks. > > > Thanks, > > John Sirois > >
