Re: Review Request 42756: [3/3] Convert thrift codegen to use ThriftGen.
> On Jan. 25, 2016, 3:55 p.m., John Sirois wrote: > > NB: Please hold off on review pending an email to dev@ explaining this 3 RB > > proposal. Review away, accompanying proposal is now out for review: http://markmail.org/message/a6sdqcelgokw6mwz - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42756/#review116204 --- On Jan. 26, 2016, 11:37 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42756/ > --- > > (Updated Jan. 26, 2016, 11:37 a.m.) > > > Review request for Aurora. > > > Bugs: AURORA-1185 > https://issues.apache.org/jira/browse/AURORA-1185 > > > Repository: aurora > > > Description > --- > > This eliminates the `I*` entity wrappers in favor of 1st class immutable > thrift entities as well as eliminating both `AnnotatedAuroraAdmin` and > most hand-coded db view classes in favor of the new thrift codegen > support for passing through thrift annotations as java annotations. > > Most changes are mechanical conversion to the new immutable thrift > objects and generated `Mutable*` peers, although some new code is added > to handle both the swift codec stack and the thrift client and server > plumbing. > > 291 files changed, 7008 insertions(+), 6911 deletions(-) > > > Diffs > - > > > api/src/main/java/org/apache/aurora/scheduler/storage/db/views/DbAssignedTask.java > PRE-CREATION > api/src/main/java/org/apache/aurora/scheduler/storage/db/views/Pairs.java > PRE-CREATION > api/src/main/thrift/org/apache/aurora/gen/api.thrift > a93df2165c208c4963975aeb4f174df602baa476 > api/src/main/thrift/org/apache/aurora/gen/storage.thrift > 6dc46147bb0703e83a210a81ee24081183389a89 > > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy > 3acd7e938d4d1e657cf59abeddac80076705ba57 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > > buildSrc/src/main/java/org/apache/aurora/thrift/build/gradle/ThriftGenTask.java > PRE-CREATION > commons/src/main/java/org/apache/aurora/common/thrift/Util.java > 4ef7f49b7953b56b592b2f8ac3e04df738615211 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java > eca13511dc93f5ce5879976f2c7b0cc40be7d342 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java > 01a54a5718388df7f02992388653d7b049422787 > > commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java > 56cc32d95041b8c27932c0ee17bd36c83756cb3a > src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java > 94f8b799c15601758aed1c5458ad7af79bda6bbb > src/jmh/java/org/apache/aurora/benchmark/Hosts.java > d95e2dd3f736eefd586f707ba2559f8db7650857 > src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java > 493f75dbf6b9403e5fb5bb48306336880d54 > src/jmh/java/org/apache/aurora/benchmark/Offers.java > 055a2ffcb13c643a3086343e3fbf71545c5fb0a6 > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java > 45ab76b9331a79699979c6386c93bbc763f64e2e > src/jmh/java/org/apache/aurora/benchmark/SnapshotBenchmarks.java > ca484fab2a9b136c6d5b9be31e1ad1a5360f1b7a > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java > dc1ef82bce9e8e243974f8b97165f4417d870a7e > src/jmh/java/org/apache/aurora/benchmark/Tasks.java > 4c4b03d9cf7fbb2b11c90b522fb14c2b754a1bc6 > src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java > 293b88f462183cc85b02aaf875e887d21f4552c5 > src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java > 1d8986ba117f32288510c299ea5634f90a9311e7 > > src/jmh/java/org/apache/aurora/benchmark/fakes/FakeRescheduleCalculator.java > 4af2339a4ba6bcb5bf30e4739ebce7e20b387b16 > src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java > 6b65c0f6cb60b98ff352c4c5d5fed38d52b4b062 > src/main/java/org/apache/aurora/codec/ThriftServiceProcessor.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/HostOffer.java > 53fd68c6622d5cb06c0fc3efe002c11fbb9d08c5 > src/main/java/org/apache/aurora/scheduler/ResourceAggregates.java > a6335c53697a8bd51ba15d60216446c466b5d6a6 > src/main/java/org/apache/aurora/scheduler/ResourceSlot.java > 86f2667a323ca32756fd2dbc0e918bdf0362239d > src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java > 35675acfad8f98e833e0dba277ff65943a21db91 > src/main/java/org/apache/aurora/scheduler/TaskVars.java > 6351cc74c152d1f902078154ad14376c19c6ef1a > src/main/java/org/apache/aurora/scheduler/TierManager.java > 7367df4a030a3698518c9059aebcafc63c88e920 > src/main/java/org/apache/aurora/scheduler/app/AppModule.java >
Re: Review Request 42756: [3/3] Convert thrift codegen to use ThriftGen.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42756/ --- (Updated Jan. 26, 2016, 9:01 p.m.) Review request for Aurora. Bugs: AURORA-1185 https://issues.apache.org/jira/browse/AURORA-1185 Repository: aurora Description --- This eliminates the `I*` entity wrappers in favor of 1st class immutable thrift entities as well as eliminating both `AnnotatedAuroraAdmin` and most hand-coded db view classes in favor of the new thrift codegen support for passing through thrift annotations as java annotations. Most changes are mechanical conversion to the new immutable thrift objects and generated `Mutable*` peers, although some new code is added to handle both the swift codec stack and the thrift client and server plumbing. 291 files changed, 7008 insertions(+), 6911 deletions(-) Diffs - api/src/main/java/org/apache/aurora/scheduler/storage/db/views/DbAssignedTask.java PRE-CREATION api/src/main/java/org/apache/aurora/scheduler/storage/db/views/Pairs.java PRE-CREATION api/src/main/thrift/org/apache/aurora/gen/api.thrift a93df2165c208c4963975aeb4f174df602baa476 api/src/main/thrift/org/apache/aurora/gen/storage.thrift 6dc46147bb0703e83a210a81ee24081183389a89 buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy 3acd7e938d4d1e657cf59abeddac80076705ba57 buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy fc2bc9082dae2c63aa578c05dc89feb346260a67 buildSrc/src/main/java/org/apache/aurora/thrift/build/gradle/ThriftGenTask.java PRE-CREATION commons/src/main/java/org/apache/aurora/common/thrift/Util.java 4ef7f49b7953b56b592b2f8ac3e04df738615211 commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java eca13511dc93f5ce5879976f2c7b0cc40be7d342 commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java 01a54a5718388df7f02992388653d7b049422787 commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java 56cc32d95041b8c27932c0ee17bd36c83756cb3a src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java 94f8b799c15601758aed1c5458ad7af79bda6bbb src/jmh/java/org/apache/aurora/benchmark/Hosts.java d95e2dd3f736eefd586f707ba2559f8db7650857 src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java 493f75dbf6b9403e5fb5bb48306336880d54 src/jmh/java/org/apache/aurora/benchmark/Offers.java 055a2ffcb13c643a3086343e3fbf71545c5fb0a6 src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 45ab76b9331a79699979c6386c93bbc763f64e2e src/jmh/java/org/apache/aurora/benchmark/SnapshotBenchmarks.java ca484fab2a9b136c6d5b9be31e1ad1a5360f1b7a src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java dc1ef82bce9e8e243974f8b97165f4417d870a7e src/jmh/java/org/apache/aurora/benchmark/Tasks.java 4c4b03d9cf7fbb2b11c90b522fb14c2b754a1bc6 src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 293b88f462183cc85b02aaf875e887d21f4552c5 src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 1d8986ba117f32288510c299ea5634f90a9311e7 src/jmh/java/org/apache/aurora/benchmark/fakes/FakeRescheduleCalculator.java 4af2339a4ba6bcb5bf30e4739ebce7e20b387b16 src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 6b65c0f6cb60b98ff352c4c5d5fed38d52b4b062 src/main/java/org/apache/aurora/codec/ThriftServiceProcessor.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/HostOffer.java 53fd68c6622d5cb06c0fc3efe002c11fbb9d08c5 src/main/java/org/apache/aurora/scheduler/ResourceAggregates.java a6335c53697a8bd51ba15d60216446c466b5d6a6 src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 86f2667a323ca32756fd2dbc0e918bdf0362239d src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 35675acfad8f98e833e0dba277ff65943a21db91 src/main/java/org/apache/aurora/scheduler/TaskVars.java 6351cc74c152d1f902078154ad14376c19c6ef1a src/main/java/org/apache/aurora/scheduler/TierManager.java 7367df4a030a3698518c9059aebcafc63c88e920 src/main/java/org/apache/aurora/scheduler/app/AppModule.java a0d2a717534bbb2e85a556721cc53c1e4b743461 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java cd9cb09a889984d9cb9d63b890093a075647dcbf src/main/java/org/apache/aurora/scheduler/app/VolumeParser.java c1e99cee7a824b1440c9ef8c23c0d6834b6a1394 src/main/java/org/apache/aurora/scheduler/base/Conversions.java f2ff7abb51101c603df1bd1b21c4920a348743e1 src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 8f5bf58b963ae5f76aad7dfa34bae5b9e67d6242 src/main/java/org/apache/aurora/scheduler/base/Jobs.java 49e5b2cfc0b84bb0e0c95cca375cd0503f9dcdb5 src/main/java/org/apache/aurora/scheduler/base/Numbers.java
Re: Review Request 42756: [3/3] Convert thrift codegen to use ThriftGen.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42756/ --- (Updated Jan. 26, 2016, 11:37 a.m.) Review request for Aurora. Bugs: AURORA-1185 https://issues.apache.org/jira/browse/AURORA-1185 Repository: aurora Description --- This eliminates the `I*` entity wrappers in favor of 1st class immutable thrift entities as well as eliminating both `AnnotatedAuroraAdmin` and most hand-coded db view classes in favor of the new thrift codegen support for passing through thrift annotations as java annotations. Most changes are mechanical conversion to the new immutable thrift objects and generated `Mutable*` peers, although some new code is added to handle both the swift codec stack and the thrift client and server plumbing. 291 files changed, 7008 insertions(+), 6911 deletions(-) Diffs - api/src/main/java/org/apache/aurora/scheduler/storage/db/views/DbAssignedTask.java PRE-CREATION api/src/main/java/org/apache/aurora/scheduler/storage/db/views/Pairs.java PRE-CREATION api/src/main/thrift/org/apache/aurora/gen/api.thrift a93df2165c208c4963975aeb4f174df602baa476 api/src/main/thrift/org/apache/aurora/gen/storage.thrift 6dc46147bb0703e83a210a81ee24081183389a89 buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy 3acd7e938d4d1e657cf59abeddac80076705ba57 buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy fc2bc9082dae2c63aa578c05dc89feb346260a67 buildSrc/src/main/java/org/apache/aurora/thrift/build/gradle/ThriftGenTask.java PRE-CREATION commons/src/main/java/org/apache/aurora/common/thrift/Util.java 4ef7f49b7953b56b592b2f8ac3e04df738615211 commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java eca13511dc93f5ce5879976f2c7b0cc40be7d342 commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java 01a54a5718388df7f02992388653d7b049422787 commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java 56cc32d95041b8c27932c0ee17bd36c83756cb3a src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java 94f8b799c15601758aed1c5458ad7af79bda6bbb src/jmh/java/org/apache/aurora/benchmark/Hosts.java d95e2dd3f736eefd586f707ba2559f8db7650857 src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java 493f75dbf6b9403e5fb5bb48306336880d54 src/jmh/java/org/apache/aurora/benchmark/Offers.java 055a2ffcb13c643a3086343e3fbf71545c5fb0a6 src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 45ab76b9331a79699979c6386c93bbc763f64e2e src/jmh/java/org/apache/aurora/benchmark/SnapshotBenchmarks.java ca484fab2a9b136c6d5b9be31e1ad1a5360f1b7a src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java dc1ef82bce9e8e243974f8b97165f4417d870a7e src/jmh/java/org/apache/aurora/benchmark/Tasks.java 4c4b03d9cf7fbb2b11c90b522fb14c2b754a1bc6 src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 293b88f462183cc85b02aaf875e887d21f4552c5 src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 1d8986ba117f32288510c299ea5634f90a9311e7 src/jmh/java/org/apache/aurora/benchmark/fakes/FakeRescheduleCalculator.java 4af2339a4ba6bcb5bf30e4739ebce7e20b387b16 src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 6b65c0f6cb60b98ff352c4c5d5fed38d52b4b062 src/main/java/org/apache/aurora/codec/ThriftServiceProcessor.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/HostOffer.java 53fd68c6622d5cb06c0fc3efe002c11fbb9d08c5 src/main/java/org/apache/aurora/scheduler/ResourceAggregates.java a6335c53697a8bd51ba15d60216446c466b5d6a6 src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 86f2667a323ca32756fd2dbc0e918bdf0362239d src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 35675acfad8f98e833e0dba277ff65943a21db91 src/main/java/org/apache/aurora/scheduler/TaskVars.java 6351cc74c152d1f902078154ad14376c19c6ef1a src/main/java/org/apache/aurora/scheduler/TierManager.java 7367df4a030a3698518c9059aebcafc63c88e920 src/main/java/org/apache/aurora/scheduler/app/AppModule.java a0d2a717534bbb2e85a556721cc53c1e4b743461 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java cd9cb09a889984d9cb9d63b890093a075647dcbf src/main/java/org/apache/aurora/scheduler/app/VolumeParser.java c1e99cee7a824b1440c9ef8c23c0d6834b6a1394 src/main/java/org/apache/aurora/scheduler/base/Conversions.java f2ff7abb51101c603df1bd1b21c4920a348743e1 src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 8f5bf58b963ae5f76aad7dfa34bae5b9e67d6242 src/main/java/org/apache/aurora/scheduler/base/Jobs.java 49e5b2cfc0b84bb0e0c95cca375cd0503f9dcdb5 src/main/java/org/apache/aurora/scheduler/base/Numbers.java
Re: Review Request 42756: [3/3] Convert thrift codegen to use ThriftGen.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42756/#review116204 --- NB: Please hold off on review pending an email to dev@ explaining this 3 RB proposal. - John Sirois On Jan. 25, 2016, 3:52 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42756/ > --- > > (Updated Jan. 25, 2016, 3:52 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > --- > > This eliminates the `I*` entity wrappers in favor of 1st class immutable > thrift entities as well as eliminating both `AnnotatedAuroraAdmin` and > most hand-coded db view classes in favor of the new thrift codegen > support for passing through thrift annotations as java annotations. > > Most changes are mechanical conversion to the new immutable thrift > objects and generated `Mutable*` peers, although some new code is added > to handle both the swift codec stack and the thrift client and server > plumbing. > > 291 files changed, 7008 insertions(+), 6911 deletions(-) > > > Diffs > - > > > api/src/main/java/org/apache/aurora/scheduler/storage/db/views/DbAssignedTask.java > PRE-CREATION > api/src/main/java/org/apache/aurora/scheduler/storage/db/views/Pairs.java > PRE-CREATION > api/src/main/thrift/org/apache/aurora/gen/api.thrift > a93df2165c208c4963975aeb4f174df602baa476 > api/src/main/thrift/org/apache/aurora/gen/storage.thrift > 6dc46147bb0703e83a210a81ee24081183389a89 > > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy > 3acd7e938d4d1e657cf59abeddac80076705ba57 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > > buildSrc/src/main/java/org/apache/aurora/thrift/build/gradle/ThriftGenTask.java > PRE-CREATION > commons/src/main/java/org/apache/aurora/common/thrift/Util.java > 4ef7f49b7953b56b592b2f8ac3e04df738615211 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java > eca13511dc93f5ce5879976f2c7b0cc40be7d342 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java > 01a54a5718388df7f02992388653d7b049422787 > > commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java > 56cc32d95041b8c27932c0ee17bd36c83756cb3a > src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java > 94f8b799c15601758aed1c5458ad7af79bda6bbb > src/jmh/java/org/apache/aurora/benchmark/Hosts.java > d95e2dd3f736eefd586f707ba2559f8db7650857 > src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java > 493f75dbf6b9403e5fb5bb48306336880d54 > src/jmh/java/org/apache/aurora/benchmark/Offers.java > 055a2ffcb13c643a3086343e3fbf71545c5fb0a6 > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java > 45ab76b9331a79699979c6386c93bbc763f64e2e > src/jmh/java/org/apache/aurora/benchmark/SnapshotBenchmarks.java > ca484fab2a9b136c6d5b9be31e1ad1a5360f1b7a > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java > dc1ef82bce9e8e243974f8b97165f4417d870a7e > src/jmh/java/org/apache/aurora/benchmark/Tasks.java > 4c4b03d9cf7fbb2b11c90b522fb14c2b754a1bc6 > src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java > 293b88f462183cc85b02aaf875e887d21f4552c5 > src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java > 1d8986ba117f32288510c299ea5634f90a9311e7 > > src/jmh/java/org/apache/aurora/benchmark/fakes/FakeRescheduleCalculator.java > 4af2339a4ba6bcb5bf30e4739ebce7e20b387b16 > src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java > 6b65c0f6cb60b98ff352c4c5d5fed38d52b4b062 > src/main/java/org/apache/aurora/codec/ThriftServiceProcessor.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/HostOffer.java > 53fd68c6622d5cb06c0fc3efe002c11fbb9d08c5 > src/main/java/org/apache/aurora/scheduler/ResourceAggregates.java > a6335c53697a8bd51ba15d60216446c466b5d6a6 > src/main/java/org/apache/aurora/scheduler/ResourceSlot.java > 86f2667a323ca32756fd2dbc0e918bdf0362239d > src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java > 35675acfad8f98e833e0dba277ff65943a21db91 > src/main/java/org/apache/aurora/scheduler/TaskVars.java > 6351cc74c152d1f902078154ad14376c19c6ef1a > src/main/java/org/apache/aurora/scheduler/TierManager.java > 7367df4a030a3698518c9059aebcafc63c88e920 > src/main/java/org/apache/aurora/scheduler/app/AppModule.java > a0d2a717534bbb2e85a556721cc53c1e4b743461 > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > cd9cb09a889984d9cb9d63b890093a075647dcbf > src/main/java/org/apache/aurora/scheduler/app/VolumeParser.java >
Re: Review Request 42756: [3/3] Convert thrift codegen to use ThriftGen.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42756/#review116207 --- Master (39815a3) is red with this patch. ./build-support/jenkins/build.sh :buildSrc:compileGroovy :buildSrc:processResources UP-TO-DATE :buildSrc:classes :buildSrc:jar :buildSrc:assemble :buildSrc:compileTestJava UP-TO-DATE :buildSrc:compileTestGroovy UP-TO-DATE :buildSrc:processTestResources UP-TO-DATE :buildSrc:testClasses UP-TO-DATE :buildSrc:test UP-TO-DATE :buildSrc:check UP-TO-DATE :buildSrc:build :buildSrc:thriftGen:assemble :buildSrc:thriftGen:compileTestJava Download https://repo1.maven.org/maven2/com/google/jimfs/jimfs/1.0/jimfs-1.0.pom Download https://repo1.maven.org/maven2/com/google/jimfs/jimfs-parent/1.0/jimfs-parent-1.0.pom Download https://repo1.maven.org/maven2/com/google/jimfs/jimfs/1.0/jimfs-1.0.jar Note: /home/jenkins/jenkins-slave/workspace/AuroraBot/buildSrc/thriftGen/src/test/java/org/apache/aurora/thrift/build/ThriftGenTest.java uses unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. :buildSrc:thriftGen:processTestResources UP-TO-DATE :buildSrc:thriftGen:testClasses :buildSrc:thriftGen:test :buildSrc:thriftGen:check :buildSrc:thriftGen:build FAILURE: Build failed with an exception. * Where: Build file '/home/jenkins/jenkins-slave/workspace/AuroraBot/build.gradle' line: 183 * What went wrong: A problem occurred evaluating root project 'aurora'. > Could not find property 'org' on project ':api'. * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 33.548 secs I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 25, 2016, 10:52 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42756/ > --- > > (Updated Jan. 25, 2016, 10:52 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > --- > > This eliminates the `I*` entity wrappers in favor of 1st class immutable > thrift entities as well as eliminating both `AnnotatedAuroraAdmin` and > most hand-coded db view classes in favor of the new thrift codegen > support for passing through thrift annotations as java annotations. > > Most changes are mechanical conversion to the new immutable thrift > objects and generated `Mutable*` peers, although some new code is added > to handle both the swift codec stack and the thrift client and server > plumbing. > > 291 files changed, 7008 insertions(+), 6911 deletions(-) > > > Diffs > - > > > api/src/main/java/org/apache/aurora/scheduler/storage/db/views/DbAssignedTask.java > PRE-CREATION > api/src/main/java/org/apache/aurora/scheduler/storage/db/views/Pairs.java > PRE-CREATION > api/src/main/thrift/org/apache/aurora/gen/api.thrift > a93df2165c208c4963975aeb4f174df602baa476 > api/src/main/thrift/org/apache/aurora/gen/storage.thrift > 6dc46147bb0703e83a210a81ee24081183389a89 > > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy > 3acd7e938d4d1e657cf59abeddac80076705ba57 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > > buildSrc/src/main/java/org/apache/aurora/thrift/build/gradle/ThriftGenTask.java > PRE-CREATION > commons/src/main/java/org/apache/aurora/common/thrift/Util.java > 4ef7f49b7953b56b592b2f8ac3e04df738615211 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java > eca13511dc93f5ce5879976f2c7b0cc40be7d342 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java > 01a54a5718388df7f02992388653d7b049422787 > > commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java > 56cc32d95041b8c27932c0ee17bd36c83756cb3a > src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java > 94f8b799c15601758aed1c5458ad7af79bda6bbb > src/jmh/java/org/apache/aurora/benchmark/Hosts.java > d95e2dd3f736eefd586f707ba2559f8db7650857 > src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java > 493f75dbf6b9403e5fb5bb48306336880d54 > src/jmh/java/org/apache/aurora/benchmark/Offers.java > 055a2ffcb13c643a3086343e3fbf71545c5fb0a6 > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java > 45ab76b9331a79699979c6386c93bbc763f64e2e > src/jmh/java/org/apache/aurora/benchmark/SnapshotBenchmarks.java > ca484fab2a9b136c6d5b9be31e1ad1a5360f1b7a > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java > dc1ef82bce9e8e243974f8b97165f4417d870a7e > src/jmh/java/org/apache/aurora/benchmark/Tasks.java >
Re: Review Request 42756: [3/3] Convert thrift codegen to use ThriftGen.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42756/ --- (Updated Jan. 25, 2016, 4:22 p.m.) Review request for Aurora. Changes --- Remove unused thrift_wrapper_codegen.py src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py | 712 -- 1 file changed, 712 deletions(-) Repository: aurora Description --- This eliminates the `I*` entity wrappers in favor of 1st class immutable thrift entities as well as eliminating both `AnnotatedAuroraAdmin` and most hand-coded db view classes in favor of the new thrift codegen support for passing through thrift annotations as java annotations. Most changes are mechanical conversion to the new immutable thrift objects and generated `Mutable*` peers, although some new code is added to handle both the swift codec stack and the thrift client and server plumbing. 291 files changed, 7008 insertions(+), 6911 deletions(-) Diffs (updated) - api/src/main/java/org/apache/aurora/scheduler/storage/db/views/DbAssignedTask.java PRE-CREATION api/src/main/java/org/apache/aurora/scheduler/storage/db/views/Pairs.java PRE-CREATION api/src/main/thrift/org/apache/aurora/gen/api.thrift a93df2165c208c4963975aeb4f174df602baa476 api/src/main/thrift/org/apache/aurora/gen/storage.thrift 6dc46147bb0703e83a210a81ee24081183389a89 buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy 3acd7e938d4d1e657cf59abeddac80076705ba57 buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy fc2bc9082dae2c63aa578c05dc89feb346260a67 buildSrc/src/main/java/org/apache/aurora/thrift/build/gradle/ThriftGenTask.java PRE-CREATION commons/src/main/java/org/apache/aurora/common/thrift/Util.java 4ef7f49b7953b56b592b2f8ac3e04df738615211 commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java eca13511dc93f5ce5879976f2c7b0cc40be7d342 commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java 01a54a5718388df7f02992388653d7b049422787 commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java 56cc32d95041b8c27932c0ee17bd36c83756cb3a src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java 94f8b799c15601758aed1c5458ad7af79bda6bbb src/jmh/java/org/apache/aurora/benchmark/Hosts.java d95e2dd3f736eefd586f707ba2559f8db7650857 src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java 493f75dbf6b9403e5fb5bb48306336880d54 src/jmh/java/org/apache/aurora/benchmark/Offers.java 055a2ffcb13c643a3086343e3fbf71545c5fb0a6 src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 45ab76b9331a79699979c6386c93bbc763f64e2e src/jmh/java/org/apache/aurora/benchmark/SnapshotBenchmarks.java ca484fab2a9b136c6d5b9be31e1ad1a5360f1b7a src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java dc1ef82bce9e8e243974f8b97165f4417d870a7e src/jmh/java/org/apache/aurora/benchmark/Tasks.java 4c4b03d9cf7fbb2b11c90b522fb14c2b754a1bc6 src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 293b88f462183cc85b02aaf875e887d21f4552c5 src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 1d8986ba117f32288510c299ea5634f90a9311e7 src/jmh/java/org/apache/aurora/benchmark/fakes/FakeRescheduleCalculator.java 4af2339a4ba6bcb5bf30e4739ebce7e20b387b16 src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 6b65c0f6cb60b98ff352c4c5d5fed38d52b4b062 src/main/java/org/apache/aurora/codec/ThriftServiceProcessor.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/HostOffer.java 53fd68c6622d5cb06c0fc3efe002c11fbb9d08c5 src/main/java/org/apache/aurora/scheduler/ResourceAggregates.java a6335c53697a8bd51ba15d60216446c466b5d6a6 src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 86f2667a323ca32756fd2dbc0e918bdf0362239d src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 35675acfad8f98e833e0dba277ff65943a21db91 src/main/java/org/apache/aurora/scheduler/TaskVars.java 6351cc74c152d1f902078154ad14376c19c6ef1a src/main/java/org/apache/aurora/scheduler/TierManager.java 7367df4a030a3698518c9059aebcafc63c88e920 src/main/java/org/apache/aurora/scheduler/app/AppModule.java a0d2a717534bbb2e85a556721cc53c1e4b743461 src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java cd9cb09a889984d9cb9d63b890093a075647dcbf src/main/java/org/apache/aurora/scheduler/app/VolumeParser.java c1e99cee7a824b1440c9ef8c23c0d6834b6a1394 src/main/java/org/apache/aurora/scheduler/base/Conversions.java f2ff7abb51101c603df1bd1b21c4920a348743e1 src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 8f5bf58b963ae5f76aad7dfa34bae5b9e67d6242
Re: Review Request 42756: [3/3] Convert thrift codegen to use ThriftGen.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42756/#review116219 --- Master (39815a3) is red with this patch. ./build-support/jenkins/build.sh :buildSrc:thriftGen:classes :buildSrc:thriftGen:jar :buildSrc:compileJava :buildSrc:compileGroovy :buildSrc:processResources UP-TO-DATE :buildSrc:classes :buildSrc:jar :buildSrc:assemble :buildSrc:compileTestJava UP-TO-DATE :buildSrc:compileTestGroovy UP-TO-DATE :buildSrc:processTestResources UP-TO-DATE :buildSrc:testClasses UP-TO-DATE :buildSrc:test UP-TO-DATE :buildSrc:check UP-TO-DATE :buildSrc:build :buildSrc:thriftGen:assemble :buildSrc:thriftGen:compileTestJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/buildSrc/thriftGen/src/test/java/org/apache/aurora/thrift/build/ThriftGenTest.java uses unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. :buildSrc:thriftGen:processTestResources UP-TO-DATE :buildSrc:thriftGen:testClasses :buildSrc:thriftGen:test :buildSrc:thriftGen:check :buildSrc:thriftGen:build FAILURE: Build failed with an exception. * Where: Build file '/home/jenkins/jenkins-slave/workspace/AuroraBot/build.gradle' line: 183 * What went wrong: A problem occurred evaluating root project 'aurora'. > Could not find property 'org' on project ':api'. * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED Total time: 20.462 secs I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 25, 2016, 11:22 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42756/ > --- > > (Updated Jan. 25, 2016, 11:22 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > --- > > This eliminates the `I*` entity wrappers in favor of 1st class immutable > thrift entities as well as eliminating both `AnnotatedAuroraAdmin` and > most hand-coded db view classes in favor of the new thrift codegen > support for passing through thrift annotations as java annotations. > > Most changes are mechanical conversion to the new immutable thrift > objects and generated `Mutable*` peers, although some new code is added > to handle both the swift codec stack and the thrift client and server > plumbing. > > 291 files changed, 7008 insertions(+), 6911 deletions(-) > > > Diffs > - > > > api/src/main/java/org/apache/aurora/scheduler/storage/db/views/DbAssignedTask.java > PRE-CREATION > api/src/main/java/org/apache/aurora/scheduler/storage/db/views/Pairs.java > PRE-CREATION > api/src/main/thrift/org/apache/aurora/gen/api.thrift > a93df2165c208c4963975aeb4f174df602baa476 > api/src/main/thrift/org/apache/aurora/gen/storage.thrift > 6dc46147bb0703e83a210a81ee24081183389a89 > > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy > 3acd7e938d4d1e657cf59abeddac80076705ba57 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > > buildSrc/src/main/java/org/apache/aurora/thrift/build/gradle/ThriftGenTask.java > PRE-CREATION > commons/src/main/java/org/apache/aurora/common/thrift/Util.java > 4ef7f49b7953b56b592b2f8ac3e04df738615211 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java > eca13511dc93f5ce5879976f2c7b0cc40be7d342 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java > 01a54a5718388df7f02992388653d7b049422787 > > commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java > 56cc32d95041b8c27932c0ee17bd36c83756cb3a > src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java > 94f8b799c15601758aed1c5458ad7af79bda6bbb > src/jmh/java/org/apache/aurora/benchmark/Hosts.java > d95e2dd3f736eefd586f707ba2559f8db7650857 > src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java > 493f75dbf6b9403e5fb5bb48306336880d54 > src/jmh/java/org/apache/aurora/benchmark/Offers.java > 055a2ffcb13c643a3086343e3fbf71545c5fb0a6 > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java > 45ab76b9331a79699979c6386c93bbc763f64e2e > src/jmh/java/org/apache/aurora/benchmark/SnapshotBenchmarks.java > ca484fab2a9b136c6d5b9be31e1ad1a5360f1b7a > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java > dc1ef82bce9e8e243974f8b97165f4417d870a7e > src/jmh/java/org/apache/aurora/benchmark/Tasks.java > 4c4b03d9cf7fbb2b11c90b522fb14c2b754a1bc6 > src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java > 293b88f462183cc85b02aaf875e887d21f4552c5 >
Re: Review Request 42756: [3/3] Convert thrift codegen to use ThriftGen.
> On Jan. 25, 2016, 3:55 p.m., Aurora ReviewBot wrote: > > Master (39815a3) is red with this patch. > > ./build-support/jenkins/build.sh > > > > :buildSrc:compileGroovy > > :buildSrc:processResources UP-TO-DATE > > :buildSrc:classes > > :buildSrc:jar > > :buildSrc:assemble > > :buildSrc:compileTestJava UP-TO-DATE > > :buildSrc:compileTestGroovy UP-TO-DATE > > :buildSrc:processTestResources UP-TO-DATE > > :buildSrc:testClasses UP-TO-DATE > > :buildSrc:test UP-TO-DATE > > :buildSrc:check UP-TO-DATE > > :buildSrc:build > > :buildSrc:thriftGen:assemble > > :buildSrc:thriftGen:compileTestJava > > Download > > https://repo1.maven.org/maven2/com/google/jimfs/jimfs/1.0/jimfs-1.0.pom > > Download > > https://repo1.maven.org/maven2/com/google/jimfs/jimfs-parent/1.0/jimfs-parent-1.0.pom > > Download > > https://repo1.maven.org/maven2/com/google/jimfs/jimfs/1.0/jimfs-1.0.jar > > Note: > > /home/jenkins/jenkins-slave/workspace/AuroraBot/buildSrc/thriftGen/src/test/java/org/apache/aurora/thrift/build/ThriftGenTest.java > > uses unchecked or unsafe operations. > > Note: Recompile with -Xlint:unchecked for details. > > :buildSrc:thriftGen:processTestResources UP-TO-DATE > > :buildSrc:thriftGen:testClasses > > :buildSrc:thriftGen:test > > :buildSrc:thriftGen:check > > :buildSrc:thriftGen:build > > > > FAILURE: Build failed with an exception. > > > > * Where: > > Build file '/home/jenkins/jenkins-slave/workspace/AuroraBot/build.gradle' > > line: 183 > > > > * What went wrong: > > A problem occurred evaluating root project 'aurora'. > > > Could not find property 'org' on project ':api'. > > > > * Try: > > Run with --stacktrace option to get the stack trace. Run with --info or > > --debug option to get more log output. > > > > BUILD FAILED > > > > Total time: 33.548 secs > > > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" Unfortunately, this is expected. I had to hand-craft the diff to exclude .gitignore, build.gradle and settings.gradle. A real AuroraBot run will only happen if/when https://reviews.apache.org/r/42749/ and this patch series in-general is deemed a go at which point this RB can be rebased off 2/3 landing on master. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42756/#review116207 --- On Jan. 25, 2016, 3:52 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42756/ > --- > > (Updated Jan. 25, 2016, 3:52 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > --- > > This eliminates the `I*` entity wrappers in favor of 1st class immutable > thrift entities as well as eliminating both `AnnotatedAuroraAdmin` and > most hand-coded db view classes in favor of the new thrift codegen > support for passing through thrift annotations as java annotations. > > Most changes are mechanical conversion to the new immutable thrift > objects and generated `Mutable*` peers, although some new code is added > to handle both the swift codec stack and the thrift client and server > plumbing. > > 291 files changed, 7008 insertions(+), 6911 deletions(-) > > > Diffs > - > > > api/src/main/java/org/apache/aurora/scheduler/storage/db/views/DbAssignedTask.java > PRE-CREATION > api/src/main/java/org/apache/aurora/scheduler/storage/db/views/Pairs.java > PRE-CREATION > api/src/main/thrift/org/apache/aurora/gen/api.thrift > a93df2165c208c4963975aeb4f174df602baa476 > api/src/main/thrift/org/apache/aurora/gen/storage.thrift > 6dc46147bb0703e83a210a81ee24081183389a89 > > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy > 3acd7e938d4d1e657cf59abeddac80076705ba57 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > > buildSrc/src/main/java/org/apache/aurora/thrift/build/gradle/ThriftGenTask.java > PRE-CREATION > commons/src/main/java/org/apache/aurora/common/thrift/Util.java > 4ef7f49b7953b56b592b2f8ac3e04df738615211 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java > eca13511dc93f5ce5879976f2c7b0cc40be7d342 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java > 01a54a5718388df7f02992388653d7b049422787 > > commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java > 56cc32d95041b8c27932c0ee17bd36c83756cb3a > src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java > 94f8b799c15601758aed1c5458ad7af79bda6bbb > src/jmh/java/org/apache/aurora/benchmark/Hosts.java > d95e2dd3f736eefd586f707ba2559f8db7650857 >
