Re: Review Request 42804: Remove job update `maxWaitToInstanceRunningMs` field.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42804/#review116376 --- Ship it! Master (39815a3) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 26, 2016, 4:49 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42804/ > --- > > (Updated Jan. 26, 2016, 4:49 p.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-1254 > https://issues.apache.org/jira/browse/AURORA-1254 > > > Repository: aurora > > > Description > --- > > This field in the thrift api `JobUpdateSettings` struct and its sibling > in `UpdateConfig.restart_threshold` on the client side were deprecated > in Aurora 0.11.0. > > NEWS > | 3 +++ > api/src/main/thrift/org/apache/aurora/gen/api.thrift > | 6 -- > docs/configuration-reference.md > | 1 - > src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java > | 1 - > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java >| 6 -- > src/main/python/apache/aurora/client/api/updater_util.py > | 3 --- > src/main/python/apache/aurora/config/schema/base.py > | 1 - > > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml > | 4 > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql > | 1 - > > src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java >| 1 - > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java >| 1 - > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java > | 9 ++--- > src/test/java/org/apache/aurora/scheduler/updater/UpdateFactoryImplTest.java > | 1 - > src/test/python/apache/aurora/client/api/test_api.py > | 1 - > src/test/python/apache/aurora/client/api/test_updater_util.py > | 6 +++--- > src/test/python/apache/aurora/client/cli/test_config_noun.py > | 1 - > src/test/python/apache/aurora/client/cli/util.py > | 2 -- > 17 files changed, 8 insertions(+), 40 deletions(-) > > > Diffs > - > > NEWS f2798f6a2d6841606e99a93677067e58dc5cf5cc > api/src/main/thrift/org/apache/aurora/gen/api.thrift > a93df2165c208c4963975aeb4f174df602baa476 > docs/configuration-reference.md e0eb908ea7f1b888a87d0179c91f14b3577ea3bd > src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java > 493f75dbf6b9403e5fb5bb48306336880d54 > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 662cae179142b34896b11275bd3b425903f22e3e > src/main/python/apache/aurora/client/api/updater_util.py > a3389f3dcea62683f459c2e5f8def2538b8cc336 > src/main/python/apache/aurora/config/schema/base.py > 7bc903c4434afb15d7005e1ac6bdea208e352a49 > > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml > 69e11b69c4d8e0e2cba4c30ecc56077b2a3245ad > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql > 803960fb551aa324a4737d45593d6eb420817525 > > src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java > d035513435b9b07027747bb13b7810061f489474 > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > b9ce2ddba051ab2baed59108d70537d84a031934 > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java > 2024b2c50d5d1e44f3f95b915c8bcd58e39379cb > > src/test/java/org/apache/aurora/scheduler/updater/UpdateFactoryImplTest.java > c31e082ef3dd3a40d9cb7926aa277e86399a06bd > src/test/python/apache/aurora/client/api/test_api.py > 59f34a58ce083d9e2bdf125a8baaf511ca6d3901 > src/test/python/apache/aurora/client/api/test_updater_util.py > 11b95c6730313e5d520486063e7979514cee34e1 > src/test/python/apache/aurora/client/cli/test_config_noun.py > d82a69d008d7aa291058a4a244308fdb13c1b6a5 > src/test/python/apache/aurora/client/cli/util.py > c7aa5cc5a5ea1da01fa75d4d22ff1256e27521b7 > > Diff: https://reviews.apache.org/r/42804/diff/ > > > Testing > --- > > Locally green: > ``` > ./build-support/jenkins/build.sh > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 42804: Remove job update `maxWaitToInstanceRunningMs` field.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42804/#review116386 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 26, 2016, 4:49 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42804/ > --- > > (Updated Jan. 26, 2016, 4:49 p.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-1254 > https://issues.apache.org/jira/browse/AURORA-1254 > > > Repository: aurora > > > Description > --- > > This field in the thrift api `JobUpdateSettings` struct and its sibling > in `UpdateConfig.restart_threshold` on the client side were deprecated > in Aurora 0.11.0. > > NEWS > | 3 +++ > api/src/main/thrift/org/apache/aurora/gen/api.thrift > | 6 -- > docs/configuration-reference.md > | 1 - > src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java > | 1 - > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java >| 6 -- > src/main/python/apache/aurora/client/api/updater_util.py > | 3 --- > src/main/python/apache/aurora/config/schema/base.py > | 1 - > > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml > | 4 > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql > | 1 - > > src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java >| 1 - > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java >| 1 - > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java > | 9 ++--- > src/test/java/org/apache/aurora/scheduler/updater/UpdateFactoryImplTest.java > | 1 - > src/test/python/apache/aurora/client/api/test_api.py > | 1 - > src/test/python/apache/aurora/client/api/test_updater_util.py > | 6 +++--- > src/test/python/apache/aurora/client/cli/test_config_noun.py > | 1 - > src/test/python/apache/aurora/client/cli/util.py > | 2 -- > 17 files changed, 8 insertions(+), 40 deletions(-) > > > Diffs > - > > NEWS f2798f6a2d6841606e99a93677067e58dc5cf5cc > api/src/main/thrift/org/apache/aurora/gen/api.thrift > a93df2165c208c4963975aeb4f174df602baa476 > docs/configuration-reference.md e0eb908ea7f1b888a87d0179c91f14b3577ea3bd > src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java > 493f75dbf6b9403e5fb5bb48306336880d54 > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 662cae179142b34896b11275bd3b425903f22e3e > src/main/python/apache/aurora/client/api/updater_util.py > a3389f3dcea62683f459c2e5f8def2538b8cc336 > src/main/python/apache/aurora/config/schema/base.py > 7bc903c4434afb15d7005e1ac6bdea208e352a49 > > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml > 69e11b69c4d8e0e2cba4c30ecc56077b2a3245ad > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql > 803960fb551aa324a4737d45593d6eb420817525 > > src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java > d035513435b9b07027747bb13b7810061f489474 > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > b9ce2ddba051ab2baed59108d70537d84a031934 > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java > 2024b2c50d5d1e44f3f95b915c8bcd58e39379cb > > src/test/java/org/apache/aurora/scheduler/updater/UpdateFactoryImplTest.java > c31e082ef3dd3a40d9cb7926aa277e86399a06bd > src/test/python/apache/aurora/client/api/test_api.py > 59f34a58ce083d9e2bdf125a8baaf511ca6d3901 > src/test/python/apache/aurora/client/api/test_updater_util.py > 11b95c6730313e5d520486063e7979514cee34e1 > src/test/python/apache/aurora/client/cli/test_config_noun.py > d82a69d008d7aa291058a4a244308fdb13c1b6a5 > src/test/python/apache/aurora/client/cli/util.py > c7aa5cc5a5ea1da01fa75d4d22ff1256e27521b7 > > Diff: https://reviews.apache.org/r/42804/diff/ > > > Testing > --- > > Locally green: > ``` > ./build-support/jenkins/build.sh > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 42804: Remove job update `maxWaitToInstanceRunningMs` field.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42804/#review116391 --- Ship it! Ship It! - Joshua Cohen On Jan. 26, 2016, 4:49 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42804/ > --- > > (Updated Jan. 26, 2016, 4:49 p.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-1254 > https://issues.apache.org/jira/browse/AURORA-1254 > > > Repository: aurora > > > Description > --- > > This field in the thrift api `JobUpdateSettings` struct and its sibling > in `UpdateConfig.restart_threshold` on the client side were deprecated > in Aurora 0.11.0. > > NEWS > | 3 +++ > api/src/main/thrift/org/apache/aurora/gen/api.thrift > | 6 -- > docs/configuration-reference.md > | 1 - > src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java > | 1 - > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java >| 6 -- > src/main/python/apache/aurora/client/api/updater_util.py > | 3 --- > src/main/python/apache/aurora/config/schema/base.py > | 1 - > > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml > | 4 > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql > | 1 - > > src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java >| 1 - > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java >| 1 - > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java > | 9 ++--- > src/test/java/org/apache/aurora/scheduler/updater/UpdateFactoryImplTest.java > | 1 - > src/test/python/apache/aurora/client/api/test_api.py > | 1 - > src/test/python/apache/aurora/client/api/test_updater_util.py > | 6 +++--- > src/test/python/apache/aurora/client/cli/test_config_noun.py > | 1 - > src/test/python/apache/aurora/client/cli/util.py > | 2 -- > 17 files changed, 8 insertions(+), 40 deletions(-) > > > Diffs > - > > NEWS f2798f6a2d6841606e99a93677067e58dc5cf5cc > api/src/main/thrift/org/apache/aurora/gen/api.thrift > a93df2165c208c4963975aeb4f174df602baa476 > docs/configuration-reference.md e0eb908ea7f1b888a87d0179c91f14b3577ea3bd > src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java > 493f75dbf6b9403e5fb5bb48306336880d54 > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 662cae179142b34896b11275bd3b425903f22e3e > src/main/python/apache/aurora/client/api/updater_util.py > a3389f3dcea62683f459c2e5f8def2538b8cc336 > src/main/python/apache/aurora/config/schema/base.py > 7bc903c4434afb15d7005e1ac6bdea208e352a49 > > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml > 69e11b69c4d8e0e2cba4c30ecc56077b2a3245ad > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql > 803960fb551aa324a4737d45593d6eb420817525 > > src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java > d035513435b9b07027747bb13b7810061f489474 > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > b9ce2ddba051ab2baed59108d70537d84a031934 > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java > 2024b2c50d5d1e44f3f95b915c8bcd58e39379cb > > src/test/java/org/apache/aurora/scheduler/updater/UpdateFactoryImplTest.java > c31e082ef3dd3a40d9cb7926aa277e86399a06bd > src/test/python/apache/aurora/client/api/test_api.py > 59f34a58ce083d9e2bdf125a8baaf511ca6d3901 > src/test/python/apache/aurora/client/api/test_updater_util.py > 11b95c6730313e5d520486063e7979514cee34e1 > src/test/python/apache/aurora/client/cli/test_config_noun.py > d82a69d008d7aa291058a4a244308fdb13c1b6a5 > src/test/python/apache/aurora/client/cli/util.py > c7aa5cc5a5ea1da01fa75d4d22ff1256e27521b7 > > Diff: https://reviews.apache.org/r/42804/diff/ > > > Testing > --- > > Locally green: > ``` > ./build-support/jenkins/build.sh > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
