Re: Review Request 42964: Add flag to optionally disable the leader redirect filter.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/#review116973 --- Exploring ideas - would an HTTP header be more handy for this? - Bill Farner On Jan. 29, 2016, 9:53 a.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42964/ > --- > > (Updated Jan. 29, 2016, 9:53 a.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-1601 > https://issues.apache.org/jira/browse/AURORA-1601 > > > Repository: aurora > > > Description > --- > > Add flag to optionally disable the leader redirect filter. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > df649ff4ffdc741afdbc4850c2dbf98bd3e218f1 > src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java > 19c8a1fe06a24022da11f74d7c96b2942587 > > Diff: https://reviews.apache.org/r/42964/diff/ > > > Testing > --- > > ./gradlew build -Pq > > > Thanks, > > Joshua Cohen > >
Re: Review Request 42964: Add flag to optionally disable the leader redirect filter.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/#review116974 --- Ship it! Master (0eb753d) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 29, 2016, 5:53 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42964/ > --- > > (Updated Jan. 29, 2016, 5:53 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-1601 > https://issues.apache.org/jira/browse/AURORA-1601 > > > Repository: aurora > > > Description > --- > > Add flag to optionally disable the leader redirect filter. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > df649ff4ffdc741afdbc4850c2dbf98bd3e218f1 > src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java > 19c8a1fe06a24022da11f74d7c96b2942587 > > Diff: https://reviews.apache.org/r/42964/diff/ > > > Testing > --- > > ./gradlew build -Pq > > > Thanks, > > Joshua Cohen > >
Re: Review Request 42964: Add flag to optionally disable the leader redirect filter.
> On Jan. 29, 2016, 6:18 p.m., Bill Farner wrote: > > Exploring ideas - would an HTTP header be more handy for this? I like that idea, would save a restart and it would potentially be more generally useful. Will send an update going in that direction. - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42964/#review116973 --- On Jan. 29, 2016, 5:53 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42964/ > --- > > (Updated Jan. 29, 2016, 5:53 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-1601 > https://issues.apache.org/jira/browse/AURORA-1601 > > > Repository: aurora > > > Description > --- > > Add flag to optionally disable the leader redirect filter. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > df649ff4ffdc741afdbc4850c2dbf98bd3e218f1 > src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java > 19c8a1fe06a24022da11f74d7c96b2942587 > > Diff: https://reviews.apache.org/r/42964/diff/ > > > Testing > --- > > ./gradlew build -Pq > > > Thanks, > > Joshua Cohen > >