Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-08-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43027/#review118107 --- NEWS (line 6)

Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-02-14 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43027/#review119205 --- Impl looks good to me in general. Once tests are added, should be

Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-02-13 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43027/#review119157 --- @ReviewBot retry - Bill Farner On Feb. 12, 2016, 6:17 p.m.,

Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-02-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43027/#review119132 --- Master (2b48f22) is red with this patch.

Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-02-12 Thread Benjamin Staffin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43027/ --- (Updated Feb. 12, 2016, 6:17 p.m.) Review request for Aurora. Bugs:

Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-02-05 Thread Benjamin Staffin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43027/ --- (Updated Feb. 5, 2016, 2:57 p.m.) Review request for Aurora. Changes ---

Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-02-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43027/#review118108 --- Ship it! Master (a9e7a35) is green with this patch.

Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-02-04 Thread Benjamin Staffin
> On Feb. 4, 2016, 6:36 a.m., John Sirois wrote: > > Adding explicit reviewers to the People field is the standard way of moving > > an RB forward. As soon as your ready to have this looked at again, please > > add reviewers and give the all clear. Will do, thank you. - Benjamin

Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-02-04 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43027/#review117814 --- Adding explicit reviewers to the People field is the standard way

Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-02-01 Thread Benjamin Staffin
> On Jan. 31, 2016, 3:29 p.m., Stephan Erb wrote: > > With the new proposed option we'd get `--execute-as-user`, `--nosetuid`, > > and `--docker-setuid`. The last two are basically doing the same thing. > > > > Would it make sense to resolve this by pushing things up the stack and > > allow

Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-02-01 Thread Stephan Erb
> On Feb. 1, 2016, 12:29 a.m., Stephan Erb wrote: > > With the new proposed option we'd get `--execute-as-user`, `--nosetuid`, > > and `--docker-setuid`. The last two are basically doing the same thing. > > > > Would it make sense to resolve this by pushing things up the stack and > > allow

Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-01-31 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43027/#review117162 --- With the new proposed option we'd get `--execute-as-user`,

Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-01-30 Thread Benjamin Staffin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43027/#review117137 --- Tests for this are not written yet. - Benjamin Staffin On Jan.

Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-01-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43027/#review117139 --- Master (de0029b) is green with this patch.