Re: Review Request 44486: export environment variables into the shellchecker command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44486/#review122457 --- Just a nit: can you update the title/description to more accurately reflect the actual change being made (exposing ports to shell health checkers)? - Joshua Cohen On March 8, 2016, 12:49 a.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44486/ > --- > > (Updated March 8, 2016, 12:49 a.m.) > > > Review request for Aurora, John Sirois, Bill Farner, and Zameer Manji. > > > Bugs: AURORA-1622 > https://issues.apache.org/jira/browse/AURORA-1622 > > > Repository: aurora > > > Description > --- > > export environment variables into the shellchecker command > > > Diffs > - > > src/main/python/apache/aurora/common/health_check/shell.py > 890bf0c5d50d0022c044a37191a2e3145cc6340f > src/main/python/apache/aurora/executor/common/health_checker.py > 303972778baa04e9d7dd47fb208fe1427e779976 > src/test/python/apache/aurora/common/health_check/test_shell.py > 84f717fbf724c11863b4980fd2740dc23fe1404e > src/test/python/apache/aurora/executor/common/test_health_checker.py > 9bebce8f5a26662f58075d7ce881a8bdacb2fe46 > > Diff: https://reviews.apache.org/r/44486/diff/ > > > Testing > --- > > Unit and end to end test. > > > Thanks, > > Dmitriy Shirchenko > >
Re: Review Request 44486: export environment variables into the shellchecker command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44486/#review122448 --- Ship it! Ship It! - Bill Farner On March 7, 2016, 4:49 p.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44486/ > --- > > (Updated March 7, 2016, 4:49 p.m.) > > > Review request for Aurora, John Sirois, Bill Farner, and Zameer Manji. > > > Bugs: AURORA-1622 > https://issues.apache.org/jira/browse/AURORA-1622 > > > Repository: aurora > > > Description > --- > > export environment variables into the shellchecker command > > > Diffs > - > > src/main/python/apache/aurora/common/health_check/shell.py > 890bf0c5d50d0022c044a37191a2e3145cc6340f > src/main/python/apache/aurora/executor/common/health_checker.py > 303972778baa04e9d7dd47fb208fe1427e779976 > src/test/python/apache/aurora/common/health_check/test_shell.py > 84f717fbf724c11863b4980fd2740dc23fe1404e > src/test/python/apache/aurora/executor/common/test_health_checker.py > 9bebce8f5a26662f58075d7ce881a8bdacb2fe46 > > Diff: https://reviews.apache.org/r/44486/diff/ > > > Testing > --- > > Unit and end to end test. > > > Thanks, > > Dmitriy Shirchenko > >
Re: Review Request 44486: export environment variables into the shellchecker command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44486/#review122438 --- Ship it! Master (a91a759) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On March 8, 2016, 12:49 a.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44486/ > --- > > (Updated March 8, 2016, 12:49 a.m.) > > > Review request for Aurora, John Sirois, Bill Farner, and Zameer Manji. > > > Bugs: AURORA-1622 > https://issues.apache.org/jira/browse/AURORA-1622 > > > Repository: aurora > > > Description > --- > > export environment variables into the shellchecker command > > > Diffs > - > > src/main/python/apache/aurora/common/health_check/shell.py > 890bf0c5d50d0022c044a37191a2e3145cc6340f > src/main/python/apache/aurora/executor/common/health_checker.py > 303972778baa04e9d7dd47fb208fe1427e779976 > src/test/python/apache/aurora/common/health_check/test_shell.py > 84f717fbf724c11863b4980fd2740dc23fe1404e > src/test/python/apache/aurora/executor/common/test_health_checker.py > 9bebce8f5a26662f58075d7ce881a8bdacb2fe46 > > Diff: https://reviews.apache.org/r/44486/diff/ > > > Testing > --- > > Unit and end to end test. > > > Thanks, > > Dmitriy Shirchenko > >
Re: Review Request 44486: export environment variables into the shellchecker command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44486/ --- (Updated March 8, 2016, 12:48 a.m.) Review request for Aurora, John Sirois, Bill Farner, and Zameer Manji. Bugs: AURORA-1622 https://issues.apache.org/jira/browse/AURORA-1622 Repository: aurora Description (updated) --- export environment variables into the shellchecker command Diffs - src/main/python/apache/aurora/common/health_check/shell.py 890bf0c5d50d0022c044a37191a2e3145cc6340f src/main/python/apache/aurora/executor/common/health_checker.py 303972778baa04e9d7dd47fb208fe1427e779976 src/test/python/apache/aurora/common/health_check/test_shell.py 84f717fbf724c11863b4980fd2740dc23fe1404e src/test/python/apache/aurora/executor/common/test_health_checker.py 9bebce8f5a26662f58075d7ce881a8bdacb2fe46 Diff: https://reviews.apache.org/r/44486/diff/ Testing (updated) --- Unit and end to end test. Thanks, Dmitriy Shirchenko
