----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45172/#review124956 -----------------------------------------------------------
examples/vagrant/provision-dev-cluster.sh (lines 89 - 92) <https://reviews.apache.org/r/45172/#comment187663> Echoing IRC discussion: i'm -1 to this change because it copies sources but does not effect the change by restarting components. You rightly point out that it's no different from the copy we do for the upstart configs. My vote is we do one of the following: 1. move the upstart config copy out of `update-sources` and do it only at provision time 2. create a helper function that accepts 3 args: `src`, `dest`, `on_change_cmd`, which will do an `rsync` and invoke `on_change_cmd` if any files were changed. use this to restart components that were reconfigured I think there's not much effort in (2), but it's objectively less work than (1). What do you think? - Bill Farner On March 22, 2016, 11:53 a.m., Joshua Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45172/ > ----------------------------------------------------------- > > (Updated March 22, 2016, 11:53 a.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Tweak update-sources script to also update mesos config. > > > Diffs > ----- > > examples/vagrant/provision-dev-cluster.sh > b1f661ea90ac427621518f653cce1b7630d2a6ed > > Diff: https://reviews.apache.org/r/45172/diff/ > > > Testing > ------- > > > Thanks, > > Joshua Cohen > >
