Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-06 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/#review127350 --- Ship it! I will merge once I was able to build the box and run

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/#review127244 --- Ship it! Master (a9b3df8) is green with this patch.

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Zhitao Li
> On April 5, 2016, 5:50 p.m., Maxim Khutornenko wrote: > > src/test/sh/org/apache/aurora/e2e/http/http_example.aurora, line 21 > > > > > > Curious, what do changes in this file actually test? > > Zhitao Li wrote: >

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/ --- (Updated April 5, 2016, 11 p.m.) Review request for Aurora, Kunal Thakar and

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Maxim Khutornenko
> On April 5, 2016, 5:50 p.m., Maxim Khutornenko wrote: > > src/test/sh/org/apache/aurora/e2e/http/http_example.aurora, line 21 > > > > > > Curious, what do changes in this file actually test? > > Zhitao Li wrote: >

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Zhitao Li
> On April 5, 2016, 5:50 p.m., Maxim Khutornenko wrote: > > src/test/sh/org/apache/aurora/e2e/http/http_example.aurora, line 21 > > > > > > Curious, what do changes in this file actually test? > > Zhitao Li wrote: >

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Maxim Khutornenko
> On April 5, 2016, 5:50 p.m., Maxim Khutornenko wrote: > > src/test/sh/org/apache/aurora/e2e/http/http_example.aurora, line 21 > > > > > > Curious, what do changes in this file actually test? > > Zhitao Li wrote: >

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/ --- (Updated April 5, 2016, 6:15 p.m.) Review request for Aurora, Kunal Thakar and

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Zhitao Li
> On April 5, 2016, 5:50 p.m., Maxim Khutornenko wrote: > > src/test/sh/org/apache/aurora/e2e/http/http_example.aurora, line 21 > > > > > > Curious, what do changes in this file actually test? I used this to trigger

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/#review127147 --- A few drive by notes. LGTM overall.

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/#review127122 --- Ship it! Master (f729fd4) is green with this patch.

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/ --- (Updated April 5, 2016, 4:20 p.m.) Review request for Aurora, Kunal Thakar and

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/#review127116 --- This patch does not apply cleanly against master (f729fd4), do

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/ --- (Updated April 5, 2016, 4:02 p.m.) Review request for Aurora, Kunal Thakar and

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Zhitao Li
> On April 5, 2016, 1:39 p.m., Stephan Erb wrote: > > docs/features/service-discovery.md, line 31 > > > > > > How does Mesos DNS find out about our primary port? The code below > > reads like we just populate all

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/ --- (Updated April 5, 2016, 3:50 p.m.) Review request for Aurora, Kunal Thakar and

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/#review126960 --- docs/features/service-discovery.md (line 31)

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/#review126928 --- Ship it! Master (9847b02) is green with this patch.

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-04 Thread Zhitao Li
> On April 1, 2016, 12:05 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line > > 242 > > > > > > Should we consider using the inverse notation here? This would

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-04 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/ --- (Updated April 4, 2016, 7:44 p.m.) Review request for Aurora, Kunal Thakar and

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-01 Thread Zhitao Li
> On April 1, 2016, 12:05 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line > > 242 > > > > > > Should we consider using the inverse notation here? This would

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-01 Thread Zhitao Li
> On March 31, 2016, 8:25 p.m., Joshua Cohen wrote: > > RELEASE-NOTES.md, line 14 > > > > > > Is there any reason we need a command line arg to control this? Is > > there any detriment to just always populating

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-01 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/#review126574 --- Please add an explanation of the feature to

Re: Review Request 45177: Setting DiscoveryInfo.

2016-03-31 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/#review126463 --- Master (17ade11) is red with this patch.

Re: Review Request 45177: Setting DiscoveryInfo.

2016-03-31 Thread Joshua Cohen
> On March 31, 2016, 8:25 p.m., Joshua Cohen wrote: > > RELEASE-NOTES.md, line 14 > > > > > > Is there any reason we need a command line arg to control this? Is > > there any detriment to just always populating

Re: Review Request 45177: Setting DiscoveryInfo.

2016-03-31 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/ --- (Updated March 31, 2016, 9:48 p.m.) Review request for Aurora, Kunal Thakar

Re: Review Request 45177: Setting DiscoveryInfo.

2016-03-31 Thread Joshua Cohen
> On March 31, 2016, 8:25 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line > > 242 > > > > > > Can you also set DiscoveryInfo.location to the cluster name?

Re: Review Request 45177: Setting DiscoveryInfo.

2016-03-31 Thread Zhitao Li
> On March 31, 2016, 8:25 p.m., Joshua Cohen wrote: > > RELEASE-NOTES.md, line 14 > > > > > > Is there any reason we need a command line arg to control this? Is > > there any detriment to just always populating

Re: Review Request 45177: Setting DiscoveryInfo.

2016-03-31 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/#review126435 --- This patch does not apply cleanly against master (193f17e), do

Re: Review Request 45177: Setting DiscoveryInfo.

2016-03-31 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/#review126428 --- RELEASE-NOTES.md (line 14)

Re: Review Request 45177: Setting DiscoveryInfo.

2016-03-31 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/ --- (Updated March 31, 2016, 7:51 p.m.) Review request for Aurora. Changes