Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

2016-03-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45222/#review126219 --- Master (55a2422) is red with this patch.

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

2016-03-30 Thread Amol Deshmukh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45222/ --- (Updated March 30, 2016, 4 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

2016-03-30 Thread Joshua Cohen
> On March 30, 2016, 8:47 p.m., Joshua Cohen wrote: > > Ship It! Can you rebase and fix the conflicts in RELEASE-NOTES.md? Then I'll commit this. - Joshua --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

2016-03-30 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45222/#review126196 --- Ship it! Ship It! - Joshua Cohen On March 29, 2016, 5:51

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

2016-03-30 Thread Bill Farner
> On March 30, 2016, 9:49 a.m., Joshua Cohen wrote: > > Code-wise this looks fine to me, however, I have some reservations about > > making tier required. I think that throwing a `TaskDescriptionError` when > > tier is defined, but not valid is fine, but can we/should we continue to > >

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

2016-03-30 Thread Amol Deshmukh
> On March 30, 2016, 9:49 a.m., Joshua Cohen wrote: > > Code-wise this looks fine to me, however, I have some reservations about > > making tier required. I think that throwing a `TaskDescriptionError` when > > tier is defined, but not valid is fine, but can we/should we continue to > >

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

2016-03-30 Thread Bill Farner
> On March 30, 2016, 9:49 a.m., Joshua Cohen wrote: > > Code-wise this looks fine to me, however, I have some reservations about > > making tier required. I think that throwing a `TaskDescriptionError` when > > tier is defined, but not valid is fine, but can we/should we continue to > >

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

2016-03-30 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45222/#review126132 --- Code-wise this looks fine to me, however, I have some

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

2016-03-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45222/#review125922 --- Ship it! Master (ec29ac1) is green with this patch.

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

2016-03-29 Thread Amol Deshmukh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45222/ --- (Updated March 29, 2016, 10:51 a.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

2016-03-28 Thread Amol Deshmukh
> On March 28, 2016, 1:23 p.m., Bill Farner wrote: > > I won't have time to review this, so i'd like to stand down. > > > > However, please make sure to add appropriate release notes, specifically > > for the stated backwards incompatibility. Will do. I will post an updated review request

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

2016-03-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45222/#review125737 --- I won't have time to review this, so i'd like to stand down.

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

2016-03-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45222/#review125729 --- This patch does not apply cleanly against master (0950095), do

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

2016-03-28 Thread Amol Deshmukh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45222/ --- (Updated March 28, 2016, 12:43 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

2016-03-28 Thread Amol Deshmukh
> On March 28, 2016, 9:36 a.m., Maxim Khutornenko wrote: > > src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java, > > line 131 > > > > > > Any reason to allow more than "once"

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

2016-03-28 Thread Amol Deshmukh
> On March 28, 2016, 9:36 a.m., Maxim Khutornenko wrote: > > src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java, > > line 131 > > > > > > Any reason to allow more than "once"

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

2016-03-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45222/#review125671 --- Ship it!

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

2016-03-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45222/#review125496 --- Ship it! Master (b352e8b) is green with this patch.

Re: Review Request 45222: Introduce "preemptible" flag in TierInfo with backward compatible support for "production" flag in TaskConfig.

2016-03-25 Thread Amol Deshmukh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45222/ --- (Updated March 25, 2016, 5:08 p.m.) Review request for Aurora, Joshua Cohen,