Re: Review Request 45372: Remove sleep and address flaky health check test.
> On March 28, 2016, 5:03 a.m., Stephan Erb wrote: > > FWIW, there is als this very old review requests that is talking about the > > same tests https://reviews.apache.org/r/31380/diff/1#index_header. What > > does Brian mean with "calling .converge"? > > John Sirois wrote: > He means the calls to this in the test code: > https://github.com/twitter/commons/blob/master/src/python/twitter/common/testing/clock.py#L109 > I'm also interested in that approach since the failures I saw from > AuroraBot in https://reviews.apache.org/r/45366/ were both off by the epsilon. I've opted to skip the test in the latest patch. I'm not confident that i have the necessary skill to fix this test in the desired way and ensure it is not flaky. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45372/#review125628 --- On March 27, 2016, 8:41 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45372/ > --- > > (Updated March 27, 2016, 8:41 p.m.) > > > Review request for Aurora, John Sirois and Zameer Manji. > > > Repository: aurora > > > Description > --- > > Posting this patch to at least start a conversation on fixing this test; i've > noticed it flaking pretty frequently lately. Here i take the quick and dirty > approach of removing the sleep and glossing over the `total_latency_secs` > value. > > > Diffs > - > > src/test/python/apache/aurora/executor/common/test_health_checker.py > 19c4f76347e34374c29974c182d1f4c118bcb18d > > Diff: https://reviews.apache.org/r/45372/diff/ > > > Testing > --- > > None yet > > > Thanks, > > Bill Farner > >
Re: Review Request 45372: Remove sleep and address flaky health check test.
> On March 28, 2016, 6:03 a.m., Stephan Erb wrote: > > FWIW, there is als this very old review requests that is talking about the > > same tests https://reviews.apache.org/r/31380/diff/1#index_header. What > > does Brian mean with "calling .converge"? He means the calls to this in the test code: https://github.com/twitter/commons/blob/master/src/python/twitter/common/testing/clock.py#L109 I'm also interested in that approach since the failures I saw from AuroraBot in https://reviews.apache.org/r/45366/ were both off by the epsilon. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45372/#review125628 --- On March 27, 2016, 9:41 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45372/ > --- > > (Updated March 27, 2016, 9:41 p.m.) > > > Review request for Aurora, John Sirois and Zameer Manji. > > > Repository: aurora > > > Description > --- > > Posting this patch to at least start a conversation on fixing this test; i've > noticed it flaking pretty frequently lately. Here i take the quick and dirty > approach of removing the sleep and glossing over the `total_latency_secs` > value. > > > Diffs > - > > src/test/python/apache/aurora/executor/common/test_health_checker.py > 19c4f76347e34374c29974c182d1f4c118bcb18d > > Diff: https://reviews.apache.org/r/45372/diff/ > > > Testing > --- > > None yet > > > Thanks, > > Bill Farner > >
Re: Review Request 45372: Remove sleep and address flaky health check test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45372/#review125628 --- FWIW, there is als this very old review requests that is talking about the same tests https://reviews.apache.org/r/31380/diff/1#index_header. What does Brian mean with "calling .converge"? - Stephan Erb On March 28, 2016, 5:41 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45372/ > --- > > (Updated March 28, 2016, 5:41 a.m.) > > > Review request for Aurora, John Sirois and Zameer Manji. > > > Repository: aurora > > > Description > --- > > Posting this patch to at least start a conversation on fixing this test; i've > noticed it flaking pretty frequently lately. Here i take the quick and dirty > approach of removing the sleep and glossing over the `total_latency_secs` > value. > > > Diffs > - > > src/test/python/apache/aurora/executor/common/test_health_checker.py > 19c4f76347e34374c29974c182d1f4c118bcb18d > > Diff: https://reviews.apache.org/r/45372/diff/ > > > Testing > --- > > None yet > > > Thanks, > > Bill Farner > >
Re: Review Request 45372: Remove sleep and address flaky health check test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45372/#review125592 --- Master (b352e8b) is red with this patch. ./build-support/jenkins/build.sh [1m proxy_driver = ProxyDriver()[0m [1m with temporary_dir() as checkpoint_root:[0m [1mte = AuroraExecutor([0m [1m> runner_provider=make_provider(checkpoint_root),[0m [1m sandbox_provider=DefaultTestSandboxProvider())[0m src/test/python/apache/aurora/executor/test_thermos_executor.py:580: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in make_provider [1mpex_location=thermos_runner_path(),[0m _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ build = True [1mdef thermos_runner_path(build=True):[0m [1m if not build:[0m [1mreturn getattr(thermos_runner_path, 'value', None)[0m [1m[0m [1m if not hasattr(thermos_runner_path, 'value'):[0m [1mpex_dir = safe_mkdtemp()[0m [1m> assert subprocess.call(["./pants", "--pants-distdir=%s" % pex_dir, "binary",[0m [1m "src/main/python/apache/thermos/runner:thermos_runner"]) == 0[0m [1m[31mE assert 1 == 0[0m [1m[31mE+ where 1 = (['./pants', '--pants-distdir=/tmp/user/2/tmpUYybxs', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])[0m [1m[31mE+where = subprocess.call[0m src/test/python/apache/aurora/executor/test_thermos_executor.py:185: AssertionError -- Captured stderr call -- Traceback (most recent call last): File "/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.75/bin/pants", line 7, in from pants.bin.pants_exe import main ImportError: No module named pants.bin.pants_exe generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml [1m[31m 18 failed, 638 passed, 5 skipped, 1 warnings, 8 error in 294.75 seconds [0m FAILURE 04:23:23 07:21 [complete][31m FAILURE[0m I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On March 28, 2016, 3:41 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45372/ > --- > > (Updated March 28, 2016, 3:41 a.m.) > > > Review request for Aurora, John Sirois and Zameer Manji. > > > Repository: aurora > > > Description > --- > > Posting this patch to at least start a conversation on fixing this test; i've > noticed it flaking pretty frequently lately. Here i take the quick and dirty > approach of removing the sleep and glossing over the `total_latency_secs` > value. > > > Diffs > - > > src/test/python/apache/aurora/executor/common/test_health_checker.py > 19c4f76347e34374c29974c182d1f4c118bcb18d > > Diff: https://reviews.apache.org/r/45372/diff/ > > > Testing > --- > > None yet > > > Thanks, > > Bill Farner > >
