Re: Review Request 45506: Execute shell-based health checks as the task user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45506/#review126447 --- Ship it! Ship It! - Zameer Manji On March 31, 2016, 1:18 p.m

Re: Review Request 45506: Execute shell-based health checks as the task user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45506/#review126443 --- Ship it! Ship It! - Dmitriy Shirchenko On March 31, 2016, 8:

Re: Review Request 45506: Execute shell-based health checks as the task user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45506/#review126434 --- Ship it! Master (193f17e) is green with this patch. ./build-s

Re: Review Request 45506: Execute shell-based health checks as the task user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45506/ --- (Updated March 31, 2016, 1:18 p.m.) Review request for Aurora, Dmitriy Shirchen

Re: Review Request 45506: Execute shell-based health checks as the task user.

> On March 31, 2016, 9:20 a.m., Dmitriy Shirchenko wrote: > > src/main/python/apache/aurora/common/health_check/shell.py, line 66 > > > > > > why are you doing a separate try/except with timeout when > > subprocess.P

Re: Review Request 45506: Execute shell-based health checks as the task user.

> On March 31, 2016, 4:20 p.m., Dmitriy Shirchenko wrote: > > src/main/python/apache/aurora/common/health_check/shell.py, line 66 > > > > > > why are you doing a separate try/except with timeout when > > subprocess.P

Re: Review Request 45506: Execute shell-based health checks as the task user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45506/#review126408 --- Ship it! Master (193f17e) is green with this patch. ./build-s

Re: Review Request 45506: Execute shell-based health checks as the task user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45506/ --- (Updated March 31, 2016, 11:57 a.m.) Review request for Aurora, Dmitriy Shirche

Re: Review Request 45506: Execute shell-based health checks as the task user.

> On March 31, 2016, 9:20 a.m., Dmitriy Shirchenko wrote: > > src/main/python/apache/aurora/common/health_check/shell.py, line 66 > > > > > > why are you doing a separate try/except with timeout when > > subprocess.P

Re: Review Request 45506: Execute shell-based health checks as the task user.

> On March 31, 2016, 6:11 p.m., Zameer Manji wrote: > > The change and the tests LGTM. > > > > I currently have great ideas on how to ensure end to end validation. The > > best idea that I can provide is make use of the shell checker in the e2e > > tests. The program executed by the shell chec

Re: Review Request 45506: Execute shell-based health checks as the task user.

> On March 31, 2016, 6:11 p.m., Zameer Manji wrote: > > The change and the tests LGTM. > > > > I currently have great ideas on how to ensure end to end validation. The > > best idea that I can provide is make use of the shell checker in the e2e > > tests. The program executed by the shell chec

Re: Review Request 45506: Execute shell-based health checks as the task user.

> On March 31, 2016, 4:20 p.m., Dmitriy Shirchenko wrote: > > src/main/python/apache/aurora/common/health_check/shell.py, line 60 > > > > > > why did you get rid of .format? i personally find it much clearer to > > u

Re: Review Request 45506: Execute shell-based health checks as the task user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45506/ --- (Updated March 31, 2016, 11:38 a.m.) Review request for Aurora, Dmitriy Shirche

Re: Review Request 45506: Execute shell-based health checks as the task user.

> On March 31, 2016, 11:11 a.m., Zameer Manji wrote: > > The change and the tests LGTM. > > > > I currently have great ideas on how to ensure end to end validation. The > > best idea that I can provide is make use of the shell checker in the e2e > > tests. The program executed by the shell che

Re: Review Request 45506: Execute shell-based health checks as the task user.

> On March 31, 2016, 11:11 a.m., Zameer Manji wrote: > > The change and the tests LGTM. > > > > I currently have great ideas on how to ensure end to end validation. The > > best idea that I can provide is make use of the shell checker in the e2e > > tests. The program executed by the shell che

Re: Review Request 45506: Execute shell-based health checks as the task user.

> On March 31, 2016, 6:11 p.m., Zameer Manji wrote: > > The change and the tests LGTM. > > > > I currently have great ideas on how to ensure end to end validation. The > > best idea that I can provide is make use of the shell checker in the e2e > > tests. The program executed by the shell chec

Re: Review Request 45506: Execute shell-based health checks as the task user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45506/#review126387 --- Ship it! Master (193f17e) is green with this patch. ./build-s

Re: Review Request 45506: Execute shell-based health checks as the task user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45506/#review126378 --- The change and the tests LGTM. I currently have great ideas on ho

Re: Review Request 45506: Execute shell-based health checks as the task user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45506/ --- (Updated March 31, 2016, 11:01 a.m.) Review request for Aurora, Dmitriy Shirche

Re: Review Request 45506: Execute shell-based health checks as the task user.

> On March 31, 2016, 9:20 a.m., Dmitriy Shirchenko wrote: > > src/main/python/apache/aurora/common/health_check/shell.py, line 60 > > > > > > why did you get rid of .format? i personally find it much clearer to > > u

Re: Review Request 45506: Execute shell-based health checks as the task user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45506/#review126326 --- src/main/python/apache/aurora/common/health_check/shell.py (line

Re: Review Request 45506: Execute shell-based health checks as the task user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45506/#review126226 --- Ship it! Master (193f17e) is green with this patch. ./build-s

Re: Review Request 45506: Execute shell-based health checks as the task user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45506/ --- (Updated March 30, 2016, 4:41 p.m.) Review request for Aurora, Dmitriy Shirchen

Re: Review Request 45506: Execute shell-based health checks as the task user.

> On March 30, 2016, 3:07 p.m., John Sirois wrote: > > There is code to do this in apache.thermos.core.process.Process and its > > tested here: > > https://github.com/apache/aurora/blob/master/src/test/python/apache/thermos/core/test_process.py#L103 > > Process (ProcessBase) does look a bit fat

Re: Review Request 45506: Execute shell-based health checks as the task user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45506/#review126207 --- Master (55a2422) is red with this patch. ./build-support/jenkins

Re: Review Request 45506: Execute shell-based health checks as the task user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45506/#review126206 --- There is code to do this in apache.thermos.core.process.Process an