Re: Review Request 46603: Introduce command line option to control the offer filter duration

2016-04-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46603/#review130859 --- Ship it! Ship It! - Maxim Khutornenko On April 27, 2016, 10:

Re: Review Request 46603: Introduce command line option to control the offer filter duration

2016-04-27 Thread Stephan Erb
> On April 24, 2016, 5:48 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java, line 51 > > > > > > Does this default value effect the same behavior as before the patch? > >

Re: Review Request 46603: Introduce command line option to control the offer filter duration

2016-04-27 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46603/ --- (Updated April 28, 2016, 12:12 a.m.) Review request for Aurora, Maxim Khutornen

Re: Review Request 46603: Introduce command line option to control the offer filter duration

2016-04-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46603/#review130855 --- Ship it! Master (7e30ebe) is green with this patch. ./build-s

Re: Review Request 46603: Introduce command line option to control the offer filter duration

2016-04-27 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46603/ --- (Updated April 27, 2016, 11:49 p.m.) Review request for Aurora, Maxim Khutornen

Re: Review Request 46603: Introduce command line option to control the offer filter duration

2016-04-25 Thread Maxim Khutornenko
> On April 24, 2016, 3:48 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java, line 51 > > > > > > Does this default value effect the same behavior as before the patch? > >

Re: Review Request 46603: Introduce command line option to control the offer filter duration

2016-04-24 Thread Stephan Erb
> On April 24, 2016, 5:48 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java, line 51 > > > > > > Does this default value effect the same behavior as before the patch? Usi

Re: Review Request 46603: Introduce command line option to control the offer filter duration

2016-04-24 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46603/#review130306 --- Fix it, then Ship it! LGTM overall, one question that i've open

Re: Review Request 46603: Introduce command line option to control the offer filter duration

2016-04-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46603/#review130262 --- Ship it! Master (d339036) is green with this patch. ./build-s

Re: Review Request 46603: Introduce command line option to control the offer filter duration

2016-04-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46603/ --- (Updated April 23, 2016, 6:35 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 46603: Introduce command line option to control the offer filter duration

2016-04-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46603/#review130261 --- Master (d339036) is red with this patch. ./build-support/jenkins

Re: Review Request 46603: Introduce command line option to control the offer filter duration

2016-04-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46603/#review130260 --- src/main/java/org/apache/aurora/scheduler/offers/OffersModule.jav