Re: Review Request 46948: Adding mesos resource converter

2016-05-04 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46948/#review131735
---


Ship it!




Ship It!

- Zameer Manji


On May 3, 2016, 2:11 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46948/
> ---
> 
> (Updated May 3, 2016, 2:11 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> A trivial patch to replace mesos type with the converter object in 
> `ResourceType`. 
> 
> This is mostly an attempt to offload this standalone change from the upcoming 
> larger diff that will introduce a unified approach of handling 
> `ResourceAggregate` and `ResourceSlot` data.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/resources/MesosResourceConverter.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 
> 8b42bf0d2f4a4a19e52875440d825bc6ee553f3b 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java 
> ee2b51a587271457c5f1e0bcec6885bb4d0bc68f 
>   
> src/main/java/org/apache/aurora/scheduler/resources/ResourceTypeConverter.java
>  11395ecfdb701e7c6197b971482cb70a257fb06e 
>   src/main/java/org/apache/aurora/scheduler/resources/Resources.java 
> 36d1de85658afd5b0d933e833c7193c60afdfd9c 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DBResource.java 
> dc7e97d1ea1f74594310bc346f18f2ed547f007d 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DBResourceAggregate.java
>  8c5d1f014cd448dbd2fdfa798ac8a3323855861f 
>   
> src/test/java/org/apache/aurora/scheduler/resources/MesosResourceConverterTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java 
> b6810b18677b9e030ad84a214ca7dc6746990d4f 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 
> 1583cefd568f4ed71f6953d5da0e2b2035bc 
>   
> src/test/java/org/apache/aurora/scheduler/resources/ResourceTypeConverterTest.java
>  78da84a9500de93025db5180c1d98a0669d62ec6 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTypeTest.java 
> dc9dc668e9f0a7484c62950834b5ae8cae2a1887 
> 
> Diff: https://reviews.apache.org/r/46948/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 46948: Adding mesos resource converter

2016-05-04 Thread Joshua Cohen 


> On May 4, 2016, 2:29 p.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/resources/MesosResourceConverter.java,
> >  line 34
> > 
> >
> > Can you add tests for these classes?
> 
> Maxim Khutornenko wrote:
> These are already tested in MesosResourceConverterTest: 
> https://reviews.apache.org/r/46948/diff/1#7

Wow, how did I miss that!


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46948/#review131680
---


On May 3, 2016, 9:11 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46948/
> ---
> 
> (Updated May 3, 2016, 9:11 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> A trivial patch to replace mesos type with the converter object in 
> `ResourceType`. 
> 
> This is mostly an attempt to offload this standalone change from the upcoming 
> larger diff that will introduce a unified approach of handling 
> `ResourceAggregate` and `ResourceSlot` data.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/resources/MesosResourceConverter.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 
> 8b42bf0d2f4a4a19e52875440d825bc6ee553f3b 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java 
> ee2b51a587271457c5f1e0bcec6885bb4d0bc68f 
>   
> src/main/java/org/apache/aurora/scheduler/resources/ResourceTypeConverter.java
>  11395ecfdb701e7c6197b971482cb70a257fb06e 
>   src/main/java/org/apache/aurora/scheduler/resources/Resources.java 
> 36d1de85658afd5b0d933e833c7193c60afdfd9c 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DBResource.java 
> dc7e97d1ea1f74594310bc346f18f2ed547f007d 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DBResourceAggregate.java
>  8c5d1f014cd448dbd2fdfa798ac8a3323855861f 
>   
> src/test/java/org/apache/aurora/scheduler/resources/MesosResourceConverterTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java 
> b6810b18677b9e030ad84a214ca7dc6746990d4f 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 
> 1583cefd568f4ed71f6953d5da0e2b2035bc 
>   
> src/test/java/org/apache/aurora/scheduler/resources/ResourceTypeConverterTest.java
>  78da84a9500de93025db5180c1d98a0669d62ec6 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTypeTest.java 
> dc9dc668e9f0a7484c62950834b5ae8cae2a1887 
> 
> Diff: https://reviews.apache.org/r/46948/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 46948: Adding mesos resource converter

2016-05-04 Thread Maxim Khutornenko 


> On May 4, 2016, 2:29 p.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/resources/MesosResourceConverter.java,
> >  line 34
> > 
> >
> > Can you add tests for these classes?

These are already tested in MesosResourceConverterTest: 
https://reviews.apache.org/r/46948/diff/1#7


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46948/#review131680
---


On May 3, 2016, 9:11 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46948/
> ---
> 
> (Updated May 3, 2016, 9:11 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> A trivial patch to replace mesos type with the converter object in 
> `ResourceType`. 
> 
> This is mostly an attempt to offload this standalone change from the upcoming 
> larger diff that will introduce a unified approach of handling 
> `ResourceAggregate` and `ResourceSlot` data.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/resources/MesosResourceConverter.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 
> 8b42bf0d2f4a4a19e52875440d825bc6ee553f3b 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java 
> ee2b51a587271457c5f1e0bcec6885bb4d0bc68f 
>   
> src/main/java/org/apache/aurora/scheduler/resources/ResourceTypeConverter.java
>  11395ecfdb701e7c6197b971482cb70a257fb06e 
>   src/main/java/org/apache/aurora/scheduler/resources/Resources.java 
> 36d1de85658afd5b0d933e833c7193c60afdfd9c 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DBResource.java 
> dc7e97d1ea1f74594310bc346f18f2ed547f007d 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DBResourceAggregate.java
>  8c5d1f014cd448dbd2fdfa798ac8a3323855861f 
>   
> src/test/java/org/apache/aurora/scheduler/resources/MesosResourceConverterTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java 
> b6810b18677b9e030ad84a214ca7dc6746990d4f 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 
> 1583cefd568f4ed71f6953d5da0e2b2035bc 
>   
> src/test/java/org/apache/aurora/scheduler/resources/ResourceTypeConverterTest.java
>  78da84a9500de93025db5180c1d98a0669d62ec6 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTypeTest.java 
> dc9dc668e9f0a7484c62950834b5ae8cae2a1887 
> 
> Diff: https://reviews.apache.org/r/46948/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 46948: Adding mesos resource converter

2016-05-04 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46948/#review131680
---


Ship it!




lgtm once coverage is added.


src/main/java/org/apache/aurora/scheduler/resources/MesosResourceConverter.java 
(line 34)


Can you add tests for these classes?


- Joshua Cohen


On May 3, 2016, 9:11 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46948/
> ---
> 
> (Updated May 3, 2016, 9:11 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> A trivial patch to replace mesos type with the converter object in 
> `ResourceType`. 
> 
> This is mostly an attempt to offload this standalone change from the upcoming 
> larger diff that will introduce a unified approach of handling 
> `ResourceAggregate` and `ResourceSlot` data.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/resources/MesosResourceConverter.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 
> 8b42bf0d2f4a4a19e52875440d825bc6ee553f3b 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java 
> ee2b51a587271457c5f1e0bcec6885bb4d0bc68f 
>   
> src/main/java/org/apache/aurora/scheduler/resources/ResourceTypeConverter.java
>  11395ecfdb701e7c6197b971482cb70a257fb06e 
>   src/main/java/org/apache/aurora/scheduler/resources/Resources.java 
> 36d1de85658afd5b0d933e833c7193c60afdfd9c 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DBResource.java 
> dc7e97d1ea1f74594310bc346f18f2ed547f007d 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DBResourceAggregate.java
>  8c5d1f014cd448dbd2fdfa798ac8a3323855861f 
>   
> src/test/java/org/apache/aurora/scheduler/resources/MesosResourceConverterTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java 
> b6810b18677b9e030ad84a214ca7dc6746990d4f 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 
> 1583cefd568f4ed71f6953d5da0e2b2035bc 
>   
> src/test/java/org/apache/aurora/scheduler/resources/ResourceTypeConverterTest.java
>  78da84a9500de93025db5180c1d98a0669d62ec6 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTypeTest.java 
> dc9dc668e9f0a7484c62950834b5ae8cae2a1887 
> 
> Diff: https://reviews.apache.org/r/46948/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 46948: Adding mesos resource converter

2016-05-03 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46948/#review131602
---



Master (8a2fc4c) is red with this patch.
  ./build-support/jenkins/build.sh

Branch coverage is 0.7833495618305745, but must be greater than 0.835
:analyzeReport FAILED

FAILURE: Build completed with 2 failures.

1: Task failed with an exception.
---
* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at: 
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.
==

2: Task failed with an exception.
---
* What went wrong:
Execution failed for task ':analyzeReport'.
> Test coverage missing for org/apache/aurora/GuiceUtils$2
  Test coverage missing for 
org/apache/aurora/scheduler/stats/AsyncStatsModule$SlotSizeCounterService
  Test coverage missing for 
org/apache/aurora/scheduler/stats/AsyncStatsModule$TaskStatUpdaterService
  Test coverage missing for 
org/apache/aurora/scheduler/http/api/security/ShiroKerberosPermissiveAuthenticationFilter
  Test coverage missing for 
org/apache/aurora/scheduler/discovery/CuratorSingletonService
  Test coverage missing for 
org/apache/aurora/scheduler/discovery/CuratorSingletonService$1$1
  Test coverage missing for 
org/apache/aurora/scheduler/discovery/CuratorSingletonService$Advertiser
  Test coverage missing for 
org/apache/aurora/scheduler/discovery/CuratorSingletonService$1
  Test coverage missing for 
org/apache/aurora/scheduler/cron/quartz/CronLifecycle
  Test coverage missing for 
org/apache/aurora/scheduler/cron/quartz/AuroraCronJobFactory
  Test coverage missing for 
org/apache/aurora/scheduler/preemptor/PreemptorModule$PreemptorService
  Test coverage missing for 
org/apache/aurora/scheduler/storage/log/LogStorage$ScheduledExecutorSchedulingService
  Test coverage missing for 
org/apache/aurora/scheduler/SchedulerLifecycle$DefaultDelayedActions

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.
==

BUILD FAILED

Total time: 13 mins 28.289 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 3, 2016, 9:11 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46948/
> ---
> 
> (Updated May 3, 2016, 9:11 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> A trivial patch to replace mesos type with the converter object in 
> `ResourceType`. 
> 
> This is mostly an attempt to offload this standalone change from the upcoming 
> larger diff that will introduce a unified approach of handling 
> `ResourceAggregate` and `ResourceSlot` data.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/resources/MesosResourceConverter.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 
> 8b42bf0d2f4a4a19e52875440d825bc6ee553f3b 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java 
> ee2b51a587271457c5f1e0bcec6885bb4d0bc68f 
>   
> src/main/java/org/apache/aurora/scheduler/resources/ResourceTypeConverter.java
>  11395ecfdb701e7c6197b971482cb70a257fb06e 
>   src/main/java/org/apache/aurora/scheduler/resources/Resources.java 
> 36d1de85658afd5b0d933e833c7193c60afdfd9c 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DBResource.java 
> dc7e97d1ea1f74594310bc346f18f2ed547f007d 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DBResourceAggregate.java
>  8c5d1f014cd448dbd2fdfa798ac8a3323855861f 
>   
> src/test/java/org/apache/aurora/scheduler/resources/MesosResourceConverterTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java 
> b6810b18677b9e030ad84a214ca7dc6746990d4f 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 
> 1583cefd568f4ed71f6953d5da0e2b2035bc 
>   
> src/test/java/org/apache/aurora/scheduler/resources/ResourceTypeConverterTest.java
>  78da84a9500de93025db5180c1d98a0669d62ec6 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTypeTest.java 
> dc9dc668e9f0a7484c62950834b5ae8cae2a1887 
> 
> Diff: https://reviews.apache.org/r/46948/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 46948: Adding mesos resource converter

2016-05-03 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46948/#review131596
---



@ReviewBot retry

- Maxim Khutornenko


On May 3, 2016, 9:11 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46948/
> ---
> 
> (Updated May 3, 2016, 9:11 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> A trivial patch to replace mesos type with the converter object in 
> `ResourceType`. 
> 
> This is mostly an attempt to offload this standalone change from the upcoming 
> larger diff that will introduce a unified approach of handling 
> `ResourceAggregate` and `ResourceSlot` data.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/resources/MesosResourceConverter.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 
> 8b42bf0d2f4a4a19e52875440d825bc6ee553f3b 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java 
> ee2b51a587271457c5f1e0bcec6885bb4d0bc68f 
>   
> src/main/java/org/apache/aurora/scheduler/resources/ResourceTypeConverter.java
>  11395ecfdb701e7c6197b971482cb70a257fb06e 
>   src/main/java/org/apache/aurora/scheduler/resources/Resources.java 
> 36d1de85658afd5b0d933e833c7193c60afdfd9c 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DBResource.java 
> dc7e97d1ea1f74594310bc346f18f2ed547f007d 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DBResourceAggregate.java
>  8c5d1f014cd448dbd2fdfa798ac8a3323855861f 
>   
> src/test/java/org/apache/aurora/scheduler/resources/MesosResourceConverterTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java 
> b6810b18677b9e030ad84a214ca7dc6746990d4f 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 
> 1583cefd568f4ed71f6953d5da0e2b2035bc 
>   
> src/test/java/org/apache/aurora/scheduler/resources/ResourceTypeConverterTest.java
>  78da84a9500de93025db5180c1d98a0669d62ec6 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTypeTest.java 
> dc9dc668e9f0a7484c62950834b5ae8cae2a1887 
> 
> Diff: https://reviews.apache.org/r/46948/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 46948: Adding mesos resource converter

2016-05-03 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46948/#review131561
---



Master (d8d1c8d) is red with this patch.
  ./build-support/jenkins/build.sh

+ date
Tue May  3 21:21:26 UTC 2016
+ ./gradlew -Pq clean build
./gradlew: fork: retry: No child processes
./gradlew: fork: retry: No child processes
./gradlew: fork: retry: No child processes
./gradlew: fork: retry: No child processes
./gradlew: fork: Resource temporarily unavailable


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 3, 2016, 9:11 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46948/
> ---
> 
> (Updated May 3, 2016, 9:11 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> A trivial patch to replace mesos type with the converter object in 
> `ResourceType`. 
> 
> This is mostly an attempt to offload this standalone change from the upcoming 
> larger diff that will introduce a unified approach of handling 
> `ResourceAggregate` and `ResourceSlot` data.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/resources/MesosResourceConverter.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 
> 8b42bf0d2f4a4a19e52875440d825bc6ee553f3b 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java 
> ee2b51a587271457c5f1e0bcec6885bb4d0bc68f 
>   
> src/main/java/org/apache/aurora/scheduler/resources/ResourceTypeConverter.java
>  11395ecfdb701e7c6197b971482cb70a257fb06e 
>   src/main/java/org/apache/aurora/scheduler/resources/Resources.java 
> 36d1de85658afd5b0d933e833c7193c60afdfd9c 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DBResource.java 
> dc7e97d1ea1f74594310bc346f18f2ed547f007d 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DBResourceAggregate.java
>  8c5d1f014cd448dbd2fdfa798ac8a3323855861f 
>   
> src/test/java/org/apache/aurora/scheduler/resources/MesosResourceConverterTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java 
> b6810b18677b9e030ad84a214ca7dc6746990d4f 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 
> 1583cefd568f4ed71f6953d5da0e2b2035bc 
>   
> src/test/java/org/apache/aurora/scheduler/resources/ResourceTypeConverterTest.java
>  78da84a9500de93025db5180c1d98a0669d62ec6 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTypeTest.java 
> dc9dc668e9f0a7484c62950834b5ae8cae2a1887 
> 
> Diff: https://reviews.apache.org/r/46948/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>