Re: Review Request 47647: Update packaging to work with Aurora 0.13.

2016-05-28 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47647/
---

(Updated May 28, 2016, 10:38 p.m.)


Review request for Aurora, John Sirois and Bill Farner.


Changes
---

John's comments.


Repository: aurora-packaging


Description
---

In addition to the minimal necessary packaging changes, I have tried
to align the tests of the different distributions.

A few differences remain. Those are mainly due to different defaults
in our DEBs and RPMs. I will leave this to another commit.


Diffs (updated)
-

  build-support/virtualenv 334653bb02e18325a4fc65cc0a0f27d92e82b5c7 
  builder/deb/debian-jessie/build.sh f122a51f88d32bc88b0113d0e2923036edf2a72a 
  specs/debian/control 23afb2bc0fd034286851c0298cb92f752f88ea7a 
  specs/rpm/SOURCES/aurora.sysconfig 166df4d962bae62d01036744f4a709715367ff66 
  specs/rpm/aurora.spec d4007068f179a56fcd5526268377f5cabc73e956 
  test/deb/debian-jessie/README.md 9be58bd452d7ef3e43c158f4c765834c7ea46ca2 
  test/deb/debian-jessie/Vagrantfile 619b793e7a03ff4ec67f51099dc8355e7397ae64 
  test/deb/debian-jessie/provision.sh 6970279d44546d59cd1540879a659b9e14a94cd3 
  test/deb/ubuntu-trusty/README.md ec34ef55b382cb32817ccc6f683314107c8e0b7e 
  test/deb/ubuntu-trusty/Vagrantfile 3d241eb09fe5f66d78d7ff84fbcb0fe25f363b87 
  test/deb/ubuntu-trusty/provision.sh 328f44102183634e1c4c1ad459610892e07a8832 
  test/rpm/centos-7/README.md 527fbb2e84ea5e81e96d7a7e0644186df439cabb 
  test/rpm/centos-7/Vagrantfile 1a641667a6be7bb8ca8b189cad5d4557e8b08621 
  test/rpm/centos-7/provision.sh 199cd43a0fd0fb814fff1d89d745fadbddbe9023 

Diff: https://reviews.apache.org/r/47647/diff/


Testing
---

Manually followed the test instructions. Rendered versions are available here 
https://github.com/StephanErb/aurora-packaging/tree/dedust-0.13


Thanks,

Stephan Erb

Re: Review Request 47647: Update packaging to work with Aurora 0.13.

2016-05-24 Thread Stephan Erb 


> On May 24, 2016, 7:10 p.m., John Sirois wrote:
> > test/deb/debian-jessie/provision.sh, line 13
> > 
> >
> > Is this because dpkg is used instead of `apt-get install`? This is a 
> > bit of a leading question since I'm pretty sure I helped Joshua out of this 
> > same jam.  See here: 
> > https://github.com/apache/aurora/blob/master/build-support/packer/build.sh#L102-L110
> > https://reviews.apache.org/r/46786/

This seems to be a related but different issue. I have added `libcurl4-nss-dev` 
here, which is already a requirement of our packer build box [1]. We also list 
the need for  this requirements in our install instructions [2]. I guess it was 
just an omission in our test scripts as you only run into it when you want to 
use the executor.

[1] 
https://github.com/apache/aurora/blob/master/build-support/packer/build.sh#L38
[2]https://github.com/apache/aurora/blob/master/docs/operations/installation.md#ubuntu-trusty-1


- Stephan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47647/#review134600
---


On May 20, 2016, 6:37 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47647/
> ---
> 
> (Updated May 20, 2016, 6:37 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> In addition to the minimal necessary packaging changes, I have tried
> to align the tests of the different distributions.
> 
> A few differences remain. Those are mainly due to different defaults
> in our DEBs and RPMs. I will leave this to another commit.
> 
> 
> Diffs
> -
> 
>   build-support/virtualenv 334653bb02e18325a4fc65cc0a0f27d92e82b5c7 
>   builder/deb/debian-jessie/build.sh f122a51f88d32bc88b0113d0e2923036edf2a72a 
>   specs/debian/control 23afb2bc0fd034286851c0298cb92f752f88ea7a 
>   specs/rpm/SOURCES/aurora.sysconfig 166df4d962bae62d01036744f4a709715367ff66 
>   specs/rpm/aurora.spec d4007068f179a56fcd5526268377f5cabc73e956 
>   test/deb/debian-jessie/README.md 9be58bd452d7ef3e43c158f4c765834c7ea46ca2 
>   test/deb/debian-jessie/Vagrantfile 619b793e7a03ff4ec67f51099dc8355e7397ae64 
>   test/deb/debian-jessie/provision.sh 
> 6970279d44546d59cd1540879a659b9e14a94cd3 
>   test/deb/ubuntu-trusty/README.md ec34ef55b382cb32817ccc6f683314107c8e0b7e 
>   test/deb/ubuntu-trusty/Vagrantfile 3d241eb09fe5f66d78d7ff84fbcb0fe25f363b87 
>   test/deb/ubuntu-trusty/provision.sh 
> 328f44102183634e1c4c1ad459610892e07a8832 
>   test/rpm/centos-7/README.md 527fbb2e84ea5e81e96d7a7e0644186df439cabb 
>   test/rpm/centos-7/Vagrantfile 1a641667a6be7bb8ca8b189cad5d4557e8b08621 
>   test/rpm/centos-7/provision.sh 199cd43a0fd0fb814fff1d89d745fadbddbe9023 
> 
> Diff: https://reviews.apache.org/r/47647/diff/
> 
> 
> Testing
> ---
> 
> Manually followed the test instructions. Rendered versions are available here 
> https://github.com/StephanErb/aurora-packaging/tree/dedust-0.13
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 47647: Update packaging to work with Aurora 0.13.

2016-05-24 Thread John Sirois 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47647/#review134600
---


Fix it, then Ship it!




Sorry for the massive delay here!
An asynchronous ship with a few issues marked below.


test/deb/debian-jessie/README.md (line 26)


Should be `pkg_root="https://apache.bintray.com/aurora/debian-jessie/"`



test/deb/debian-jessie/provision.sh (line 13)


Is this because dpkg is used instead of `apt-get install`? This is a bit of 
a leading question since I'm pretty sure I helped Joshua out of this same jam.  
See here: 
https://github.com/apache/aurora/blob/master/build-support/packer/build.sh#L102-L110
https://reviews.apache.org/r/46786/



test/deb/ubuntu-trusty/README.md (line 26)


Should be `pkg_root="https://apache.bintray.com/aurora/ubuntu-trusty/"`



test/deb/ubuntu-trusty/provision.sh (line 13)


ditto


- John Sirois


On May 20, 2016, 10:37 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47647/
> ---
> 
> (Updated May 20, 2016, 10:37 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> In addition to the minimal necessary packaging changes, I have tried
> to align the tests of the different distributions.
> 
> A few differences remain. Those are mainly due to different defaults
> in our DEBs and RPMs. I will leave this to another commit.
> 
> 
> Diffs
> -
> 
>   build-support/virtualenv 334653bb02e18325a4fc65cc0a0f27d92e82b5c7 
>   builder/deb/debian-jessie/build.sh f122a51f88d32bc88b0113d0e2923036edf2a72a 
>   specs/debian/control 23afb2bc0fd034286851c0298cb92f752f88ea7a 
>   specs/rpm/SOURCES/aurora.sysconfig 166df4d962bae62d01036744f4a709715367ff66 
>   specs/rpm/aurora.spec d4007068f179a56fcd5526268377f5cabc73e956 
>   test/deb/debian-jessie/README.md 9be58bd452d7ef3e43c158f4c765834c7ea46ca2 
>   test/deb/debian-jessie/Vagrantfile 619b793e7a03ff4ec67f51099dc8355e7397ae64 
>   test/deb/debian-jessie/provision.sh 
> 6970279d44546d59cd1540879a659b9e14a94cd3 
>   test/deb/ubuntu-trusty/README.md ec34ef55b382cb32817ccc6f683314107c8e0b7e 
>   test/deb/ubuntu-trusty/Vagrantfile 3d241eb09fe5f66d78d7ff84fbcb0fe25f363b87 
>   test/deb/ubuntu-trusty/provision.sh 
> 328f44102183634e1c4c1ad459610892e07a8832 
>   test/rpm/centos-7/README.md 527fbb2e84ea5e81e96d7a7e0644186df439cabb 
>   test/rpm/centos-7/Vagrantfile 1a641667a6be7bb8ca8b189cad5d4557e8b08621 
>   test/rpm/centos-7/provision.sh 199cd43a0fd0fb814fff1d89d745fadbddbe9023 
> 
> Diff: https://reviews.apache.org/r/47647/diff/
> 
> 
> Testing
> ---
> 
> Manually followed the test instructions. Rendered versions are available here 
> https://github.com/StephanErb/aurora-packaging/tree/dedust-0.13
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>