Re: Review Request 47809: Generalizing resource management on the client

2016-05-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47809/#review134816 --- Ship it! Master (3cf6e4e) is green with this patch.

Re: Review Request 47809: Generalizing resource management on the client

2016-05-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47809/ --- (Updated May 25, 2016, 7:41 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 47809: Generalizing resource management on the client

2016-05-25 Thread Maxim Khutornenko
> On May 25, 2016, 6:36 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/admin/admin.py, line 225 > > > > > > We could have the same problem here (and in `get_quota_str` further > > down) as we have

Re: Review Request 47809: Generalizing resource management on the client

2016-05-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47809/#review134783 --- Ship it! Master (9f6a660) is green with this patch.

Re: Review Request 47809: Generalizing resource management on the client

2016-05-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47809/#review134780 --- @ReviewBot retry - Maxim Khutornenko On May 25, 2016, 3:58

Re: Review Request 47809: Generalizing resource management on the client

2016-05-25 Thread Maxim Khutornenko
> On May 25, 2016, 6:15 a.m., Stephan Erb wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, line 725 > > > > > > The `if r.resource_type.display_unit else ""` expression seems to be > > unused given that

Re: Review Request 47809: Generalizing resource management on the client

2016-05-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47809/#review134779 --- Master (9f6a660) is red with this patch.

Re: Review Request 47809: Generalizing resource management on the client

2016-05-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47809/ --- (Updated May 25, 2016, 3:58 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 47809: Generalizing resource management on the client

2016-05-25 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47809/#review134706 --- Ship it! LGTM. Fewer minor things below:

Re: Review Request 47809: Generalizing resource management on the client

2016-05-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47809/#review134698 --- Ship it! Master (9f6a660) is green with this patch.

Re: Review Request 47809: Generalizing resource management on the client

2016-05-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47809/#review134680 --- Master (9f6a660) is red with this patch.