Re: Review Request 47869: Adding support for GPU resource

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47869/#review135393 --- Ship it! Ship It! - Stephan Erb On May 26, 2016, 10:57 p.m.,

Re: Review Request 47869: Adding support for GPU resource

> On May 27, 2016, 2:13 p.m., Stephan Erb wrote: > > RELEASE-NOTES.md, lines 30-41 > > > > > > I am not sure if the large warning note is really necessary: > > > > The feature will only work in Mesos 0.29. Th

Re: Review Request 47869: Adding support for GPU resource

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47869/#review135245 --- Ship it! Ship It! - Joshua Cohen On May 26, 2016, 8:57 p.m.,

Re: Review Request 47869: Adding support for GPU resource

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47869/#review135236 --- RELEASE-NOTES.md (lines 30 - 41)

Re: Review Request 47869: Adding support for GPU resource

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47869/#review135069 --- Ship it! Master (b76e38f) is green with this patch. ./build-s

Re: Review Request 47869: Adding support for GPU resource

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47869/ --- (Updated May 26, 2016, 8:57 p.m.) Review request for Aurora, Joshua Cohen and S

Re: Review Request 47869: Adding support for GPU resource

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47869/#review135059 --- This patch does not apply cleanly against master (b76e38f), do you

Re: Review Request 47869: Adding support for GPU resource

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47869/ --- (Updated May 26, 2016, 8:18 p.m.) Review request for Aurora, Joshua Cohen and S

Re: Review Request 47869: Adding support for GPU resource

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47869/#review135000 --- Ship it! Master (32a8a07) is green with this patch. ./build-s

Re: Review Request 47869: Adding support for GPU resource

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47869/ --- (Updated May 26, 2016, 4:18 p.m.) Review request for Aurora, Joshua Cohen and S

Re: Review Request 47869: Adding support for GPU resource

> On May 26, 2016, 8:59 a.m., Stephan Erb wrote: > > Great to see how little code was necessary here! Your refactoring has > > really paid off. > > > > Documentation seems to be the only major missing piece: > > > > * Release notes > > * Mentioning of GPU resources here: > > https://github.co

Re: Review Request 47869: Adding support for GPU resource

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47869/#review134948 --- Great to see how little code was necessary here! Your refactoring

Re: Review Request 47869: Adding support for GPU resource

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47869/#review134895 --- Ship it! Master (32a8a07) is green with this patch. ./build-s