Re: Review Request 48513: Update rpm services to match debian

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48513/#review137142
---


Ship it!




Thanks for the patch! Looks good to me. I have verified that the packages are 
using `tests/rpm/centos-7` in the packaging repository. The docs are slightly 
out of date, but I will address this in a follow-up.


specs/rpm/aurora.spec (line 136)


Is that really a dependency of Aurora? Or is only required by Mesos?


- Stephan Erb


On June 12, 2016, 1:28 a.m., Kasisnu Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48513/
> ---
> 
> (Updated June 12, 2016, 1:28 a.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Bugs: AURORA-1394
> https://issues.apache.org/jira/browse/AURORA-1394
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Update rpm startup scripts to match deb patterns in use
> 
> 
> Diffs
> -
> 
>   specs/rpm/SOURCES/aurora.init.sh  
>   specs/rpm/SOURCES/aurora.logrotate  
>   specs/rpm/SOURCES/aurora.service  
>   specs/rpm/SOURCES/aurora.startup.sh 
> 3c444d98c4bd02a7e25b60c20bc3f6a988014046 
>   specs/rpm/SOURCES/aurora.sysconfig  
>   specs/rpm/SOURCES/thermos-observer.init.sh 
> 38eea53cd0bd5e38e379b5e4ef54482c53d79dd0 
>   specs/rpm/SOURCES/thermos-observer.logrotate  
>   specs/rpm/SOURCES/thermos-observer.service 
> d0196350883d5a15e2cc6017d27917d8bb13b1b9 
>   specs/rpm/SOURCES/thermos-observer.startup.sh 
> 2d94fd9314daa6e461f1e162a43ea965d53a904b 
>   specs/rpm/SOURCES/thermos-observer.sysconfig  
>   specs/rpm/aurora.spec a4fc46dc5241fc163a854da0b16c38e44d3be97e 
> 
> Diff: https://reviews.apache.org/r/48513/diff/
> 
> 
> Testing
> ---
> 
> Setup a fresh aurora cluster using rpms built with these changes.
> 
> 
> Tickets covered: AURORA-1394
> 
> Is a rebase of https://reviews.apache.org/r/40877/
> 
> 
> Thanks,
> 
> Kasisnu Singh
> 
>

Re: Review Request 48513: Update rpm services to match debian

[Kasisnu Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48513/
---

(Updated June 12, 2016, 1:28 a.m.)


Review request for Aurora and Stephan Erb.


Bugs: AURORA-1394
https://issues.apache.org/jira/browse/AURORA-1394


Repository: aurora-packaging


Description
---

Update rpm startup scripts to match deb patterns in use


Diffs
-

  specs/rpm/SOURCES/aurora.init.sh  
  specs/rpm/SOURCES/aurora.logrotate  
  specs/rpm/SOURCES/aurora.service  
  specs/rpm/SOURCES/aurora.startup.sh 3c444d98c4bd02a7e25b60c20bc3f6a988014046 
  specs/rpm/SOURCES/aurora.sysconfig  
  specs/rpm/SOURCES/thermos-observer.init.sh 
38eea53cd0bd5e38e379b5e4ef54482c53d79dd0 
  specs/rpm/SOURCES/thermos-observer.logrotate  
  specs/rpm/SOURCES/thermos-observer.service 
d0196350883d5a15e2cc6017d27917d8bb13b1b9 
  specs/rpm/SOURCES/thermos-observer.startup.sh 
2d94fd9314daa6e461f1e162a43ea965d53a904b 
  specs/rpm/SOURCES/thermos-observer.sysconfig  
  specs/rpm/aurora.spec a4fc46dc5241fc163a854da0b16c38e44d3be97e 

Diff: https://reviews.apache.org/r/48513/diff/


Testing
---

Setup a fresh aurora cluster using rpms built with these changes.


Tickets covered: AURORA-1394

Is a rebase of https://reviews.apache.org/r/40877/


Thanks,

Kasisnu Singh