Re: Review Request 48796: AURORA-1458 Add tier into the UI "show config" summary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48796/#review138871 --- Ship it! Ship It! - Maxim Khutornenko On June 16, 2016, 4:21 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48796/ > --- > > (Updated June 16, 2016, 4:21 p.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Repository: aurora > > > Description > --- > > AURORA-1458 Add tier into the UI "show config" summary > > > Diffs > - > > src/main/resources/scheduler/assets/configSummary.html > 86a87ab710312969c31802492d856b04f07c276d > src/main/resources/scheduler/assets/js/services.js > b3a0a994707972a9a19a7f4079dad67fe3136c1c > > Diff: https://reviews.apache.org/r/48796/diff/ > > > Testing > --- > > ``` > ./build-support/jenkins/build.sh > > + date > Thu Jun 16 08:57:08 PDT 2016 > + ./gradlew -Pq clean build > > ... > > 09:03:14 00:03 [complete] >SUCCESS > ``` > > > Thanks, > > Mehrdad Nurolahzade > >
Re: Review Request 48796: AURORA-1458 Add tier into the UI "show config" summary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48796/#review138027 --- LGTM. Holding off on shipping it until https://reviews.apache.org/r/48559/ lands as it's more logical to expose 'tier' in the UI when it's required. - Maxim Khutornenko On June 16, 2016, 4:21 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48796/ > --- > > (Updated June 16, 2016, 4:21 p.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Repository: aurora > > > Description > --- > > AURORA-1458 Add tier into the UI "show config" summary > > > Diffs > - > > src/main/resources/scheduler/assets/configSummary.html > 86a87ab710312969c31802492d856b04f07c276d > src/main/resources/scheduler/assets/js/services.js > b3a0a994707972a9a19a7f4079dad67fe3136c1c > > Diff: https://reviews.apache.org/r/48796/diff/ > > > Testing > --- > > ``` > ./build-support/jenkins/build.sh > > + date > Thu Jun 16 08:57:08 PDT 2016 > + ./gradlew -Pq clean build > > ... > > 09:03:14 00:03 [complete] >SUCCESS > ``` > > > Thanks, > > Mehrdad Nurolahzade > >
Re: Review Request 48796: AURORA-1458 Add tier into the UI "show config" summary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48796/#review138011 --- Master (f9bbfb3) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On June 16, 2016, 4:21 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48796/ > --- > > (Updated June 16, 2016, 4:21 p.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Repository: aurora > > > Description > --- > > AURORA-1458 Add tier into the UI "show config" summary > > > Diffs > - > > src/main/resources/scheduler/assets/configSummary.html > 86a87ab710312969c31802492d856b04f07c276d > src/main/resources/scheduler/assets/js/services.js > b3a0a994707972a9a19a7f4079dad67fe3136c1c > > Diff: https://reviews.apache.org/r/48796/diff/ > > > Testing > --- > > ``` > ./build-support/jenkins/build.sh > > + date > Thu Jun 16 08:57:08 PDT 2016 > + ./gradlew -Pq clean build > > ... > > 09:03:14 00:03 [complete] >SUCCESS > ``` > > > Thanks, > > Mehrdad Nurolahzade > >
