Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-25 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review143393 --- Ship it! Ship It! - Joshua Cohen On July 25, 2016, 4:25

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-25 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/ --- (Updated July 25, 2016, 9:25 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-25 Thread Joshua Cohen
> On July 25, 2016, 3:55 p.m., Joshua Cohen wrote: > > RELEASE-NOTES.md, line 20 > > > > > > Given that tier names are configurable by Aurora operators, should we > > word this differently? > > Mehrdad

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-25 Thread Mehrdad Nurolahzade
> On July 25, 2016, 8:55 a.m., Joshua Cohen wrote: > > RELEASE-NOTES.md, line 20 > > > > > > Given that tier names are configurable by Aurora operators, should we > > word this differently? Better? The job

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review143389 --- Ship it! Master (9c316d3) is green with this patch.

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-25 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review143388 --- @ReviewBot retry - Joshua Cohen On July 25, 2016, 3:30 p.m.,

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-25 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review143387 --- Ship it! Below is not a blocker for me. RELEASE-NOTES.md

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review143386 --- Master (9c316d3) is red with this patch.

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-25 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/ --- (Updated July 25, 2016, 8:30 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-25 Thread Joshua Cohen
> On July 23, 2016, 5:13 p.m., Stephan Erb wrote: > > LGTM! > > > > Minor missing things: > > > > * deprecation notice for the user-facing configuration option > > * rebase > > > > > > Joshua, would be great if you could land this patch once its done. I am > > gone for the week & without

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review143319 --- Ship it! LGTM! Minor missing things: * deprecation notice

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-23 Thread Stephan Erb
> On July 20, 2016, 12:27 a.m., Stephan Erb wrote: > > RELEASE-NOTES.md, line 13 > > > > > > Maybe add here explicitly that `production` is deprecated and that > > people should use `tier='preferred'` instead. > >

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-20 Thread Mehrdad Nurolahzade
> On July 19, 2016, 3:27 p.m., Stephan Erb wrote: > > src/test/python/apache/aurora/client/cli/test_cron.py, line 111 > > > > > > As an example of many similar test changes: > > > > The additional mock

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-20 Thread Mehrdad Nurolahzade
> On July 19, 2016, 3:27 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/client/cli/context.py, line 143 > > > > > > Side stepping the `get_config` factory and re-creating the > > `AnnotatedAuroraConfig`

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-20 Thread Mehrdad Nurolahzade
> On July 19, 2016, 3:27 p.m., Stephan Erb wrote: > > RELEASE-NOTES.md, line 13 > > > > > > Maybe add here explicitly that `production` is deprecated and that > > people should use `tier='preferred'` instead. > >

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-19 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review142828 --- I think both my documentation comments are somewhat necessary.

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-19 Thread Mehrdad Nurolahzade
> On July 19, 2016, 12:23 p.m., Stephan Erb wrote: > > What's the status here? Waiting for additional review after the fix? Yes, this board has been waiting for some love quite a while. - Mehrdad --- This is an automatically generated

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-19 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review142810 --- What's the status here? Waiting for additional review after the

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review142688 --- Ship it! Master (e67c6a7) is green with this patch.

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-18 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review142681 --- @ReviewBot retry - Mehrdad Nurolahzade On July 8, 2016, 4:15

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review141710 --- Ship it! Master (c41420f) is green with this patch.

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-11 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review141698 --- @ReviewBot retry - Mehrdad Nurolahzade On July 8, 2016, 4:15

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review141361 --- Master (528198e) is red with this patch.

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-08 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/ --- (Updated July 8, 2016, 4:15 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review141331 --- Master (70d0ef2) is red with this patch.

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-08 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review141329 --- @ReviewBot retry - Mehrdad Nurolahzade On July 8, 2016, 1:12

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review141327 --- Master (70d0ef2) is red with this patch.

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-08 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/ --- (Updated July 8, 2016, 1:12 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-08 Thread Mehrdad Nurolahzade
> On June 28, 2016, 8:39 p.m., Joshua Cohen wrote: > > > > Mehrdad Nurolahzade wrote: > Should this be merged with upstream now that 0.15 is released? > > Joshua Cohen wrote: > Yes, we can land this now. Would you mind rebasing? Then I can commit it. Alright, running tests locally

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-08 Thread Joshua Cohen
> On June 29, 2016, 3:39 a.m., Joshua Cohen wrote: > > > > Mehrdad Nurolahzade wrote: > Should this be merged with upstream now that 0.15 is released? Yes, we can land this now. Would you mind rebasing? Then I can commit it. - Joshua

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-07-08 Thread Mehrdad Nurolahzade
> On June 28, 2016, 8:39 p.m., Joshua Cohen wrote: > > Should this be merged with upstream now that 0.15 is released? - Mehrdad --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review139923 --- Ship it! - Joshua Cohen On June 28, 2016, 11:57 p.m.,

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/ --- (Updated June 28, 2016, 4:57 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review139828 --- Ship it! Master (73dd2a8) is green with this patch.

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/ --- (Updated June 28, 2016, 10:28 a.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Mehrdad Nurolahzade
> On June 28, 2016, 10:02 a.m., Aurora ReviewBot wrote: > > Master (73dd2a8) is red with this patch. > > ./build-support/jenkins/build.sh > > > > > > src/test/python/apache/thermos/common/test_planner.py::test_planner_empty > > PASSED > >

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review139819 --- Master (73dd2a8) is red with this patch.

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review139818 --- Fix it, then Ship it!

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-28 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/ --- (Updated June 28, 2016, 9:51 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-27 Thread Mehrdad Nurolahzade
> On June 27, 2016, 11:31 a.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/context.py, lines 129-130 > > > > > > Can you simplify this as: > > ``` > > return not

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-27 Thread Maxim Khutornenko
> On June 27, 2016, 6:31 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/context.py, lines 129-130 > > > > > > Can you simplify this as: > > ``` > > return not

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-27 Thread Mehrdad Nurolahzade
> On June 27, 2016, 11:31 a.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/config.py, line 118 > > > > > > Please, add a link to our docs for more info: > >

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-27 Thread Mehrdad Nurolahzade
> On June 27, 2016, 11:31 a.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/context.py, lines 129-130 > > > > > > Can you simplify this as: > > ``` > > return not

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review139597 --- src/main/python/apache/aurora/client/api/__init__.py (line 298)

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review139598 --- Ship it! Master (73dd2a8) is green with this patch.

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review139589 --- Master (73dd2a8) is red with this patch.

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-24 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review139407 --- Just some style stuff.

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review139305 --- Ship it! Master (73dd2a8) is green with this patch.

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-23 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review139304 --- src/main/python/apache/aurora/config/__init__.py (line 15)

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-23 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/ --- (Updated June 23, 2016, 3:35 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review138975 --- Ship it! Master (73dd2a8) is green with this patch.

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-21 Thread Mehrdad Nurolahzade
> On June 21, 2016, 4:02 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/config/thrift.py, lines 231-258 > > > > > > A better place for this would be `get_job_config()` in > >

Re: Review Request 49048: AURORA-1710 Make 'tier' required and remove support for 'production' flag in Job configuration - CLI changes

2016-06-21 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/ --- (Updated June 21, 2016, 4:09 p.m.) Review request for Aurora, Joshua Cohen and