Re: Review Request 49478: Fixing e2e tests failing due to mesos-slave state.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49478/#review140289 --- Ship it! Ship It! - Joshua Cohen On June 30, 2016, 11:29 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49478/ > --- > > (Updated June 30, 2016, 11:29 p.m.) > > > Review request for Aurora and Joshua Cohen. > > > Repository: aurora > > > Description > --- > > Removing slave.info that is written any time a vagrant box restarts. This > includes the base image building as well as when the vagrant box is created > before the provisioning scripts are applied. > > Here is the relevant change on mesos side that causes it: > https://github.com/mesosphere/mesos-deb-packaging/commit/e05426acdedfec905b3895c5350e36c6a6590e42 > > > Diffs > - > > build-support/packer/README.md b3570adbe8018952d8a9fcec9911269f5639136e > examples/vagrant/provision-dev-cluster.sh > b1f661ea90ac427621518f653cce1b7630d2a6ed > > Diff: https://reviews.apache.org/r/49478/diff/ > > > Testing > --- > > > Thanks, > > Maxim Khutornenko > >
Re: Review Request 49478: Fixing e2e tests failing due to mesos-slave state.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49478/#review140275 --- Ship it! Master (be2174b) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On June 30, 2016, 11:29 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49478/ > --- > > (Updated June 30, 2016, 11:29 p.m.) > > > Review request for Aurora and Joshua Cohen. > > > Repository: aurora > > > Description > --- > > Removing slave.info that is written any time a vagrant box restarts. This > includes the base image building as well as when the vagrant box is created > before the provisioning scripts are applied. > > Here is the relevant change on mesos side that causes it: > https://github.com/mesosphere/mesos-deb-packaging/commit/e05426acdedfec905b3895c5350e36c6a6590e42 > > > Diffs > - > > build-support/packer/README.md b3570adbe8018952d8a9fcec9911269f5639136e > examples/vagrant/provision-dev-cluster.sh > b1f661ea90ac427621518f653cce1b7630d2a6ed > > Diff: https://reviews.apache.org/r/49478/diff/ > > > Testing > --- > > > Thanks, > > Maxim Khutornenko > >
Re: Review Request 49478: Fixing e2e tests failing due to mesos-slave state.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49478/ --- (Updated June 30, 2016, 11:29 p.m.) Review request for Aurora and Joshua Cohen. Changes --- Removed spaces and moved rm after stopping slave. Repository: aurora Description --- Removing slave.info that is written any time a vagrant box restarts. This includes the base image building as well as when the vagrant box is created before the provisioning scripts are applied. Here is the relevant change on mesos side that causes it: https://github.com/mesosphere/mesos-deb-packaging/commit/e05426acdedfec905b3895c5350e36c6a6590e42 Diffs (updated) - build-support/packer/README.md b3570adbe8018952d8a9fcec9911269f5639136e examples/vagrant/provision-dev-cluster.sh b1f661ea90ac427621518f653cce1b7630d2a6ed Diff: https://reviews.apache.org/r/49478/diff/ Testing --- Thanks, Maxim Khutornenko
Re: Review Request 49478: Fixing e2e tests failing due to mesos-slave state.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49478/#review140267 --- Master (be2174b) is red with this patch. ./build-support/jenkins/build.sh [1m with temporary_dir() as checkpoint_root:[0m [1mte = AuroraExecutor([0m [1m> runner_provider=make_provider(checkpoint_root),[0m [1m sandbox_provider=DefaultTestSandboxProvider())[0m src/test/python/apache/aurora/executor/test_thermos_executor.py:580: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in make_provider [1mpex_location=thermos_runner_path(),[0m _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ build = True [1mdef thermos_runner_path(build=True):[0m [1m if not build:[0m [1mreturn getattr(thermos_runner_path, 'value', None)[0m [1m[0m [1m if not hasattr(thermos_runner_path, 'value'):[0m [1mpex_dir = safe_mkdtemp()[0m [1m> assert subprocess.call(["./pants", "--pants-distdir=%s" % pex_dir, "binary",[0m [1m "src/main/python/apache/thermos/runner:thermos_runner"]) == 0[0m [1m[31mE assert 1 == 0[0m [1m[31mE+ where 1 = (['./pants', '--pants-distdir=/tmp/user/10021/tmpvyKaKZ', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])[0m [1m[31mE+where = subprocess.call[0m src/test/python/apache/aurora/executor/test_thermos_executor.py:185: AssertionError -- Captured stderr call -- Traceback (most recent call last): File "/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.80/bin/pants", line 7, in from pants.bin.pants_exe import main ImportError: No module named pants.bin.pants_exe generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml [1m[31m 16 failed, 638 passed, 6 skipped, 1 warnings, 8 error in 102.35 seconds [0m FAILURE [32m Waiting for background workers to finish.[0m 23:24:28 02:26 [complete][31m FAILURE[0m I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On June 30, 2016, 11:15 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49478/ > --- > > (Updated June 30, 2016, 11:15 p.m.) > > > Review request for Aurora and Joshua Cohen. > > > Repository: aurora > > > Description > --- > > Removing slave.info that is written any time a vagrant box restarts. This > includes the base image building as well as when the vagrant box is created > before the provisioning scripts are applied. > > Here is the relevant change on mesos side that causes it: > https://github.com/mesosphere/mesos-deb-packaging/commit/e05426acdedfec905b3895c5350e36c6a6590e42 > > > Diffs > - > > build-support/packer/README.md b3570adbe8018952d8a9fcec9911269f5639136e > examples/vagrant/provision-dev-cluster.sh > b1f661ea90ac427621518f653cce1b7630d2a6ed > > Diff: https://reviews.apache.org/r/49478/diff/ > > > Testing > --- > > > Thanks, > > Maxim Khutornenko > >
