Re: Review Request 50819: Use update_job instead of creating new config object when modifying.
> On Aug. 29, 2016, 11:01 a.m., Stephan Erb wrote: > > @ReviewBot retry Seems like this was already merged: [https://github.com/apache/aurora/commit/ec3591c812b4f7a063b3f5ee54ac66a9a4c5048b] - Mehrdad --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50819/#review147171 --- On Aug. 4, 2016, 2:10 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50819/ > --- > > (Updated Aug. 4, 2016, 2:10 p.m.) > > > Review request for Aurora and Mehrdad Nurolahzade. > > > Repository: aurora > > > Description > --- > > Use update_job instead of creating new config object when modifying. This > avoids losing any state (e.g. metadata) attached to the config. > > > Diffs > - > > src/main/python/apache/aurora/client/cli/context.py > 7bbfb5e815b2408b8ddaaeeb9911a5bd1b019a27 > > Diff: https://reviews.apache.org/r/50819/diff/ > > > Testing > --- > > $ ./pants test.pytest src/test/python/apache/aurora/client:: > > 14:07:19 00:00 [main] >(To run a reporting server: ./pants server) > 14:07:19 00:00 [setup] > 14:07:19 00:00 [parse] >Executing tasks in goals: test > 14:07:19 00:00 [test] > 14:07:19 00:00 [test-prep-command] > 14:07:19 00:00 [test] > 14:07:19 00:00 [pytest] > 14:07:19 00:00 [run] > > 14:07:19 00:00 [chroot]== test session starts > === > platform darwin -- Python 2.7.10 -- py-1.4.31 -- > pytest-2.6.4 > plugins: timeout, cov > collected 339 items > > > src/test/python/apache/aurora/client/cli/test_config_noun.py ... > src/test/python/apache/aurora/client/cli/test_context.py > > src/test/python/apache/aurora/client/cli/test_version.py > . > src/test/python/apache/aurora/client/cli/test_quota.py > . > src/test/python/apache/aurora/client/cli/test_plugins.py > . > src/test/python/apache/aurora/client/cli/test_client.py > .. > src/test/python/apache/aurora/client/cli/test_sla.py > . > src/test/python/apache/aurora/client/cli/test_open.py > . > src/test/python/apache/aurora/client/cli/test_supdate.py > . > src/test/python/apache/aurora/client/cli/test_restart.py > .. > src/test/python/apache/aurora/client/cli/test_status.py > . > src/test/python/apache/aurora/client/cli/test_add.py > src/test/python/apache/aurora/client/cli/test_diff.py .. > src/test/python/apache/aurora/client/cli/test_cron.py > .. > > src/test/python/apache/aurora/client/cli/test_command_hooks.py .. > src/test/python/apache/aurora/client/cli/test_options.py > .. > src/test/python/apache/aurora/client/cli/test_task.py > . > src/test/python/apache/aurora/client/cli/test_create.py > .. > src/test/python/apache/aurora/client/cli/test_kill.py > . > src/test/python/apache/aurora/client/cli/test_inspect.py > ... > > src/test/python/apache/aurora/client/cli/test_api_from_cli.py .. > > src/test/python/apache/aurora/client/cli/test_diff_formatter.py . > > src/test/python/apache/aurora/client/api/test_updater_util.py ... > > src/test/python/apache/aurora/client/api/test_job_monitor.py .. > src/test/python/apache/aurora/client/api/test_api.py > .. > > src/test/python/apache/aurora/client/api/test_task_util.py . > > src/test/python/apache/aurora/client/api/test_restarter.py .. > > src/test/python/apache/aurora/client/api/test_instance_watcher.py .. > > src/test/python/apache/aurora/client/api/test_scheduler_client.py > . > src/test/python/apache/aurora/client/api/test_sla.py > .. > > src/test/python/apache/aurora/client/api/test_health_check.py ... > > src/test/python/apache/aurora/client/hooks/test_hooked_api.py >
Re: Review Request 50819: Use update_job instead of creating new config object when modifying.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50819/#review147181 --- Master (56906a7) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Aug. 4, 2016, 9:10 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50819/ > --- > > (Updated Aug. 4, 2016, 9:10 p.m.) > > > Review request for Aurora and Mehrdad Nurolahzade. > > > Repository: aurora > > > Description > --- > > Use update_job instead of creating new config object when modifying. This > avoids losing any state (e.g. metadata) attached to the config. > > > Diffs > - > > src/main/python/apache/aurora/client/cli/context.py > 7bbfb5e815b2408b8ddaaeeb9911a5bd1b019a27 > > Diff: https://reviews.apache.org/r/50819/diff/ > > > Testing > --- > > $ ./pants test.pytest src/test/python/apache/aurora/client:: > > 14:07:19 00:00 [main] >(To run a reporting server: ./pants server) > 14:07:19 00:00 [setup] > 14:07:19 00:00 [parse] >Executing tasks in goals: test > 14:07:19 00:00 [test] > 14:07:19 00:00 [test-prep-command] > 14:07:19 00:00 [test] > 14:07:19 00:00 [pytest] > 14:07:19 00:00 [run] > > 14:07:19 00:00 [chroot]== test session starts > === > platform darwin -- Python 2.7.10 -- py-1.4.31 -- > pytest-2.6.4 > plugins: timeout, cov > collected 339 items > > > src/test/python/apache/aurora/client/cli/test_config_noun.py ... > src/test/python/apache/aurora/client/cli/test_context.py > > src/test/python/apache/aurora/client/cli/test_version.py > . > src/test/python/apache/aurora/client/cli/test_quota.py > . > src/test/python/apache/aurora/client/cli/test_plugins.py > . > src/test/python/apache/aurora/client/cli/test_client.py > .. > src/test/python/apache/aurora/client/cli/test_sla.py > . > src/test/python/apache/aurora/client/cli/test_open.py > . > src/test/python/apache/aurora/client/cli/test_supdate.py > . > src/test/python/apache/aurora/client/cli/test_restart.py > .. > src/test/python/apache/aurora/client/cli/test_status.py > . > src/test/python/apache/aurora/client/cli/test_add.py > src/test/python/apache/aurora/client/cli/test_diff.py .. > src/test/python/apache/aurora/client/cli/test_cron.py > .. > > src/test/python/apache/aurora/client/cli/test_command_hooks.py .. > src/test/python/apache/aurora/client/cli/test_options.py > .. > src/test/python/apache/aurora/client/cli/test_task.py > . > src/test/python/apache/aurora/client/cli/test_create.py > .. > src/test/python/apache/aurora/client/cli/test_kill.py > . > src/test/python/apache/aurora/client/cli/test_inspect.py > ... > > src/test/python/apache/aurora/client/cli/test_api_from_cli.py .. > > src/test/python/apache/aurora/client/cli/test_diff_formatter.py . > > src/test/python/apache/aurora/client/api/test_updater_util.py ... > > src/test/python/apache/aurora/client/api/test_job_monitor.py .. > src/test/python/apache/aurora/client/api/test_api.py > .. > > src/test/python/apache/aurora/client/api/test_task_util.py . > > src/test/python/apache/aurora/client/api/test_restarter.py .. > > src/test/python/apache/aurora/client/api/test_instance_watcher.py .. > > src/test/python/apache/aurora/client/api/test_scheduler_client.py > . > src/test/python/apache/aurora/client/api/test_sla.py > .. > > src/test/python/apache/aurora/client/api/test_health_check.py ... > > src/test/python/apache/aurora/client/hooks/test_hooked_api.py
Re: Review Request 50819: Use update_job instead of creating new config object when modifying.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50819/#review147171 --- @ReviewBot retry - Stephan Erb On Aug. 4, 2016, 11:10 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50819/ > --- > > (Updated Aug. 4, 2016, 11:10 p.m.) > > > Review request for Aurora and Mehrdad Nurolahzade. > > > Repository: aurora > > > Description > --- > > Use update_job instead of creating new config object when modifying. This > avoids losing any state (e.g. metadata) attached to the config. > > > Diffs > - > > src/main/python/apache/aurora/client/cli/context.py > 7bbfb5e815b2408b8ddaaeeb9911a5bd1b019a27 > > Diff: https://reviews.apache.org/r/50819/diff/ > > > Testing > --- > > $ ./pants test.pytest src/test/python/apache/aurora/client:: > > 14:07:19 00:00 [main] >(To run a reporting server: ./pants server) > 14:07:19 00:00 [setup] > 14:07:19 00:00 [parse] >Executing tasks in goals: test > 14:07:19 00:00 [test] > 14:07:19 00:00 [test-prep-command] > 14:07:19 00:00 [test] > 14:07:19 00:00 [pytest] > 14:07:19 00:00 [run] > > 14:07:19 00:00 [chroot]== test session starts > === > platform darwin -- Python 2.7.10 -- py-1.4.31 -- > pytest-2.6.4 > plugins: timeout, cov > collected 339 items > > > src/test/python/apache/aurora/client/cli/test_config_noun.py ... > src/test/python/apache/aurora/client/cli/test_context.py > > src/test/python/apache/aurora/client/cli/test_version.py > . > src/test/python/apache/aurora/client/cli/test_quota.py > . > src/test/python/apache/aurora/client/cli/test_plugins.py > . > src/test/python/apache/aurora/client/cli/test_client.py > .. > src/test/python/apache/aurora/client/cli/test_sla.py > . > src/test/python/apache/aurora/client/cli/test_open.py > . > src/test/python/apache/aurora/client/cli/test_supdate.py > . > src/test/python/apache/aurora/client/cli/test_restart.py > .. > src/test/python/apache/aurora/client/cli/test_status.py > . > src/test/python/apache/aurora/client/cli/test_add.py > src/test/python/apache/aurora/client/cli/test_diff.py .. > src/test/python/apache/aurora/client/cli/test_cron.py > .. > > src/test/python/apache/aurora/client/cli/test_command_hooks.py .. > src/test/python/apache/aurora/client/cli/test_options.py > .. > src/test/python/apache/aurora/client/cli/test_task.py > . > src/test/python/apache/aurora/client/cli/test_create.py > .. > src/test/python/apache/aurora/client/cli/test_kill.py > . > src/test/python/apache/aurora/client/cli/test_inspect.py > ... > > src/test/python/apache/aurora/client/cli/test_api_from_cli.py .. > > src/test/python/apache/aurora/client/cli/test_diff_formatter.py . > > src/test/python/apache/aurora/client/api/test_updater_util.py ... > > src/test/python/apache/aurora/client/api/test_job_monitor.py .. > src/test/python/apache/aurora/client/api/test_api.py > .. > > src/test/python/apache/aurora/client/api/test_task_util.py . > > src/test/python/apache/aurora/client/api/test_restarter.py .. > > src/test/python/apache/aurora/client/api/test_instance_watcher.py .. > > src/test/python/apache/aurora/client/api/test_scheduler_client.py > . > src/test/python/apache/aurora/client/api/test_sla.py > .. > > src/test/python/apache/aurora/client/api/test_health_check.py ... > > src/test/python/apache/aurora/client/hooks/test_hooked_api.py > > src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ... > src/test/python/apache/aurora/client/test_config.py > >
Re: Review Request 50819: Use update_job instead of creating new config object when modifying.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50819/#review144955 --- Given that this sneaked past our test coverage, do you see an easy way how to add a test for that? - Stephan Erb On Aug. 4, 2016, 11:10 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50819/ > --- > > (Updated Aug. 4, 2016, 11:10 p.m.) > > > Review request for Aurora and Mehrdad Nurolahzade. > > > Repository: aurora > > > Description > --- > > Use update_job instead of creating new config object when modifying. This > avoids losing any state (e.g. metadata) attached to the config. > > > Diffs > - > > src/main/python/apache/aurora/client/cli/context.py > 7bbfb5e815b2408b8ddaaeeb9911a5bd1b019a27 > > Diff: https://reviews.apache.org/r/50819/diff/ > > > Testing > --- > > $ ./pants test.pytest src/test/python/apache/aurora/client:: > > 14:07:19 00:00 [main] >(To run a reporting server: ./pants server) > 14:07:19 00:00 [setup] > 14:07:19 00:00 [parse] >Executing tasks in goals: test > 14:07:19 00:00 [test] > 14:07:19 00:00 [test-prep-command] > 14:07:19 00:00 [test] > 14:07:19 00:00 [pytest] > 14:07:19 00:00 [run] > > 14:07:19 00:00 [chroot]== test session starts > === > platform darwin -- Python 2.7.10 -- py-1.4.31 -- > pytest-2.6.4 > plugins: timeout, cov > collected 339 items > > > src/test/python/apache/aurora/client/cli/test_config_noun.py ... > src/test/python/apache/aurora/client/cli/test_context.py > > src/test/python/apache/aurora/client/cli/test_version.py > . > src/test/python/apache/aurora/client/cli/test_quota.py > . > src/test/python/apache/aurora/client/cli/test_plugins.py > . > src/test/python/apache/aurora/client/cli/test_client.py > .. > src/test/python/apache/aurora/client/cli/test_sla.py > . > src/test/python/apache/aurora/client/cli/test_open.py > . > src/test/python/apache/aurora/client/cli/test_supdate.py > . > src/test/python/apache/aurora/client/cli/test_restart.py > .. > src/test/python/apache/aurora/client/cli/test_status.py > . > src/test/python/apache/aurora/client/cli/test_add.py > src/test/python/apache/aurora/client/cli/test_diff.py .. > src/test/python/apache/aurora/client/cli/test_cron.py > .. > > src/test/python/apache/aurora/client/cli/test_command_hooks.py .. > src/test/python/apache/aurora/client/cli/test_options.py > .. > src/test/python/apache/aurora/client/cli/test_task.py > . > src/test/python/apache/aurora/client/cli/test_create.py > .. > src/test/python/apache/aurora/client/cli/test_kill.py > . > src/test/python/apache/aurora/client/cli/test_inspect.py > ... > > src/test/python/apache/aurora/client/cli/test_api_from_cli.py .. > > src/test/python/apache/aurora/client/cli/test_diff_formatter.py . > > src/test/python/apache/aurora/client/api/test_updater_util.py ... > > src/test/python/apache/aurora/client/api/test_job_monitor.py .. > src/test/python/apache/aurora/client/api/test_api.py > .. > > src/test/python/apache/aurora/client/api/test_task_util.py . > > src/test/python/apache/aurora/client/api/test_restarter.py .. > > src/test/python/apache/aurora/client/api/test_instance_watcher.py .. > > src/test/python/apache/aurora/client/api/test_scheduler_client.py > . > src/test/python/apache/aurora/client/api/test_sla.py > .. > > src/test/python/apache/aurora/client/api/test_health_check.py ... > > src/test/python/apache/aurora/client/hooks/test_hooked_api.py > > src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ... >
Re: Review Request 50819: Use update_job instead of creating new config object when modifying.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50819/#review144830 --- Master (ec3591c) is red with this patch. ./build-support/jenkins/build.sh [1m proxy_driver = ProxyDriver()[0m [1m with temporary_dir() as checkpoint_root:[0m [1mte = AuroraExecutor([0m [1m> runner_provider=make_provider(checkpoint_root),[0m [1m sandbox_provider=DefaultTestSandboxProvider())[0m src/test/python/apache/aurora/executor/test_thermos_executor.py:580: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in make_provider [1mpex_location=thermos_runner_path(),[0m _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ build = True [1mdef thermos_runner_path(build=True):[0m [1m if not build:[0m [1mreturn getattr(thermos_runner_path, 'value', None)[0m [1m[0m [1m if not hasattr(thermos_runner_path, 'value'):[0m [1mpex_dir = safe_mkdtemp()[0m [1m> assert subprocess.call(["./pants", "--pants-distdir=%s" % pex_dir, "binary",[0m [1m "src/main/python/apache/thermos/runner:thermos_runner"]) == 0[0m [1m[31mE assert 1 == 0[0m [1m[31mE+ where 1 = (['./pants', '--pants-distdir=/tmp/tmpZnVVrK', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])[0m [1m[31mE+where = subprocess.call[0m src/test/python/apache/aurora/executor/test_thermos_executor.py:185: AssertionError -- Captured stderr call -- Traceback (most recent call last): File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/1.1.0-rc7/bin/pants", line 7, in from pants.bin.pants_exe import main ImportError: No module named pants.bin.pants_exe generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml [1m[31m 16 failed, 661 passed, 6 skipped, 1 warnings, 8 error in 147.97 seconds [0m FAILURE 21:33:59 02:52 [complete][31m FAILURE[0m I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Aug. 4, 2016, 9:10 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50819/ > --- > > (Updated Aug. 4, 2016, 9:10 p.m.) > > > Review request for Aurora and Mehrdad Nurolahzade. > > > Repository: aurora > > > Description > --- > > Use update_job instead of creating new config object when modifying. This > avoids losing any state (e.g. metadata) attached to the config. > > > Diffs > - > > src/main/python/apache/aurora/client/cli/context.py > 7bbfb5e815b2408b8ddaaeeb9911a5bd1b019a27 > > Diff: https://reviews.apache.org/r/50819/diff/ > > > Testing > --- > > $ ./pants test.pytest src/test/python/apache/aurora/client:: > > 14:07:19 00:00 [main] >(To run a reporting server: ./pants server) > 14:07:19 00:00 [setup] > 14:07:19 00:00 [parse] >Executing tasks in goals: test > 14:07:19 00:00 [test] > 14:07:19 00:00 [test-prep-command] > 14:07:19 00:00 [test] > 14:07:19 00:00 [pytest] > 14:07:19 00:00 [run] > > 14:07:19 00:00 [chroot]== test session starts > === > platform darwin -- Python 2.7.10 -- py-1.4.31 -- > pytest-2.6.4 > plugins: timeout, cov > collected 339 items > > > src/test/python/apache/aurora/client/cli/test_config_noun.py ... > src/test/python/apache/aurora/client/cli/test_context.py > > src/test/python/apache/aurora/client/cli/test_version.py > . > src/test/python/apache/aurora/client/cli/test_quota.py > . >
Re: Review Request 50819: Use update_job instead of creating new config object when modifying.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50819/#review144825 --- @ReviewBot retry - David McLaughlin On Aug. 4, 2016, 9:10 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50819/ > --- > > (Updated Aug. 4, 2016, 9:10 p.m.) > > > Review request for Aurora and Mehrdad Nurolahzade. > > > Repository: aurora > > > Description > --- > > Use update_job instead of creating new config object when modifying. This > avoids losing any state (e.g. metadata) attached to the config. > > > Diffs > - > > src/main/python/apache/aurora/client/cli/context.py > 7bbfb5e815b2408b8ddaaeeb9911a5bd1b019a27 > > Diff: https://reviews.apache.org/r/50819/diff/ > > > Testing > --- > > $ ./pants test.pytest src/test/python/apache/aurora/client:: > > 14:07:19 00:00 [main] >(To run a reporting server: ./pants server) > 14:07:19 00:00 [setup] > 14:07:19 00:00 [parse] >Executing tasks in goals: test > 14:07:19 00:00 [test] > 14:07:19 00:00 [test-prep-command] > 14:07:19 00:00 [test] > 14:07:19 00:00 [pytest] > 14:07:19 00:00 [run] > > 14:07:19 00:00 [chroot]== test session starts > === > platform darwin -- Python 2.7.10 -- py-1.4.31 -- > pytest-2.6.4 > plugins: timeout, cov > collected 339 items > > > src/test/python/apache/aurora/client/cli/test_config_noun.py ... > src/test/python/apache/aurora/client/cli/test_context.py > > src/test/python/apache/aurora/client/cli/test_version.py > . > src/test/python/apache/aurora/client/cli/test_quota.py > . > src/test/python/apache/aurora/client/cli/test_plugins.py > . > src/test/python/apache/aurora/client/cli/test_client.py > .. > src/test/python/apache/aurora/client/cli/test_sla.py > . > src/test/python/apache/aurora/client/cli/test_open.py > . > src/test/python/apache/aurora/client/cli/test_supdate.py > . > src/test/python/apache/aurora/client/cli/test_restart.py > .. > src/test/python/apache/aurora/client/cli/test_status.py > . > src/test/python/apache/aurora/client/cli/test_add.py > src/test/python/apache/aurora/client/cli/test_diff.py .. > src/test/python/apache/aurora/client/cli/test_cron.py > .. > > src/test/python/apache/aurora/client/cli/test_command_hooks.py .. > src/test/python/apache/aurora/client/cli/test_options.py > .. > src/test/python/apache/aurora/client/cli/test_task.py > . > src/test/python/apache/aurora/client/cli/test_create.py > .. > src/test/python/apache/aurora/client/cli/test_kill.py > . > src/test/python/apache/aurora/client/cli/test_inspect.py > ... > > src/test/python/apache/aurora/client/cli/test_api_from_cli.py .. > > src/test/python/apache/aurora/client/cli/test_diff_formatter.py . > > src/test/python/apache/aurora/client/api/test_updater_util.py ... > > src/test/python/apache/aurora/client/api/test_job_monitor.py .. > src/test/python/apache/aurora/client/api/test_api.py > .. > > src/test/python/apache/aurora/client/api/test_task_util.py . > > src/test/python/apache/aurora/client/api/test_restarter.py .. > > src/test/python/apache/aurora/client/api/test_instance_watcher.py .. > > src/test/python/apache/aurora/client/api/test_scheduler_client.py > . > src/test/python/apache/aurora/client/api/test_sla.py > .. > > src/test/python/apache/aurora/client/api/test_health_check.py ... > > src/test/python/apache/aurora/client/hooks/test_hooked_api.py > > src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ... > src/test/python/apache/aurora/client/test_config.py > >
Re: Review Request 50819: Use update_job instead of creating new config object when modifying.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50819/#review144824 --- Master (d0533d2) is red with this patch. ./build-support/jenkins/build.sh [1m proxy_driver = ProxyDriver()[0m [1m with temporary_dir() as checkpoint_root:[0m [1mte = AuroraExecutor([0m [1m> runner_provider=make_provider(checkpoint_root),[0m [1m sandbox_provider=DefaultTestSandboxProvider())[0m src/test/python/apache/aurora/executor/test_thermos_executor.py:580: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in make_provider [1mpex_location=thermos_runner_path(),[0m _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ build = True [1mdef thermos_runner_path(build=True):[0m [1m if not build:[0m [1mreturn getattr(thermos_runner_path, 'value', None)[0m [1m[0m [1m if not hasattr(thermos_runner_path, 'value'):[0m [1mpex_dir = safe_mkdtemp()[0m [1m> assert subprocess.call(["./pants", "--pants-distdir=%s" % pex_dir, "binary",[0m [1m "src/main/python/apache/thermos/runner:thermos_runner"]) == 0[0m [1m[31mE assert 1 == 0[0m [1m[31mE+ where 1 = (['./pants', '--pants-distdir=/tmp/tmpvraw6_', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])[0m [1m[31mE+where = subprocess.call[0m src/test/python/apache/aurora/executor/test_thermos_executor.py:185: AssertionError -- Captured stderr call -- Traceback (most recent call last): File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/1.1.0-rc7/bin/pants", line 7, in from pants.bin.pants_exe import main ImportError: No module named pants.bin.pants_exe generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml [1m[31m 16 failed, 661 passed, 6 skipped, 1 warnings, 8 error in 149.02 seconds [0m FAILURE 21:19:49 02:52 [complete][31m FAILURE[0m I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Aug. 4, 2016, 9:10 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50819/ > --- > > (Updated Aug. 4, 2016, 9:10 p.m.) > > > Review request for Aurora and Mehrdad Nurolahzade. > > > Repository: aurora > > > Description > --- > > Use update_job instead of creating new config object when modifying. This > avoids losing any state (e.g. metadata) attached to the config. > > > Diffs > - > > src/main/python/apache/aurora/client/cli/context.py > 7bbfb5e815b2408b8ddaaeeb9911a5bd1b019a27 > > Diff: https://reviews.apache.org/r/50819/diff/ > > > Testing > --- > > $ ./pants test.pytest src/test/python/apache/aurora/client:: > > 14:07:19 00:00 [main] >(To run a reporting server: ./pants server) > 14:07:19 00:00 [setup] > 14:07:19 00:00 [parse] >Executing tasks in goals: test > 14:07:19 00:00 [test] > 14:07:19 00:00 [test-prep-command] > 14:07:19 00:00 [test] > 14:07:19 00:00 [pytest] > 14:07:19 00:00 [run] > > 14:07:19 00:00 [chroot]== test session starts > === > platform darwin -- Python 2.7.10 -- py-1.4.31 -- > pytest-2.6.4 > plugins: timeout, cov > collected 339 items > > > src/test/python/apache/aurora/client/cli/test_config_noun.py ... > src/test/python/apache/aurora/client/cli/test_context.py > > src/test/python/apache/aurora/client/cli/test_version.py > . > src/test/python/apache/aurora/client/cli/test_quota.py > . >
Re: Review Request 50819: Use update_job instead of creating new config object when modifying.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50819/#review144823 --- Ship it! Ship It! - Mehrdad Nurolahzade On Aug. 4, 2016, 2:10 p.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50819/ > --- > > (Updated Aug. 4, 2016, 2:10 p.m.) > > > Review request for Aurora and Mehrdad Nurolahzade. > > > Repository: aurora > > > Description > --- > > Use update_job instead of creating new config object when modifying. This > avoids losing any state (e.g. metadata) attached to the config. > > > Diffs > - > > src/main/python/apache/aurora/client/cli/context.py > 7bbfb5e815b2408b8ddaaeeb9911a5bd1b019a27 > > Diff: https://reviews.apache.org/r/50819/diff/ > > > Testing > --- > > $ ./pants test.pytest src/test/python/apache/aurora/client:: > > 14:07:19 00:00 [main] >(To run a reporting server: ./pants server) > 14:07:19 00:00 [setup] > 14:07:19 00:00 [parse] >Executing tasks in goals: test > 14:07:19 00:00 [test] > 14:07:19 00:00 [test-prep-command] > 14:07:19 00:00 [test] > 14:07:19 00:00 [pytest] > 14:07:19 00:00 [run] > > 14:07:19 00:00 [chroot]== test session starts > === > platform darwin -- Python 2.7.10 -- py-1.4.31 -- > pytest-2.6.4 > plugins: timeout, cov > collected 339 items > > > src/test/python/apache/aurora/client/cli/test_config_noun.py ... > src/test/python/apache/aurora/client/cli/test_context.py > > src/test/python/apache/aurora/client/cli/test_version.py > . > src/test/python/apache/aurora/client/cli/test_quota.py > . > src/test/python/apache/aurora/client/cli/test_plugins.py > . > src/test/python/apache/aurora/client/cli/test_client.py > .. > src/test/python/apache/aurora/client/cli/test_sla.py > . > src/test/python/apache/aurora/client/cli/test_open.py > . > src/test/python/apache/aurora/client/cli/test_supdate.py > . > src/test/python/apache/aurora/client/cli/test_restart.py > .. > src/test/python/apache/aurora/client/cli/test_status.py > . > src/test/python/apache/aurora/client/cli/test_add.py > src/test/python/apache/aurora/client/cli/test_diff.py .. > src/test/python/apache/aurora/client/cli/test_cron.py > .. > > src/test/python/apache/aurora/client/cli/test_command_hooks.py .. > src/test/python/apache/aurora/client/cli/test_options.py > .. > src/test/python/apache/aurora/client/cli/test_task.py > . > src/test/python/apache/aurora/client/cli/test_create.py > .. > src/test/python/apache/aurora/client/cli/test_kill.py > . > src/test/python/apache/aurora/client/cli/test_inspect.py > ... > > src/test/python/apache/aurora/client/cli/test_api_from_cli.py .. > > src/test/python/apache/aurora/client/cli/test_diff_formatter.py . > > src/test/python/apache/aurora/client/api/test_updater_util.py ... > > src/test/python/apache/aurora/client/api/test_job_monitor.py .. > src/test/python/apache/aurora/client/api/test_api.py > .. > > src/test/python/apache/aurora/client/api/test_task_util.py . > > src/test/python/apache/aurora/client/api/test_restarter.py .. > > src/test/python/apache/aurora/client/api/test_instance_watcher.py .. > > src/test/python/apache/aurora/client/api/test_scheduler_client.py > . > src/test/python/apache/aurora/client/api/test_sla.py > .. > > src/test/python/apache/aurora/client/api/test_health_check.py ... > > src/test/python/apache/aurora/client/hooks/test_hooked_api.py > > src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ... > src/test/python/apache/aurora/client/test_config.py >
