Re: Review Request 51502: Clean up leaking of mounts into the host's mtab.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51502/#review147213 --- Ship it! Master (874625e) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Aug. 29, 2016, 8:28 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51502/ > --- > > (Updated Aug. 29, 2016, 8:28 p.m.) > > > Review request for Aurora and Stephan Erb. > > > Repository: aurora > > > Description > --- > > Clean up leaking of mounts into the host's mtab. > > > Diffs > - > > src/main/python/apache/aurora/executor/common/sandbox.py > cedcab68f31bb0a514ab42ccebc88ab2c7470d1c > src/test/python/apache/aurora/executor/common/test_sandbox.py > 2ba3341273efe54d1a79fe48be50d4253530dcbc > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > 7c32c94edf88d6dc0fbd7f838bea2b8077da0235 > > Diff: https://reviews.apache.org/r/51502/diff/ > > > Testing > --- > > ./build-support/jenkins/build.sh > e2e tests > > > Thanks, > > Joshua Cohen > >
Re: Review Request 51502: Clean up leaking of mounts into the host's mtab.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51502/#review147211 --- Ship it! Ship It! - Stephan Erb On Aug. 29, 2016, 10:28 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51502/ > --- > > (Updated Aug. 29, 2016, 10:28 p.m.) > > > Review request for Aurora and Stephan Erb. > > > Repository: aurora > > > Description > --- > > Clean up leaking of mounts into the host's mtab. > > > Diffs > - > > src/main/python/apache/aurora/executor/common/sandbox.py > cedcab68f31bb0a514ab42ccebc88ab2c7470d1c > src/test/python/apache/aurora/executor/common/test_sandbox.py > 2ba3341273efe54d1a79fe48be50d4253530dcbc > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > 7c32c94edf88d6dc0fbd7f838bea2b8077da0235 > > Diff: https://reviews.apache.org/r/51502/diff/ > > > Testing > --- > > ./build-support/jenkins/build.sh > e2e tests > > > Thanks, > > Joshua Cohen > >
Re: Review Request 51502: Clean up leaking of mounts into the host's mtab.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51502/#review147208 --- @ReviewBot retry - Joshua Cohen On Aug. 29, 2016, 8:28 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51502/ > --- > > (Updated Aug. 29, 2016, 8:28 p.m.) > > > Review request for Aurora and Stephan Erb. > > > Repository: aurora > > > Description > --- > > Clean up leaking of mounts into the host's mtab. > > > Diffs > - > > src/main/python/apache/aurora/executor/common/sandbox.py > cedcab68f31bb0a514ab42ccebc88ab2c7470d1c > src/test/python/apache/aurora/executor/common/test_sandbox.py > 2ba3341273efe54d1a79fe48be50d4253530dcbc > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > 7c32c94edf88d6dc0fbd7f838bea2b8077da0235 > > Diff: https://reviews.apache.org/r/51502/diff/ > > > Testing > --- > > ./build-support/jenkins/build.sh > e2e tests > > > Thanks, > > Joshua Cohen > >
Re: Review Request 51502: Clean up leaking of mounts into the host's mtab.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51502/#review147206
---
Master (874625e) is red with this patch.
./build-support/jenkins/build.sh
[1m@mock.patch.dict(os.environ, {'MESOS_DIRECTORY':
MOCK_MESOS_DIRECTORY})[0m
[1mdef
test_filesystem_sandbox_no_volumes(mock_safe_mkdir, mock_check_call):[0m
[1m sandbox_mount_point = '/some/mount/point'[0m
[1m sandbox_directory =
os.path.join(MOCK_MESOS_DIRECTORY, 'sandbox'),[0m
[1m[0m
[1m sandbox = FileSystemImageSandbox([0m
[1m sandbox_directory,[0m
[1m user='someuser',[0m
[1m no_create_user=True,[0m
[1m mounted_volume_paths=None,[0m
[1m sandbox_mount_point=sandbox_mount_point)[0m
[1m[0m
[1m sandbox._mount_paths()[0m
[1m[0m
[1m task_fs_path =
os.path.join(MOCK_MESOS_DIRECTORY, 'taskfs')[0m
[1m[0m
[1m> assert mock_check_call.mock_calls == [[0m
[1mmock.call([[0m
[1m 'mount',[0m
[1m '--bind',[0m
[1m sandbox_directory,[0m
[1m os.path.join(task_fs_path,
sandbox_mount_point[1:])[0m
[1m])[0m
[1m ][0m
[1m[31mE assert [call(['mount...ount/point'])] ==
[call(['mount'...ount/point'])][0m
[1m[31mE At index 0 diff: call(['mount', '-n',
'--rbind', ('/some/path/sandbox',), '/some/path/taskfs/some/mount/point']) !=
call(['mount', '--bind', ('/some/path/sandbox',),
'/some/path/taskfs/some/mount/point'])[0m
[1m[31mE Full diff:[0m
[1m[31mE - [call(['mount', '-n', '--rbind',
('/some/path/sandbox',), '/some/path/taskfs/some/mount/point'])][0m
[1m[31mE ? -- -[0m
[1m[31mE + [call(['mount', '--bind',
('/some/path/sandbox',), '/some/path/taskfs/some/mount/point'])][0m
src/test/python/apache/aurora/executor/common/test_sandbox.py:260:
AssertionError
generated xml file:
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 1 failed, 696 passed, 6 skipped, 1 warnings in
286.78 seconds [0m
FAILURE
20:32:15 05:07 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Aug. 29, 2016, 8:28 p.m., Joshua Cohen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51502/
> ---
>
> (Updated Aug. 29, 2016, 8:28 p.m.)
>
>
> Review request for Aurora and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> Clean up leaking of mounts into the host's mtab.
>
>
> Diffs
> -
>
> src/main/python/apache/aurora/executor/common/sandbox.py
> cedcab68f31bb0a514ab42ccebc88ab2c7470d1c
> src/test/python/apache/aurora/executor/common/test_sandbox.py
> 2ba3341273efe54d1a79fe48be50d4253530dcbc
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 7c32c94edf88d6dc0fbd7f838bea2b8077da0235
>
> Diff: https://reviews.apache.org/r/51502/diff/
>
>
> Testing
> ---
>
> ./build-support/jenkins/build.sh
> e2e tests
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 51502: Clean up leaking of mounts into the host's mtab.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51502/ --- (Updated Aug. 29, 2016, 8:28 p.m.) Review request for Aurora and Stephan Erb. Changes --- Fix missed test case. Repository: aurora Description --- Clean up leaking of mounts into the host's mtab. Diffs (updated) - src/main/python/apache/aurora/executor/common/sandbox.py cedcab68f31bb0a514ab42ccebc88ab2c7470d1c src/test/python/apache/aurora/executor/common/test_sandbox.py 2ba3341273efe54d1a79fe48be50d4253530dcbc src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 7c32c94edf88d6dc0fbd7f838bea2b8077da0235 Diff: https://reviews.apache.org/r/51502/diff/ Testing --- ./build-support/jenkins/build.sh e2e tests Thanks, Joshua Cohen
