Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

2016-09-07 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/ --- (Updated Sept. 7, 2016, 10 p.m.) Review request for Aurora, Joshua Cohen, Maxim

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

2016-09-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review148095 --- Master (19866b5) is red with this patch. ./build-support/jenkins

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

2016-09-07 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review148092 --- Ship it! Ship It! - Joshua Cohen On Sept. 7, 2016, 9:28 p.m.

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

2016-09-07 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/ --- (Updated Sept. 7, 2016, 9:28 p.m.) Review request for Aurora, Joshua Cohen, Max

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

2016-09-07 Thread Kai Huang
> On Sept. 7, 2016, 8:18 p.m., Joshua Cohen wrote: > > This change should probably be called out in RELEASE_NOTES.md? This feature will not be available to users until we relax the client-side constraint. We can add it to RELEASE_NOTES when the executor/client feature is ready. - Kai -

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

2016-09-07 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review148075 --- This change should probably be called out in RELEASE_NOTES.md? -

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

2016-09-06 Thread Kai Huang
> On Sept. 6, 2016, 8:56 p.m., Stephan Erb wrote: > > The current default of `watch_secs` is 45 seconds. Should we drop that to 0 > > and also adapt the docs accordingly? That would optimize the default > > settings for the health check driven updates, which I think would be a good > > thing.

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

2016-09-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review147922 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 6, 2016, 6:46

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

2016-09-06 Thread Maxim Khutornenko
> On Sept. 6, 2016, 8:56 p.m., Stephan Erb wrote: > > The current default of `watch_secs` is 45 seconds. Should we drop that to 0 > > and also adapt the docs accordingly? That would optimize the default > > settings for the health check driven updates, which I think would be a good > > thing.

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

2016-09-06 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review147917 --- The current default of `watch_secs` is 45 seconds. Should we drop

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

2016-09-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review147893 --- Ship it! Master (5d3f945) is green with this patch. ./build-s

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

2016-09-06 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/ --- (Updated Sept. 6, 2016, 6:46 p.m.) Review request for Aurora, Joshua Cohen, Max

Re: Review Request 51536: Scheduler updater will not use watch_sec if health check is enabled

2016-08-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51536/#review147349 --- Master (c99f2fb) is red with this patch. ./build-support/jenkins