Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148762 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 13, 2016,

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148759 --- Ship it! Master (f0ff1c4) is green with this patch.

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-13 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/ --- (Updated Sept. 13, 2016, 11:33 a.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148755 --- Master (f0ff1c4) is red with this patch.

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-13 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/ --- (Updated Sept. 13, 2016, 11:19 a.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-13 Thread Zameer Manji
> On Sept. 12, 2016, 8:09 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/api/__init__.py, line 267 > > > > > > This should send both key and query for both v-1 and v schedulers to > > work

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-12 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148643 --- src/main/python/apache/aurora/client/api/__init__.py (line 266)

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148630 --- Ship it! Master (f0ff1c4) is green with this patch.

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-12 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148628 --- @ReviewBot retry - Zameer Manji On Sept. 12, 2016, 3:26 p.m.,

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148616 --- Master (c4903d8) is red with this patch.

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-12 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/ --- (Updated Sept. 12, 2016, 3:26 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148604 --- Master (b429612) is red with this patch.

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-12 Thread Zameer Manji
> On Sept. 12, 2016, 12:48 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/api/__init__.py, line 264 > > > > > > Why not going all the way to the client command and initializing both > >

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-12 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/ --- (Updated Sept. 12, 2016, 2:22 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148576 --- Ship it! Master (b429612) is green with this patch.

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-12 Thread Maxim Khutornenko
> On Sept. 12, 2016, 7:48 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/api/__init__.py, line 264 > > > > > > Why not going all the way to the client command and initializing both > >

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-12 Thread Zameer Manji
> On Sept. 12, 2016, 12:48 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/api/__init__.py, line 264 > > > > > > Why not going all the way to the client command and initializing both > >

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-12 Thread Zameer Manji
> On Sept. 12, 2016, 12:48 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/api/__init__.py, line 264 > > > > > > Why not going all the way to the client command and initializing both > >

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-12 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148565 --- src/main/python/apache/aurora/client/api/__init__.py (line 264)

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-12 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/ --- (Updated Sept. 12, 2016, 12:39 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-12 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148557 --- Ship it!

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-12 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148539 --- Bumping this for visability. - Zameer Manji On Sept. 8, 2016,

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148294 --- Ship it! Master (87ae968) is green with this patch.

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-08 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/ --- (Updated Sept. 8, 2016, 5:30 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148288 --- Master (87ae968) is red with this patch.

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-08 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/ --- (Updated Sept. 8, 2016, 4:49 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-08 Thread Zameer Manji
> On Sept. 8, 2016, 1:19 a.m., Stephan Erb wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, lines 899-900 > > > > > > If this is deprecated, shouldn't you call this out in the release notes > > ad

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-08 Thread Zameer Manji
> On Sept. 8, 2016, 9:37 a.m., Maxim Khutornenko wrote: > > This will most certainly break the UI. The client needs to be updated as > > well to pass both (old and new) arguments. Please, test in vagrant with > > different combinations of scheduler and client versions. I have validated that

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-08 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148208 --- This will most certainly break the UI. The client needs to be

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-08 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148158 --- LGTM (+-1 the current test failure)

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148125 --- Master (8fca745) is red with this patch.

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-07 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148120 --- @ReviewBot retry - Zameer Manji On Sept. 7, 2016, 5:03 p.m.,

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148119 --- Master (8fca745) is red with this patch.

Re: Review Request 51712: Extend getJobUpdateDetails to accept JobUpdateQuery

2016-09-07 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51712/#review148117 --- Reviewers: This is my first time causing a thrift level