Re: Review Request 51742: Modify the callback function passed to StatusManager

2016-09-08 Thread Kai Huang
> On Sept. 8, 2016, 9:13 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/executor/aurora_executor.py, lines 204-211 > > > > > > I see a couple of problems with this method: > > > > 1. The

Re: Review Request 51742: Modify the callback function passed to StatusManager

2016-09-08 Thread Kai Huang
> On Sept. 8, 2016, 9:13 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/executor/aurora_executor.py, lines 204-211 > > > > > > I see a couple of problems with this method: > > > > 1. The

Re: Review Request 51742: Modify the callback function passed to StatusManager

2016-09-08 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51742/#review148280 --- src/test/python/apache/aurora/executor/test_status_manager.py

Re: Review Request 51742: Modify the callback function passed to StatusManager

2016-09-08 Thread Kai Huang
> On Sept. 8, 2016, 9:13 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/executor/aurora_executor.py, lines 204-211 > > > > > > I see a couple of problems with this method: > > > > 1. The

Re: Review Request 51742: Modify the callback function passed to StatusManager

2016-09-08 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51742/#review148258 --- src/main/python/apache/aurora/executor/aurora_executor.py (line

Re: Review Request 51742: Modify the callback function passed to StatusManager

2016-09-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51742/#review148250 --- Ship it! Master (8fca745) is green with this patch.