Re: Review Request 51765: Batching writes - Part 3 (of 3): Converting TaskScheduler to use BatchWorker.

2016-09-16 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51765/#review149277 --- Ship it! Ship It! - Joshua Cohen On Sept. 14, 2016, 11:18

Re: Review Request 51765: Batching writes - Part 3 (of 3): Converting TaskScheduler to use BatchWorker.

2016-09-16 Thread Maxim Khutornenko
> On Sept. 16, 2016, 6:28 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java, > > line 91 > > > > > > Curious, arbitrary or derrived? Arbitrary derived :) There

Re: Review Request 51765: Batching writes - Part 3 (of 3): Converting TaskScheduler to use BatchWorker.

2016-09-16 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51765/#review149229 --- Ship it! LGTM.

Re: Review Request 51765: Batching writes - Part 3 (of 3): Converting TaskScheduler to use BatchWorker.

2016-09-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51765/#review148998 --- Ship it! Master (5069f93) is green with this patch.

Re: Review Request 51765: Batching writes - Part 3 (of 3): Converting TaskScheduler to use BatchWorker.

2016-09-14 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51765/ --- (Updated Sept. 14, 2016, 11:17 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 51765: Batching writes - Part 3 (of 3): Converting TaskScheduler to use BatchWorker.

2016-09-14 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51765/#review148941 --- Ship it! Seems to be a straight forward usage of the

Re: Review Request 51765: Batching writes - Part 3 (of 3): Converting TaskScheduler to use BatchWorker.

2016-09-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51765/#review148828 --- Ship it! Master (5069f93) is green with this patch.

Re: Review Request 51765: Batching writes - Part 3 (of 3): Converting TaskScheduler to use BatchWorker.

2016-09-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51765/ --- (Updated Sept. 14, 2016, 12:29 a.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 51765: Batching writes - Part 3 (of 3): Converting TaskScheduler to use BatchWorker.

2016-09-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51765/#review148804 --- Master (633948a) is red with this patch.

Re: Review Request 51765: Batching writes - Part 3 (of 3): Converting TaskScheduler to use BatchWorker.

2016-09-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51765/ --- (Updated Sept. 13, 2016, 11:14 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 51765: Batching writes - Part 3 (of 3): Converting TaskScheduler to use BatchWorker.

2016-09-13 Thread Stephan Erb
> On Sept. 12, 2016, 1:18 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java, > > lines 115-128 > > > > > > The `scheduleTask` method is doing some staggering

Re: Review Request 51765: Batching writes - Part 3 (of 3): Converting TaskScheduler to use BatchWorker.

2016-09-12 Thread Maxim Khutornenko
> On Sept. 11, 2016, 11:18 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java, > > lines 115-128 > > > > > > The `scheduleTask` method is doing some staggering

Re: Review Request 51765: Batching writes - Part 3 (of 3): Converting TaskScheduler to use BatchWorker.

2016-09-11 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51765/#review148434 ---

Re: Review Request 51765: Batching writes - Part 3 (of 3): Converting TaskScheduler to use BatchWorker.

2016-09-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51765/#review148362 --- Ship it! Master (c7f710a) is green with this patch.