Re: Review Request 51973: Fix for AURORA-1739, enables golang thrift bindings to create jobs

2016-09-16 Thread Joshua Cohen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51973/#review149273
---


Ship it!




Ship It!

- Joshua Cohen


On Sept. 16, 2016, 8:49 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51973/
> ---
> 
> (Updated Sept. 16, 2016, 8:49 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Change in the thrift API to make thee cronSchedule string in JobConfiguration 
> an optional.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 411872b0244698b4ca74228bc21da608dcb98ae0 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> a045a21585fe40e63e2094fa103f205e7883eb35 
> 
> Diff: https://reviews.apache.org/r/51973/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>



Re: Review Request 51973: Fix for AURORA-1739, enables golang thrift bindings to create jobs

2016-09-16 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51973/#review149272
---


Ship it!




Master (783baae) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 16, 2016, 8:49 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51973/
> ---
> 
> (Updated Sept. 16, 2016, 8:49 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Change in the thrift API to make thee cronSchedule string in JobConfiguration 
> an optional.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 411872b0244698b4ca74228bc21da608dcb98ae0 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> a045a21585fe40e63e2094fa103f205e7883eb35 
> 
> Diff: https://reviews.apache.org/r/51973/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>



Re: Review Request 51973: Fix for AURORA-1739, enables golang thrift bindings to create jobs

2016-09-16 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51973/#review149271
---


Ship it!




Ship It!

- Maxim Khutornenko


On Sept. 16, 2016, 8:49 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51973/
> ---
> 
> (Updated Sept. 16, 2016, 8:49 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Change in the thrift API to make thee cronSchedule string in JobConfiguration 
> an optional.
> 
> 
> Diffs
> -
> 
>   RELEASE-NOTES.md 411872b0244698b4ca74228bc21da608dcb98ae0 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> a045a21585fe40e63e2094fa103f205e7883eb35 
> 
> Diff: https://reviews.apache.org/r/51973/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>



Re: Review Request 51973: Fix for AURORA-1739, enables golang thrift bindings to create jobs

2016-09-16 Thread Renan DelValle

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51973/
---

(Updated Sept. 16, 2016, 1:49 p.m.)


Review request for Aurora, Joshua Cohen and Maxim Khutornenko.


Changes
---

Adding a line on the change to the release notes.


Repository: aurora


Description
---

Change in the thrift API to make thee cronSchedule string in JobConfiguration 
an optional.


Diffs (updated)
-

  RELEASE-NOTES.md 411872b0244698b4ca74228bc21da608dcb98ae0 
  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
a045a21585fe40e63e2094fa103f205e7883eb35 

Diff: https://reviews.apache.org/r/51973/diff/


Testing
---

./build-support/jenkins/build.sh

./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Renan DelValle



Re: Review Request 51973: Fix for AURORA-1739, enables golang thrift bindings to create jobs

2016-09-16 Thread Renan DelValle


> On Sept. 16, 2016, 1:42 p.m., Maxim Khutornenko wrote:
> > Not that it changes much but since it's technically a schema change a 
> > release note would be great.

Doh! Can't believe I forgot. Coming right up.


- Renan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51973/#review149266
---


On Sept. 16, 2016, 1:36 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51973/
> ---
> 
> (Updated Sept. 16, 2016, 1:36 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Change in the thrift API to make thee cronSchedule string in JobConfiguration 
> an optional.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> a045a21585fe40e63e2094fa103f205e7883eb35 
> 
> Diff: https://reviews.apache.org/r/51973/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>



Re: Review Request 51973: Fix for AURORA-1739, enables golang thrift bindings to create jobs

2016-09-16 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51973/#review149266
---



Not that it changes much but since it's technically a schema change a release 
note would be great.

- Maxim Khutornenko


On Sept. 16, 2016, 8:36 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51973/
> ---
> 
> (Updated Sept. 16, 2016, 8:36 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Change in the thrift API to make thee cronSchedule string in JobConfiguration 
> an optional.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> a045a21585fe40e63e2094fa103f205e7883eb35 
> 
> Diff: https://reviews.apache.org/r/51973/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>