Re: Review Request 51987: Enable the `project_info` plugin.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51987/#review149337 --- Ship it! Ship It! - Zameer Manji On Sept. 17, 2016, 10:50 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51987/ > --- > > (Updated Sept. 17, 2016, 10:50 a.m.) > > > Review request for Aurora and Zameer Manji. > > > Bugs: AURORA-1775 > https://issues.apache.org/jira/browse/AURORA-1775 > > > Repository: aurora > > > Description > --- > > This brings in the `dependencies` goal which we use in > `build-support/python/make-pycharm-virtualenv`. > > pants.ini | 1 + > 1 file changed, 1 insertion(+) > > > Diffs > - > > pants.ini de0ab30264980e28cbb771b8beaa99fa02797b25 > > Diff: https://reviews.apache.org/r/51987/diff/ > > > Testing > --- > > Used `./build-support/python/make-pycharm-virtualenv` to generate a > pycharm project that loaded properly with symbol navigation for aurora > 3rdparty deps. > > > Thanks, > > John Sirois > >
Re: Review Request 51987: Enable the `project_info` plugin.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51987/#review149335 --- Ship it! Ship It! - Stephan Erb On Sept. 17, 2016, 7:50 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51987/ > --- > > (Updated Sept. 17, 2016, 7:50 p.m.) > > > Review request for Aurora and Zameer Manji. > > > Bugs: AURORA-1775 > https://issues.apache.org/jira/browse/AURORA-1775 > > > Repository: aurora > > > Description > --- > > This brings in the `dependencies` goal which we use in > `build-support/python/make-pycharm-virtualenv`. > > pants.ini | 1 + > 1 file changed, 1 insertion(+) > > > Diffs > - > > pants.ini de0ab30264980e28cbb771b8beaa99fa02797b25 > > Diff: https://reviews.apache.org/r/51987/diff/ > > > Testing > --- > > Used `./build-support/python/make-pycharm-virtualenv` to generate a > pycharm project that loaded properly with symbol navigation for aurora > 3rdparty deps. > > > Thanks, > > John Sirois > >
Re: Review Request 51987: Enable the `project_info` plugin.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51987/#review149333 --- Ship it! Master (a87ad41) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Sept. 17, 2016, 5:50 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51987/ > --- > > (Updated Sept. 17, 2016, 5:50 p.m.) > > > Review request for Aurora and Zameer Manji. > > > Bugs: AURORA-1775 > https://issues.apache.org/jira/browse/AURORA-1775 > > > Repository: aurora > > > Description > --- > > This brings in the `dependencies` goal which we use in > `build-support/python/make-pycharm-virtualenv`. > > pants.ini | 1 + > 1 file changed, 1 insertion(+) > > > Diffs > - > > pants.ini de0ab30264980e28cbb771b8beaa99fa02797b25 > > Diff: https://reviews.apache.org/r/51987/diff/ > > > Testing > --- > > Used `./build-support/python/make-pycharm-virtualenv` to generate a > pycharm project that loaded properly with symbol navigation for aurora > 3rdparty deps. > > > Thanks, > > John Sirois > >
