Re: Review Request 52141: Shutting down scheduler on unhandled BatchWorker error.

2016-09-22 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52141/#review150035 --- Ship it! src/main/java/org/apache/aurora/scheduler/BatchWorker

Re: Review Request 52141: Shutting down scheduler on unhandled BatchWorker error.

2016-09-22 Thread Joshua Cohen
> On Sept. 22, 2016, 2:24 p.m., Joshua Cohen wrote: > > What's the behavior pre-BatchWorker in this case? Would we fail hard, or is > > there something inherent to the batch worker that makes this necessary? > > > > Also, this fixes the error handling that led to corruption in the event of > >

Re: Review Request 52141: Shutting down scheduler on unhandled BatchWorker error.

2016-09-22 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52141/#review150026 --- Ship it! Ship It! - Joshua Cohen On Sept. 22, 2016, 3:20 p.m

Re: Review Request 52141: Shutting down scheduler on unhandled BatchWorker error.

2016-09-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52141/#review150020 --- Ship it! Master (d3c5ca7) is green with this patch. ./build-s

Re: Review Request 52141: Shutting down scheduler on unhandled BatchWorker error.

2016-09-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52141/ --- (Updated Sept. 22, 2016, 3:20 p.m.) Review request for Aurora, Stephan Erb and

Re: Review Request 52141: Shutting down scheduler on unhandled BatchWorker error.

2016-09-22 Thread Maxim Khutornenko
> On Sept. 22, 2016, 2:24 p.m., Joshua Cohen wrote: > > What's the behavior pre-BatchWorker in this case? Would we fail hard, or is > > there something inherent to the batch worker that makes this necessary? > > > > Also, this fixes the error handling that led to corruption in the event of > >

Re: Review Request 52141: Shutting down scheduler on unhandled BatchWorker error.

2016-09-22 Thread Maxim Khutornenko
> On Sept. 22, 2016, 2:25 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/BatchWorker.java, line 152 > > > > > > Something is wrong here. > > > > The listener from `GuavaUtils.Lifecyc

Re: Review Request 52141: Shutting down scheduler on unhandled BatchWorker error.

2016-09-22 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52141/#review15 --- src/main/java/org/apache/aurora/scheduler/BatchWorker.java (line

Re: Review Request 52141: Shutting down scheduler on unhandled BatchWorker error.

2016-09-22 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52141/#review14 --- What's the behavior pre-BatchWorker in this case? Would we fail ha

Re: Review Request 52141: Shutting down scheduler on unhandled BatchWorker error.

2016-09-22 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52141/#review149963 --- Ship it! Ship It! - Stephan Erb On Sept. 22, 2016, 7:38 a.m.

Re: Review Request 52141: Shutting down scheduler on unhandled BatchWorker error.

2016-09-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52141/#review149954 --- Ship it! Master (d3c5ca7) is green with this patch. ./build-s