Re: Review Request 52300: Running task ssh without an instance should pick a random instance

2016-09-30 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52300/#review151028
---


Ship it!




Master (1a72438) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 30, 2016, 3:19 p.m., JING CHEN wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52300/
> ---
> 
> (Updated Sept. 30, 2016, 3:19 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1110
> https://issues.apache.org/jira/browse/AURORA-1110
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Running task ssh without an instance should pick the random instance
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/options.py 
> 1245ff15a69a4b4347672f7b556985521e813a00 
>   src/main/python/apache/aurora/client/cli/task.py 
> a8a4edcfda8d879fcc4401bb8f5223de3ee5376d 
>   src/test/python/apache/aurora/client/cli/test_task.py 
> d2233b67b37f8b34fae62372aa5d95e0a2e827b5 
> 
> Diff: https://reviews.apache.org/r/52300/diff/
> 
> 
> Testing
> ---
> 
> verified in vagrant
> 
> 
> Thanks,
> 
> JING CHEN
> 
>

Re: Review Request 52300: Running task ssh without an instance should pick a random instance

2016-09-30 Thread JING CHEN 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52300/
---

(Updated Sept. 30, 2016, 3:19 p.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

fix a typo


Bugs: AURORA-1110
https://issues.apache.org/jira/browse/AURORA-1110


Repository: aurora


Description
---

Running task ssh without an instance should pick the random instance


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/options.py 
1245ff15a69a4b4347672f7b556985521e813a00 
  src/main/python/apache/aurora/client/cli/task.py 
a8a4edcfda8d879fcc4401bb8f5223de3ee5376d 
  src/test/python/apache/aurora/client/cli/test_task.py 
d2233b67b37f8b34fae62372aa5d95e0a2e827b5 

Diff: https://reviews.apache.org/r/52300/diff/


Testing
---

verified in vagrant


Thanks,

JING CHEN

Re: Review Request 52300: Running task ssh without an instance should pick a random instance

2016-09-30 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52300/#review151005
---


Ship it!




Master (655105d) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 30, 2016, 10:08 a.m., JING CHEN wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52300/
> ---
> 
> (Updated Sept. 30, 2016, 10:08 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1110
> https://issues.apache.org/jira/browse/AURORA-1110
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Running task ssh without an instance should pick the random instance
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/options.py 
> 1245ff15a69a4b4347672f7b556985521e813a00 
>   src/main/python/apache/aurora/client/cli/task.py 
> a8a4edcfda8d879fcc4401bb8f5223de3ee5376d 
>   src/test/python/apache/aurora/client/cli/test_task.py 
> d2233b67b37f8b34fae62372aa5d95e0a2e827b5 
> 
> Diff: https://reviews.apache.org/r/52300/diff/
> 
> 
> Testing
> ---
> 
> verified in vagrant
> 
> 
> Thanks,
> 
> JING CHEN
> 
>

Re: Review Request 52300: Running task ssh without an instance should pick a random instance

2016-09-30 Thread JING CHEN 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52300/
---

(Updated Sept. 30, 2016, 10:08 a.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

add a helper function to create _CommandOption_, add a new test case where 
getTaskStatus is called when instanceId is not specified in the query


Bugs: AURORA-1110
https://issues.apache.org/jira/browse/AURORA-1110


Repository: aurora


Description
---

Running task ssh without an instance should pick the random instance


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/options.py 
1245ff15a69a4b4347672f7b556985521e813a00 
  src/main/python/apache/aurora/client/cli/task.py 
a8a4edcfda8d879fcc4401bb8f5223de3ee5376d 
  src/test/python/apache/aurora/client/cli/test_task.py 
d2233b67b37f8b34fae62372aa5d95e0a2e827b5 

Diff: https://reviews.apache.org/r/52300/diff/


Testing
---

verified in vagrant


Thanks,

JING CHEN

Re: Review Request 52300: Running task ssh without an instance should pick a random instance

2016-09-29 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52300/#review150864
---



lgtm overall. Just two small changes and it's gtg...


src/main/python/apache/aurora/client/cli/options.py (lines 261 - 264)


I see the benefit of changing the help message for the ssh case, since the 
behavior is different if INSTANCES is not specified. Other than the help 
message, this is identical to `INSTANCES_SPEC_ARGUMENT` however. Perhaps create 
a helper function that takes the help text and returns the `CommandOption` that 
can be reused by both of these?



src/test/python/apache/aurora/client/cli/test_task.py (line 179)


Can you add a test case for the case where no instance is specified that 
asserts the `getTasksStatus` api call is made with the `instanceIds` param on 
the query not set?


- Joshua Cohen


On Sept. 29, 2016, 5:30 a.m., JING CHEN wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52300/
> ---
> 
> (Updated Sept. 29, 2016, 5:30 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1110
> https://issues.apache.org/jira/browse/AURORA-1110
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Running task ssh without an instance should pick the random instance
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/options.py 
> 1245ff15a69a4b4347672f7b556985521e813a00 
>   src/main/python/apache/aurora/client/cli/task.py 
> a8a4edcfda8d879fcc4401bb8f5223de3ee5376d 
>   src/test/python/apache/aurora/client/cli/test_task.py 
> d2233b67b37f8b34fae62372aa5d95e0a2e827b5 
> 
> Diff: https://reviews.apache.org/r/52300/diff/
> 
> 
> Testing
> ---
> 
> verified in vagrant
> 
> 
> Thanks,
> 
> JING CHEN
> 
>

Re: Review Request 52300: Running task ssh without an instance should pick a random instance

2016-09-29 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52300/#review150819
---


Ship it!




Master (1c1c0a5) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 29, 2016, 5:30 a.m., JING CHEN wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52300/
> ---
> 
> (Updated Sept. 29, 2016, 5:30 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1110
> https://issues.apache.org/jira/browse/AURORA-1110
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Running task ssh without an instance should pick the random instance
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/options.py 
> 1245ff15a69a4b4347672f7b556985521e813a00 
>   src/main/python/apache/aurora/client/cli/task.py 
> a8a4edcfda8d879fcc4401bb8f5223de3ee5376d 
>   src/test/python/apache/aurora/client/cli/test_task.py 
> d2233b67b37f8b34fae62372aa5d95e0a2e827b5 
> 
> Diff: https://reviews.apache.org/r/52300/diff/
> 
> 
> Testing
> ---
> 
> verified in vagrant
> 
> 
> Thanks,
> 
> JING CHEN
> 
>

Re: Review Request 52300: Running task ssh without an instance should pick a random instance

2016-09-28 Thread JING CHEN 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52300/
---

(Updated Sept. 29, 2016, 5:30 a.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

When command option is provided, instance must be specified


Bugs: AURORA-1110
https://issues.apache.org/jira/browse/AURORA-1110


Repository: aurora


Description (updated)
---

Running task ssh without an instance should pick the random instance


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/options.py 
1245ff15a69a4b4347672f7b556985521e813a00 
  src/main/python/apache/aurora/client/cli/task.py 
a8a4edcfda8d879fcc4401bb8f5223de3ee5376d 
  src/test/python/apache/aurora/client/cli/test_task.py 
d2233b67b37f8b34fae62372aa5d95e0a2e827b5 

Diff: https://reviews.apache.org/r/52300/diff/


Testing
---

verified in vagrant


Thanks,

JING CHEN

Re: Review Request 52300: Running task ssh without an instance should pick a random instance

2016-09-27 Thread Stephan Erb 


> On Sept. 27, 2016, 1:11 p.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/client/cli/task.py, line 121
> > 
> >
> > Do you think we should require an instance a the command was specified? 
> > I'm concerned about the scenario where running the command has a side 
> > effect on the instance. For example, if you were to run `aurora task ssh 
> > cluster/role/env/job --command=touch .healthchecksnooze`, after this 
> > change, that would disable health checks on (from the user's perspective) 
> > an unknown instance.
> 
> JING CHEN wrote:
> For the command option, as far as i know, if a instance is not speficed, 
> the __largest__ instance will be returned and connected to, which means the 
> command will execute on the greaetest instace. However, in this case, at 
> least we shoule let user know which instance they perform on. And I am also 
> wondering if it is easy for user to find out the greatest instance given that 
> there are multiple instance. I agree with you that it requires explicit 
> instance from user when command option is specified. Otherwise, we have to 
> come up with a idea to make users know the target instance. Let me know if 
> you have addtional suggestion. Thasnks.
> 
> Joshua Cohen wrote:
> I'm fine with just bailing out if no instance is specified but a command 
> is.

I am curious: Where does it come from that always the largest instance is 
returend? I have always assumed that query results are effectively unordered.


- Stephan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52300/#review150540
---


On Sept. 27, 2016, 12:44 p.m., JING CHEN wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52300/
> ---
> 
> (Updated Sept. 27, 2016, 12:44 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1110
> https://issues.apache.org/jira/browse/AURORA-1110
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Running task ssh without an instance should pick the greatest instance
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/options.py 
> 1245ff15a69a4b4347672f7b556985521e813a00 
>   src/main/python/apache/aurora/client/cli/task.py 
> a8a4edcfda8d879fcc4401bb8f5223de3ee5376d 
>   src/test/python/apache/aurora/client/cli/test_options.py 
> f2aae5741611909d5a1700cb4da70dec313e00da 
> 
> Diff: https://reviews.apache.org/r/52300/diff/
> 
> 
> Testing
> ---
> 
> verified in vagrant
> 
> 
> Thanks,
> 
> JING CHEN
> 
>

Re: Review Request 52300: Running task ssh without an instance should pick a random instance

2016-09-27 Thread Joshua Cohen 


> On Sept. 27, 2016, 11:11 a.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/client/cli/task.py, line 121
> > 
> >
> > Do you think we should require an instance a the command was specified? 
> > I'm concerned about the scenario where running the command has a side 
> > effect on the instance. For example, if you were to run `aurora task ssh 
> > cluster/role/env/job --command=touch .healthchecksnooze`, after this 
> > change, that would disable health checks on (from the user's perspective) 
> > an unknown instance.
> 
> JING CHEN wrote:
> For the command option, as far as i know, if a instance is not speficed, 
> the __largest__ instance will be returned and connected to, which means the 
> command will execute on the greaetest instace. However, in this case, at 
> least we shoule let user know which instance they perform on. And I am also 
> wondering if it is easy for user to find out the greatest instance given that 
> there are multiple instance. I agree with you that it requires explicit 
> instance from user when command option is specified. Otherwise, we have to 
> come up with a idea to make users know the target instance. Let me know if 
> you have addtional suggestion. Thasnks.

I'm fine with just bailing out if no instance is specified but a command is.


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52300/#review150540
---


On Sept. 27, 2016, 10:44 a.m., JING CHEN wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52300/
> ---
> 
> (Updated Sept. 27, 2016, 10:44 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1110
> https://issues.apache.org/jira/browse/AURORA-1110
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Running task ssh without an instance should pick the greatest instance
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/options.py 
> 1245ff15a69a4b4347672f7b556985521e813a00 
>   src/main/python/apache/aurora/client/cli/task.py 
> a8a4edcfda8d879fcc4401bb8f5223de3ee5376d 
>   src/test/python/apache/aurora/client/cli/test_options.py 
> f2aae5741611909d5a1700cb4da70dec313e00da 
> 
> Diff: https://reviews.apache.org/r/52300/diff/
> 
> 
> Testing
> ---
> 
> verified in vagrant
> 
> 
> Thanks,
> 
> JING CHEN
> 
>

Re: Review Request 52300: Running task ssh without an instance should pick a random instance

2016-09-27 Thread JING CHEN 


> On Sept. 27, 2016, 11:11 a.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/client/cli/options.py, lines 118-120
> > 
> >
> > Changing this here means that all commands that previously required an 
> > instance key rather than a job key will now work without one. A quick 
> > glance at the code indicates that this change will also affect the `aurora 
> > job add` command, which requires specifying an instance to use as a 
> > template for adding more task instances to the job. I'm not sure we want to 
> > make that change as part of this review, there's value in being explicit 
> > when adding task instances versus picking a random one to act as a template.
> > 
> > How about changing `SshCommand` to specify `INSTANCES_SPEC_ARGUMENT` 
> > instead of `TASK_INSTANCE_ARGUMENT` which already allows for an optional 
> > instance spec?

thanks Josh, your suggestion makes sense, I will change it asap


> On Sept. 27, 2016, 11:11 a.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/client/cli/task.py, line 121
> > 
> >
> > Do you think we should require an instance a the command was specified? 
> > I'm concerned about the scenario where running the command has a side 
> > effect on the instance. For example, if you were to run `aurora task ssh 
> > cluster/role/env/job --command=touch .healthchecksnooze`, after this 
> > change, that would disable health checks on (from the user's perspective) 
> > an unknown instance.

For the command option, as far as i know, if a instance is not speficed, the 
__largest__ instance will be returned and connected to, which means the command 
will execute on the greaetest instace. However, in this case, at least we 
shoule let user know which instance they perform on. And I am also wondering if 
it is easy for user to find out the greatest instance given that there are 
multiple instance. I agree with you that it requires explicit instance from 
user when command option is specified. Otherwise, we have to come up with a 
idea to make users know the target instance. Let me know if you have addtional 
suggestion. Thasnks.


- JING


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52300/#review150540
---


On Sept. 27, 2016, 10:44 a.m., JING CHEN wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52300/
> ---
> 
> (Updated Sept. 27, 2016, 10:44 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1110
> https://issues.apache.org/jira/browse/AURORA-1110
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Running task ssh without an instance should pick the greatest instance
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/options.py 
> 1245ff15a69a4b4347672f7b556985521e813a00 
>   src/main/python/apache/aurora/client/cli/task.py 
> a8a4edcfda8d879fcc4401bb8f5223de3ee5376d 
>   src/test/python/apache/aurora/client/cli/test_options.py 
> f2aae5741611909d5a1700cb4da70dec313e00da 
> 
> Diff: https://reviews.apache.org/r/52300/diff/
> 
> 
> Testing
> ---
> 
> verified in vagrant
> 
> 
> Thanks,
> 
> JING CHEN
> 
>

Re: Review Request 52300: Running task ssh without an instance should pick a random instance

2016-09-27 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52300/#review150540
---



Thanks for tackling this, it'll be a nice quality of life improvement!


src/main/python/apache/aurora/client/cli/options.py (lines 118 - 120)


Changing this here means that all commands that previously required an 
instance key rather than a job key will now work without one. A quick glance at 
the code indicates that this change will also affect the `aurora job add` 
command, which requires specifying an instance to use as a template for adding 
more task instances to the job. I'm not sure we want to make that change as 
part of this review, there's value in being explicit when adding task instances 
versus picking a random one to act as a template.

How about changing `SshCommand` to specify `INSTANCES_SPEC_ARGUMENT` 
instead of `TASK_INSTANCE_ARGUMENT` which already allows for an optional 
instance spec?



src/main/python/apache/aurora/client/cli/task.py (line 120)


Do you think we should require an instance a the command was specified? I'm 
concerned about the scenario where running the command has a side effect on the 
instance. For example, if you were to run `aurora task ssh cluster/role/env/job 
--command=touch .healthchecksnooze`, after this change, that would disable 
health checks on (from the user's perspective) an unknown instance.


- Joshua Cohen


On Sept. 27, 2016, 10:44 a.m., JING CHEN wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52300/
> ---
> 
> (Updated Sept. 27, 2016, 10:44 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1110
> https://issues.apache.org/jira/browse/AURORA-1110
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Running task ssh without an instance should pick the greatest instance
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/options.py 
> 1245ff15a69a4b4347672f7b556985521e813a00 
>   src/main/python/apache/aurora/client/cli/task.py 
> a8a4edcfda8d879fcc4401bb8f5223de3ee5376d 
>   src/test/python/apache/aurora/client/cli/test_options.py 
> f2aae5741611909d5a1700cb4da70dec313e00da 
> 
> Diff: https://reviews.apache.org/r/52300/diff/
> 
> 
> Testing
> ---
> 
> verified in vagrant
> 
> 
> Thanks,
> 
> JING CHEN
> 
>

Re: Review Request 52300: Running task ssh without an instance should pick a random instance

2016-09-27 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52300/#review150539
---



Master (60e5e4e) is red with this patch.
  ./build-support/jenkins/build.sh

virtualenv-15.0.2/virtualenv_support/argparse-1.4.0-py2.py3-none-any.whl
virtualenv-15.0.2/virtualenv_support/pip-8.1.2-py2.py3-none-any.whl
virtualenv-15.0.2/virtualenv_support/setuptools-21.2.1-py2.py3-none-any.whl
virtualenv-15.0.2/virtualenv_support/wheel-0.29.0-py2.py3-none-any.whl
+ touch virtualenv-15.0.2/BOOTSTRAPPED
+ popd
/home/jenkins/jenkins-slave/workspace/AuroraBot
+ exec /usr/bin/python2.7 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/virtualenv-15.0.2/virtualenv.py
 --no-download 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv
New python executable in 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python2.7
Also creating executable in 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python
Installing setuptools, pip, wheel...done.
Collecting isort==4.0.0
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:318:
 SNIMissingWarning: An HTTPS request has been made, but the SNI (Subject Name 
Indication) extension to TLS is not available on this platform. This may cause 
the server to present an incorrect TLS certificate, which can cause validation 
failures. You can upgrade to a newer version of Python to solve this. For more 
information, see 
https://urllib3.readthedocs.org/en/latest/security.html#snimissingwarning.
  SNIMissingWarning
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122:
 InsecurePlatformWarning: A true SSLContext object is not available. This 
prevents urllib3 from configuring SSL appropriately and may cause certain SSL 
connections to fail. You can upgrade to a newer version of Python to solve 
this. For more information, see 
https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Downloading isort-4.0.0-py2.py3-none-any.whl
Installing collected packages: isort
Successfully installed isort-4.0.0
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122:
 InsecurePlatformWarning: A true SSLContext object is not available. This 
prevents urllib3 from configuring SSL appropriately and may cause certain SSL 
connections to fail. You can upgrade to a newer version of Python to solve 
this. For more information, see 
https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
ERROR: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/cli/task.py
 Imports are incorrectly sorted.
--- 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/cli/task.py:before
 2016-09-27 10:52:48.076833
+++ 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/cli/task.py:after
  2016-09-27 11:00:42.129478
@@ -27,13 +27,13 @@
 from apache.aurora.client.cli import EXIT_INVALID_PARAMETER, EXIT_OK, Noun, 
Verb
 from apache.aurora.client.cli.context import AuroraCommandContext
 from apache.aurora.client.cli.options import (
+ALL_INSTANCES,
 EXECUTOR_SANDBOX_OPTION,
 INSTANCES_SPEC_ARGUMENT,
 SSH_OPTIONS,
 SSH_USER_OPTION,
 TASK_INSTANCE_ARGUMENT,
-CommandOption,
-ALL_INSTANCES
+CommandOption
 )
 from apache.aurora.common.clusters import CLUSTERS
 


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 27, 2016, 10:44 a.m., JING CHEN wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52300/
> ---
> 
> (Updated Sept. 27, 2016, 10:44 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1110
> https://issues.apache.org/jira/browse/AURORA-1110
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Running task ssh without an instance should pick the greatest instance
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/options.py 
> 1245ff15a69a4b4347672f7b556985521e813a00 
>   src/main/python/apache/aurora/client/cli/task.py 
> a8a4edcfda8d879fcc4401bb8f5223de3ee5376d 
>   src/test/python/apache/aurora/client/cli/test_options.py 
> f2aae5741611909d5a1700cb4da70dec313e00da 
> 
> Diff: