Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2017-02-07 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52437/#review164643
---


Ship it!




Ship It!

- Stephan Erb


On Feb. 8, 2017, 1:48 a.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52437/
> ---
> 
> (Updated Feb. 8, 2017, 1:48 a.m.)
> 
> 
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
> 
> 
> Bugs: AURORA-1872
> https://issues.apache.org/jira/browse/AURORA-1872
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Added builder and test environment for Xenial as well as updated instructions 
> on how to test it.
> 
> Added distribution to release-candidate script.
> 
> 
> Diffs
> -
> 
>   build-support/release/release-candidate 
> b3ebe916102d0a6ef2c1997b6c4110008eafff1a 
>   builder/deb/debian-jessie/Dockerfile 
> 54cb2e072a0d465840899e00e541cec34130993d 
>   builder/deb/debian-jessie/build.sh e0aeaf52a29483e65172f29792638dfbca100079 
>   builder/deb/ubuntu-trusty/Dockerfile 
> 802049b6b2a53666c153525f2fb97bfbf0d4bab4 
>   builder/deb/ubuntu-trusty/build.sh e0aeaf52a29483e65172f29792638dfbca100079 
>   builder/deb/ubuntu-xenial/Dockerfile PRE-CREATION 
>   builder/deb/ubuntu-xenial/build.sh PRE-CREATION 
>   specs/debian/aurora-executor.thermos.default 
> 82ab0c8ab585acf253f8fecc0ed88a3e19511ffb 
>   specs/debian/aurora-executor.thermos.service 
> da351164298bd2b5a1802a945211647c99193ae6 
>   specs/debian/aurora-pants.ini e4f2c54df45f746ffb2a4e3f786fc4105323bc0b 
>   specs/debian/aurora-scheduler.service 
> ae33d26ac10518985eacea6bf015f81a02c53f66 
>   specs/debian/aurora-scheduler.startup.sh PRE-CREATION 
>   specs/debian/rules 4effc3ecf3208f82986d15f6000d18abc11652b1 
>   test/deb/ubuntu-xenial/README.md PRE-CREATION 
>   test/deb/ubuntu-xenial/Vagrantfile PRE-CREATION 
>   test/deb/ubuntu-xenial/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52437/diff/
> 
> 
> Testing
> ---
> 
> Created artifacts using the build-artifacts script.
> 
> Brought a vagrant image up, installed all deb files created by the artifacts 
> script, started both aurora-scheduler and thermos services, and launched a 
> sample job.
> 
> Made sure all debian systems were unaffected by the changes by bringing a 
> Vagrant image up for each distribution and installing the packages.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2017-02-07 Thread Renan DelValle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52437/
---

(Updated Feb. 7, 2017, 4:48 p.m.)


Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.


Changes
---

Moved python repos header for aurora-pants into the bash script for all debian 
builders. Removed Envirnoment values set in executor unit file and made 
EnvironmentFile error out if the file inside of /etc/default/aurora-scheduler 
is not found.


Bugs: AURORA-1872
https://issues.apache.org/jira/browse/AURORA-1872


Repository: aurora-packaging


Description
---

Added builder and test environment for Xenial as well as updated instructions 
on how to test it.

Added distribution to release-candidate script.


Diffs (updated)
-

  build-support/release/release-candidate 
b3ebe916102d0a6ef2c1997b6c4110008eafff1a 
  builder/deb/debian-jessie/Dockerfile 54cb2e072a0d465840899e00e541cec34130993d 
  builder/deb/debian-jessie/build.sh e0aeaf52a29483e65172f29792638dfbca100079 
  builder/deb/ubuntu-trusty/Dockerfile 802049b6b2a53666c153525f2fb97bfbf0d4bab4 
  builder/deb/ubuntu-trusty/build.sh e0aeaf52a29483e65172f29792638dfbca100079 
  builder/deb/ubuntu-xenial/Dockerfile PRE-CREATION 
  builder/deb/ubuntu-xenial/build.sh PRE-CREATION 
  specs/debian/aurora-executor.thermos.default 
82ab0c8ab585acf253f8fecc0ed88a3e19511ffb 
  specs/debian/aurora-executor.thermos.service 
da351164298bd2b5a1802a945211647c99193ae6 
  specs/debian/aurora-pants.ini e4f2c54df45f746ffb2a4e3f786fc4105323bc0b 
  specs/debian/aurora-scheduler.service 
ae33d26ac10518985eacea6bf015f81a02c53f66 
  specs/debian/aurora-scheduler.startup.sh PRE-CREATION 
  specs/debian/rules 4effc3ecf3208f82986d15f6000d18abc11652b1 
  test/deb/ubuntu-xenial/README.md PRE-CREATION 
  test/deb/ubuntu-xenial/Vagrantfile PRE-CREATION 
  test/deb/ubuntu-xenial/provision.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/52437/diff/


Testing
---

Created artifacts using the build-artifacts script.

Brought a vagrant image up, installed all deb files created by the artifacts 
script, started both aurora-scheduler and thermos services, and launched a 
sample job.

Made sure all debian systems were unaffected by the changes by bringing a 
Vagrant image up for each distribution and installing the packages.


Thanks,

Renan DelValle

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2017-02-07 Thread Stephan Erb 


> On Feb. 6, 2017, 10:01 p.m., Stephan Erb wrote:
> > specs/debian/aurora-executor.thermos.service, lines 22-23
> > 
> >
> > Can the corresponding init scripts be dropped?
> 
> Renan DelValle wrote:
> We can definitely drop them but we'd lose (unofficial) compatibility for 
> those who chose to init sysv init system (debian wheezy).

Let's keep them for one more version then.


- Stephan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52437/#review164402
---


On Feb. 1, 2017, 9:44 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52437/
> ---
> 
> (Updated Feb. 1, 2017, 9:44 p.m.)
> 
> 
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
> 
> 
> Bugs: AURORA-1872
> https://issues.apache.org/jira/browse/AURORA-1872
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Added builder and test environment for Xenial as well as updated instructions 
> on how to test it.
> 
> Added distribution to release-candidate script.
> 
> 
> Diffs
> -
> 
>   build-support/release/release-candidate 
> b3ebe916102d0a6ef2c1997b6c4110008eafff1a 
>   builder/deb/debian-jessie/Dockerfile 
> 54cb2e072a0d465840899e00e541cec34130993d 
>   builder/deb/debian-jessie/build.sh e0aeaf52a29483e65172f29792638dfbca100079 
>   builder/deb/ubuntu-trusty/Dockerfile 
> 802049b6b2a53666c153525f2fb97bfbf0d4bab4 
>   builder/deb/ubuntu-trusty/build.sh e0aeaf52a29483e65172f29792638dfbca100079 
>   builder/deb/ubuntu-xenial/Dockerfile PRE-CREATION 
>   builder/deb/ubuntu-xenial/build.sh PRE-CREATION 
>   specs/debian/aurora-executor.thermos.default 
> 82ab0c8ab585acf253f8fecc0ed88a3e19511ffb 
>   specs/debian/aurora-executor.thermos.service 
> da351164298bd2b5a1802a945211647c99193ae6 
>   specs/debian/aurora-pants.ini e4f2c54df45f746ffb2a4e3f786fc4105323bc0b 
>   specs/debian/aurora-scheduler.service 
> ae33d26ac10518985eacea6bf015f81a02c53f66 
>   specs/debian/aurora-scheduler.startup.sh PRE-CREATION 
>   specs/debian/rules 4effc3ecf3208f82986d15f6000d18abc11652b1 
>   test/deb/ubuntu-xenial/README.md PRE-CREATION 
>   test/deb/ubuntu-xenial/Vagrantfile PRE-CREATION 
>   test/deb/ubuntu-xenial/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52437/diff/
> 
> 
> Testing
> ---
> 
> Created artifacts using the build-artifacts script.
> 
> Brought a vagrant image up, installed all deb files created by the artifacts 
> script, started both aurora-scheduler and thermos services, and launched a 
> sample job.
> 
> Made sure all debian systems were unaffected by the changes by bringing a 
> Vagrant image up for each distribution and installing the packages.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2017-02-07 Thread Renan DelValle 


> On Feb. 6, 2017, 1:01 p.m., Stephan Erb wrote:
> >

Thanks for the review!


> On Feb. 6, 2017, 1:01 p.m., Stephan Erb wrote:
> > builder/deb/debian-jessie/build.sh, line 28
> > 
> >
> > That indentation seems unnecessary.

Fixed!


> On Feb. 6, 2017, 1:01 p.m., Stephan Erb wrote:
> > builder/deb/debian-jessie/build.sh, lines 30-31
> > 
> >
> > It is more robust if we inject the whole section here (including the 
> > section header).

Yep, that makes sense. I'll go ahead and fix that.


> On Feb. 6, 2017, 1:01 p.m., Stephan Erb wrote:
> > specs/debian/aurora-executor.thermos.service, lines 22-23
> > 
> >
> > Can the corresponding init scripts be dropped?

We can definitely drop them but we'd lose (unofficial) compatibility for those 
who chose to init sysv init system (debian wheezy).


> On Feb. 6, 2017, 1:01 p.m., Stephan Erb wrote:
> > specs/debian/aurora-executor.thermos.service, lines 19-21
> > 
> >
> > Why have you specified both `Environment` and `EnvironmentFile`. I 
> > suppose the latter has precedence?

Great catch, I'd forgotten I'd done this. Yup, EnvironmentFile has preedence. 
In this case EnvironmentFile also has a negative sign after the equal sign to 
ignore errors (e.g. file doesn't exist). I was experimenting with having a 
fallback option if the config file wasn't found, but since the deb package 
places one there, we can assume it'll be there. I'll get rid of lines 19 and 20.


- Renan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52437/#review164402
---


On Feb. 1, 2017, 12:44 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52437/
> ---
> 
> (Updated Feb. 1, 2017, 12:44 p.m.)
> 
> 
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
> 
> 
> Bugs: AURORA-1872
> https://issues.apache.org/jira/browse/AURORA-1872
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Added builder and test environment for Xenial as well as updated instructions 
> on how to test it.
> 
> Added distribution to release-candidate script.
> 
> 
> Diffs
> -
> 
>   build-support/release/release-candidate 
> b3ebe916102d0a6ef2c1997b6c4110008eafff1a 
>   builder/deb/debian-jessie/Dockerfile 
> 54cb2e072a0d465840899e00e541cec34130993d 
>   builder/deb/debian-jessie/build.sh e0aeaf52a29483e65172f29792638dfbca100079 
>   builder/deb/ubuntu-trusty/Dockerfile 
> 802049b6b2a53666c153525f2fb97bfbf0d4bab4 
>   builder/deb/ubuntu-trusty/build.sh e0aeaf52a29483e65172f29792638dfbca100079 
>   builder/deb/ubuntu-xenial/Dockerfile PRE-CREATION 
>   builder/deb/ubuntu-xenial/build.sh PRE-CREATION 
>   specs/debian/aurora-executor.thermos.default 
> 82ab0c8ab585acf253f8fecc0ed88a3e19511ffb 
>   specs/debian/aurora-executor.thermos.service 
> da351164298bd2b5a1802a945211647c99193ae6 
>   specs/debian/aurora-pants.ini e4f2c54df45f746ffb2a4e3f786fc4105323bc0b 
>   specs/debian/aurora-scheduler.service 
> ae33d26ac10518985eacea6bf015f81a02c53f66 
>   specs/debian/aurora-scheduler.startup.sh PRE-CREATION 
>   specs/debian/rules 4effc3ecf3208f82986d15f6000d18abc11652b1 
>   test/deb/ubuntu-xenial/README.md PRE-CREATION 
>   test/deb/ubuntu-xenial/Vagrantfile PRE-CREATION 
>   test/deb/ubuntu-xenial/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52437/diff/
> 
> 
> Testing
> ---
> 
> Created artifacts using the build-artifacts script.
> 
> Brought a vagrant image up, installed all deb files created by the artifacts 
> script, started both aurora-scheduler and thermos services, and launched a 
> sample job.
> 
> Made sure all debian systems were unaffected by the changes by bringing a 
> Vagrant image up for each distribution and installing the packages.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2017-02-06 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52437/#review164402
---




builder/deb/debian-jessie/build.sh (line 28)


That indentation seems unnecessary.



builder/deb/debian-jessie/build.sh (lines 30 - 31)


It is more robust if we inject the whole section here (including the 
section header).



specs/debian/aurora-executor.thermos.service (lines 19 - 21)


Why have you specified both `Environment` and `EnvironmentFile`. I suppose 
the latter has precedence?



specs/debian/aurora-executor.thermos.service (lines 22 - 23)


Can the corresponding init scripts be dropped?



specs/debian/aurora-scheduler.service 


Same here, can the corresponding init scripts be dropped?


- Stephan Erb


On Feb. 1, 2017, 9:44 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52437/
> ---
> 
> (Updated Feb. 1, 2017, 9:44 p.m.)
> 
> 
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
> 
> 
> Bugs: AURORA-1872
> https://issues.apache.org/jira/browse/AURORA-1872
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Added builder and test environment for Xenial as well as updated instructions 
> on how to test it.
> 
> Added distribution to release-candidate script.
> 
> 
> Diffs
> -
> 
>   build-support/release/release-candidate 
> b3ebe916102d0a6ef2c1997b6c4110008eafff1a 
>   builder/deb/debian-jessie/Dockerfile 
> 54cb2e072a0d465840899e00e541cec34130993d 
>   builder/deb/debian-jessie/build.sh e0aeaf52a29483e65172f29792638dfbca100079 
>   builder/deb/ubuntu-trusty/Dockerfile 
> 802049b6b2a53666c153525f2fb97bfbf0d4bab4 
>   builder/deb/ubuntu-trusty/build.sh e0aeaf52a29483e65172f29792638dfbca100079 
>   builder/deb/ubuntu-xenial/Dockerfile PRE-CREATION 
>   builder/deb/ubuntu-xenial/build.sh PRE-CREATION 
>   specs/debian/aurora-executor.thermos.default 
> 82ab0c8ab585acf253f8fecc0ed88a3e19511ffb 
>   specs/debian/aurora-executor.thermos.service 
> da351164298bd2b5a1802a945211647c99193ae6 
>   specs/debian/aurora-pants.ini e4f2c54df45f746ffb2a4e3f786fc4105323bc0b 
>   specs/debian/aurora-scheduler.service 
> ae33d26ac10518985eacea6bf015f81a02c53f66 
>   specs/debian/aurora-scheduler.startup.sh PRE-CREATION 
>   specs/debian/rules 4effc3ecf3208f82986d15f6000d18abc11652b1 
>   test/deb/ubuntu-xenial/README.md PRE-CREATION 
>   test/deb/ubuntu-xenial/Vagrantfile PRE-CREATION 
>   test/deb/ubuntu-xenial/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52437/diff/
> 
> 
> Testing
> ---
> 
> Created artifacts using the build-artifacts script.
> 
> Brought a vagrant image up, installed all deb files created by the artifacts 
> script, started both aurora-scheduler and thermos services, and launched a 
> sample job.
> 
> Made sure all debian systems were unaffected by the changes by bringing a 
> Vagrant image up for each distribution and installing the packages.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2017-02-01 Thread Renan DelValle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52437/
---

(Updated Feb. 1, 2017, 12:44 p.m.)


Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.


Changes
---

Merged ubuntu-xenial spec into debian spec.


Bugs: AURORA-1872
https://issues.apache.org/jira/browse/AURORA-1872


Repository: aurora-packaging


Description (updated)
---

Added builder and test environment for Xenial as well as updated instructions 
on how to test it.

Added distribution to release-candidate script.


Diffs (updated)
-

  build-support/release/release-candidate 
b3ebe916102d0a6ef2c1997b6c4110008eafff1a 
  builder/deb/debian-jessie/Dockerfile 54cb2e072a0d465840899e00e541cec34130993d 
  builder/deb/debian-jessie/build.sh e0aeaf52a29483e65172f29792638dfbca100079 
  builder/deb/ubuntu-trusty/Dockerfile 802049b6b2a53666c153525f2fb97bfbf0d4bab4 
  builder/deb/ubuntu-trusty/build.sh e0aeaf52a29483e65172f29792638dfbca100079 
  builder/deb/ubuntu-xenial/Dockerfile PRE-CREATION 
  builder/deb/ubuntu-xenial/build.sh PRE-CREATION 
  specs/debian/aurora-executor.thermos.default 
82ab0c8ab585acf253f8fecc0ed88a3e19511ffb 
  specs/debian/aurora-executor.thermos.service 
da351164298bd2b5a1802a945211647c99193ae6 
  specs/debian/aurora-pants.ini e4f2c54df45f746ffb2a4e3f786fc4105323bc0b 
  specs/debian/aurora-scheduler.service 
ae33d26ac10518985eacea6bf015f81a02c53f66 
  specs/debian/aurora-scheduler.startup.sh PRE-CREATION 
  specs/debian/rules 4effc3ecf3208f82986d15f6000d18abc11652b1 
  test/deb/ubuntu-xenial/README.md PRE-CREATION 
  test/deb/ubuntu-xenial/Vagrantfile PRE-CREATION 
  test/deb/ubuntu-xenial/provision.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/52437/diff/


Testing (updated)
---

Created artifacts using the build-artifacts script.

Brought a vagrant image up, installed all deb files created by the artifacts 
script, started both aurora-scheduler and thermos services, and launched a 
sample job.

Made sure all debian systems were unaffected by the changes by bringing a 
Vagrant image up for each distribution and installing the packages.


Thanks,

Renan DelValle

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2017-01-04 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52437/#review160527
---


Ship it!




LGTM


specs/ubuntu-xenial/changelog (line 1)


This should be `xenial`.

I also think we should only include the changelog for the packages that do 
actually exist for xenial. So this would essential only be the upcoming 0.17. 
You can add this one as a dummy for now.



test/deb/ubuntu-xenial/README.md (line 26)


`ubuntu-xenial`


- Stephan Erb


On Jan. 4, 2017, 2:43 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52437/
> ---
> 
> (Updated Jan. 4, 2017, 2:43 p.m.)
> 
> 
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
> 
> 
> Bugs: AURORA-1872
> https://issues.apache.org/jira/browse/AURORA-1872
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Added builder and test environment for Xenial as well as updated instructions 
> on how to test it.
> 
> Added distributtion to release-candidate script.
> 
> 
> Diffs
> -
> 
>   build-support/release/release-candidate 
> 98df82412b6218ed7c1f650a7b1cc725ac297c37 
>   builder/deb/ubuntu-xenial/Dockerfile PRE-CREATION 
>   builder/deb/ubuntu-xenial/build.sh PRE-CREATION 
>   specs/debian/aurora-pants.ini e4f2c54df45f746ffb2a4e3f786fc4105323bc0b 
>   specs/debian/aurora-scheduler.startup.sh PRE-CREATION 
>   specs/ubuntu-xenial/aurora-doc.docs PRE-CREATION 
>   specs/ubuntu-xenial/aurora-doc.examples PRE-CREATION 
>   specs/ubuntu-xenial/aurora-pants.ini PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.default PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.install PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.links PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.postinst PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.service PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.startup.sh PRE-CREATION 
>   specs/ubuntu-xenial/aurora-tools.install PRE-CREATION 
>   specs/ubuntu-xenial/aurora-tools.links PRE-CREATION 
>   specs/ubuntu-xenial/changelog PRE-CREATION 
>   specs/ubuntu-xenial/clusters.json PRE-CREATION 
>   specs/ubuntu-xenial/compat PRE-CREATION 
>   specs/ubuntu-xenial/control PRE-CREATION 
>   specs/ubuntu-xenial/copyright PRE-CREATION 
>   specs/ubuntu-xenial/rules PRE-CREATION 
>   specs/ubuntu-xenial/source/format PRE-CREATION 
>   specs/ubuntu-xenial/thermos.default PRE-CREATION 
>   specs/ubuntu-xenial/thermos.dirs PRE-CREATION 
>   specs/ubuntu-xenial/thermos.install PRE-CREATION 
>   specs/ubuntu-xenial/thermos.links PRE-CREATION 
>   specs/ubuntu-xenial/thermos.service PRE-CREATION 
>   test/deb/ubuntu-xenial/README.md PRE-CREATION 
>   test/deb/ubuntu-xenial/Vagrantfile PRE-CREATION 
>   test/deb/ubuntu-xenial/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52437/diff/
> 
> 
> Testing
> ---
> 
> Created artifacts using the build-artifacts script.
> 
> Brought a vagrant image up, installed all deb files created by the artifacts 
> script, started both aurora-scheduler and thermos services, and launched a 
> sample job.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2017-01-04 Thread Renan DelValle 


> On Jan. 4, 2017, 6:01 a.m., Stephan Erb wrote:
> > We used to have shared specs for all Debian-based distributions. This patch 
> > is now duplicating `specs/debian` for `ubuntu-xenial`. Is there anything 
> > particular that makes this necessary?

The reason why I have it a separate the specs  is two fold. First ubuntu xenial 
doesn’t play well if there’s _any_ init script installed, so the separate spec 
doesn't have them (we can achieve the same effect by only copying necessary 
files out of a common folder). Second, the existing SystemD unit scripts for 
debian were not all that native. I wrote new ones to be closer to their RPM 
counterparts. However, as the debian ones are already being used, I didn't want 
to force my changes upon anyone. We can decide as a community the way we want 
to handle this though.


- Renan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52437/#review160490
---


On Jan. 4, 2017, 5:43 a.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52437/
> ---
> 
> (Updated Jan. 4, 2017, 5:43 a.m.)
> 
> 
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
> 
> 
> Bugs: AURORA-1872
> https://issues.apache.org/jira/browse/AURORA-1872
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Added builder and test environment for Xenial as well as updated instructions 
> on how to test it.
> 
> Added distributtion to release-candidate script.
> 
> 
> Diffs
> -
> 
>   build-support/release/release-candidate 
> 98df82412b6218ed7c1f650a7b1cc725ac297c37 
>   builder/deb/ubuntu-xenial/Dockerfile PRE-CREATION 
>   builder/deb/ubuntu-xenial/build.sh PRE-CREATION 
>   specs/debian/aurora-pants.ini e4f2c54df45f746ffb2a4e3f786fc4105323bc0b 
>   specs/debian/aurora-scheduler.startup.sh PRE-CREATION 
>   specs/ubuntu-xenial/aurora-doc.docs PRE-CREATION 
>   specs/ubuntu-xenial/aurora-doc.examples PRE-CREATION 
>   specs/ubuntu-xenial/aurora-pants.ini PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.default PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.install PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.links PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.postinst PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.service PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.startup.sh PRE-CREATION 
>   specs/ubuntu-xenial/aurora-tools.install PRE-CREATION 
>   specs/ubuntu-xenial/aurora-tools.links PRE-CREATION 
>   specs/ubuntu-xenial/changelog PRE-CREATION 
>   specs/ubuntu-xenial/clusters.json PRE-CREATION 
>   specs/ubuntu-xenial/compat PRE-CREATION 
>   specs/ubuntu-xenial/control PRE-CREATION 
>   specs/ubuntu-xenial/copyright PRE-CREATION 
>   specs/ubuntu-xenial/rules PRE-CREATION 
>   specs/ubuntu-xenial/source/format PRE-CREATION 
>   specs/ubuntu-xenial/thermos.default PRE-CREATION 
>   specs/ubuntu-xenial/thermos.dirs PRE-CREATION 
>   specs/ubuntu-xenial/thermos.install PRE-CREATION 
>   specs/ubuntu-xenial/thermos.links PRE-CREATION 
>   specs/ubuntu-xenial/thermos.service PRE-CREATION 
>   test/deb/ubuntu-xenial/README.md PRE-CREATION 
>   test/deb/ubuntu-xenial/Vagrantfile PRE-CREATION 
>   test/deb/ubuntu-xenial/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52437/diff/
> 
> 
> Testing
> ---
> 
> Created artifacts using the build-artifacts script.
> 
> Brought a vagrant image up, installed all deb files created by the artifacts 
> script, started both aurora-scheduler and thermos services, and launched a 
> sample job.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2017-01-04 Thread Renan DelValle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52437/
---

(Updated Jan. 4, 2017, 2:43 p.m.)


Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.


Bugs: AURORA-1872
https://issues.apache.org/jira/browse/AURORA-1872


Repository: aurora-packaging


Description
---

Added builder and test environment for Xenial as well as updated instructions 
on how to test it.

Added distributtion to release-candidate script.


Diffs
-

  build-support/release/release-candidate 
98df82412b6218ed7c1f650a7b1cc725ac297c37 
  builder/deb/ubuntu-xenial/Dockerfile PRE-CREATION 
  builder/deb/ubuntu-xenial/build.sh PRE-CREATION 
  specs/debian/aurora-pants.ini e4f2c54df45f746ffb2a4e3f786fc4105323bc0b 
  specs/debian/aurora-scheduler.startup.sh PRE-CREATION 
  specs/ubuntu-xenial/aurora-doc.docs PRE-CREATION 
  specs/ubuntu-xenial/aurora-doc.examples PRE-CREATION 
  specs/ubuntu-xenial/aurora-pants.ini PRE-CREATION 
  specs/ubuntu-xenial/aurora-scheduler.default PRE-CREATION 
  specs/ubuntu-xenial/aurora-scheduler.install PRE-CREATION 
  specs/ubuntu-xenial/aurora-scheduler.links PRE-CREATION 
  specs/ubuntu-xenial/aurora-scheduler.postinst PRE-CREATION 
  specs/ubuntu-xenial/aurora-scheduler.service PRE-CREATION 
  specs/ubuntu-xenial/aurora-scheduler.startup.sh PRE-CREATION 
  specs/ubuntu-xenial/aurora-tools.install PRE-CREATION 
  specs/ubuntu-xenial/aurora-tools.links PRE-CREATION 
  specs/ubuntu-xenial/changelog PRE-CREATION 
  specs/ubuntu-xenial/clusters.json PRE-CREATION 
  specs/ubuntu-xenial/compat PRE-CREATION 
  specs/ubuntu-xenial/control PRE-CREATION 
  specs/ubuntu-xenial/copyright PRE-CREATION 
  specs/ubuntu-xenial/rules PRE-CREATION 
  specs/ubuntu-xenial/source/format PRE-CREATION 
  specs/ubuntu-xenial/thermos.default PRE-CREATION 
  specs/ubuntu-xenial/thermos.dirs PRE-CREATION 
  specs/ubuntu-xenial/thermos.install PRE-CREATION 
  specs/ubuntu-xenial/thermos.links PRE-CREATION 
  specs/ubuntu-xenial/thermos.service PRE-CREATION 
  test/deb/ubuntu-xenial/README.md PRE-CREATION 
  test/deb/ubuntu-xenial/Vagrantfile PRE-CREATION 
  test/deb/ubuntu-xenial/provision.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/52437/diff/


Testing
---

Created artifacts using the build-artifacts script.

Brought a vagrant image up, installed all deb files created by the artifacts 
script, started both aurora-scheduler and thermos services, and launched a 
sample job.


Thanks,

Renan DelValle

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-11-23 Thread Renan DelValle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52437/
---

(Updated Nov. 23, 2016, 3:03 p.m.)


Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.


Changes
---

Upgrading this patch to support 0.17.x since it didn't make it in time for the 
0.16.x release.

Upgraded debian packaging to point to the correct egg as well.


Repository: aurora-packaging


Description
---

Added builder and test environment for Xenial as well as updated instructions 
on how to test it.

Added distributtion to release-candidate script.


Diffs (updated)
-

  build-support/release/release-candidate 
98df82412b6218ed7c1f650a7b1cc725ac297c37 
  builder/deb/ubuntu-xenial/Dockerfile PRE-CREATION 
  builder/deb/ubuntu-xenial/build.sh PRE-CREATION 
  specs/debian/aurora-pants.ini e4f2c54df45f746ffb2a4e3f786fc4105323bc0b 
  specs/debian/aurora-scheduler.startup.sh PRE-CREATION 
  specs/ubuntu-xenial/aurora-doc.docs PRE-CREATION 
  specs/ubuntu-xenial/aurora-doc.examples PRE-CREATION 
  specs/ubuntu-xenial/aurora-pants.ini PRE-CREATION 
  specs/ubuntu-xenial/aurora-scheduler.default PRE-CREATION 
  specs/ubuntu-xenial/aurora-scheduler.install PRE-CREATION 
  specs/ubuntu-xenial/aurora-scheduler.links PRE-CREATION 
  specs/ubuntu-xenial/aurora-scheduler.postinst PRE-CREATION 
  specs/ubuntu-xenial/aurora-scheduler.service PRE-CREATION 
  specs/ubuntu-xenial/aurora-scheduler.startup.sh PRE-CREATION 
  specs/ubuntu-xenial/aurora-tools.install PRE-CREATION 
  specs/ubuntu-xenial/aurora-tools.links PRE-CREATION 
  specs/ubuntu-xenial/changelog PRE-CREATION 
  specs/ubuntu-xenial/clusters.json PRE-CREATION 
  specs/ubuntu-xenial/compat PRE-CREATION 
  specs/ubuntu-xenial/control PRE-CREATION 
  specs/ubuntu-xenial/copyright PRE-CREATION 
  specs/ubuntu-xenial/rules PRE-CREATION 
  specs/ubuntu-xenial/source/format PRE-CREATION 
  specs/ubuntu-xenial/thermos.default PRE-CREATION 
  specs/ubuntu-xenial/thermos.dirs PRE-CREATION 
  specs/ubuntu-xenial/thermos.install PRE-CREATION 
  specs/ubuntu-xenial/thermos.links PRE-CREATION 
  specs/ubuntu-xenial/thermos.service PRE-CREATION 
  test/deb/ubuntu-xenial/README.md PRE-CREATION 
  test/deb/ubuntu-xenial/Vagrantfile PRE-CREATION 
  test/deb/ubuntu-xenial/provision.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/52437/diff/


Testing
---

Created artifacts using the build-artifacts script.

Brought a vagrant image up, installed all deb files created by the artifacts 
script, started both aurora-scheduler and thermos services, and launched a 
sample job.


Thanks,

Renan DelValle

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-11-03 Thread Dmitriy Shirchenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52437/#review154818
---


Ship it!




Ship It!

- Dmitriy Shirchenko


On Oct. 12, 2016, 11:17 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52437/
> ---
> 
> (Updated Oct. 12, 2016, 11:17 p.m.)
> 
> 
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Added builder and test environment for Xenial as well as updated instructions 
> on how to test it.
> 
> Added distributtion to release-candidate script.
> 
> 
> Diffs
> -
> 
>   build-support/release/release-candidate 
> c08c88529ec036989032869198da7a21dcf6ac35 
>   builder/deb/ubuntu-xenial/Dockerfile PRE-CREATION 
>   builder/deb/ubuntu-xenial/build.sh PRE-CREATION 
>   specs/debian/aurora-scheduler.startup.sh PRE-CREATION 
>   specs/ubuntu-xenial/aurora-doc.docs PRE-CREATION 
>   specs/ubuntu-xenial/aurora-doc.examples PRE-CREATION 
>   specs/ubuntu-xenial/aurora-pants.ini PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.default PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.install PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.links PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.postinst PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.service PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.startup.sh PRE-CREATION 
>   specs/ubuntu-xenial/aurora-tools.install PRE-CREATION 
>   specs/ubuntu-xenial/aurora-tools.links PRE-CREATION 
>   specs/ubuntu-xenial/changelog PRE-CREATION 
>   specs/ubuntu-xenial/clusters.json PRE-CREATION 
>   specs/ubuntu-xenial/compat PRE-CREATION 
>   specs/ubuntu-xenial/control PRE-CREATION 
>   specs/ubuntu-xenial/copyright PRE-CREATION 
>   specs/ubuntu-xenial/rules PRE-CREATION 
>   specs/ubuntu-xenial/source/format PRE-CREATION 
>   specs/ubuntu-xenial/thermos.default PRE-CREATION 
>   specs/ubuntu-xenial/thermos.dirs PRE-CREATION 
>   specs/ubuntu-xenial/thermos.install PRE-CREATION 
>   specs/ubuntu-xenial/thermos.links PRE-CREATION 
>   specs/ubuntu-xenial/thermos.service PRE-CREATION 
>   test/deb/ubuntu-xenial/README.md PRE-CREATION 
>   test/deb/ubuntu-xenial/Vagrantfile PRE-CREATION 
>   test/deb/ubuntu-xenial/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52437/diff/
> 
> 
> Testing
> ---
> 
> Created artifacts using the build-artifacts script.
> 
> Brought a vagrant image up, installed all deb files created by the artifacts 
> script, started both aurora-scheduler and thermos services, and launched a 
> sample job.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-10-19 Thread Renan DelValle 


> On Oct. 16, 2016, 2:35 p.m., Renan DelValle wrote:
> > Attempted to deploy binaries generated by this on my cluster. Everything 
> > seemed to install fine, but I had issues deploying docker containers. 
> > Thermos crashes with the following error:
> > ```
> > ImportError: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version 
> > `GLIBCXX_3.4.20' not found
> > ```
> > I suspect that the GLIBC that thermos is compiled with is one of the newer 
> > ones, causing issues with Docker containers that contain older versions of 
> > it. I'll have to experiment a bit to see if this is true.
> 
> Renan DelValle wrote:
> Looked into his and the take away is that if Mesos is compiled with a 
> version of GLIBC, we can't compile an egg for Mesos with a lower version of 
> the GLIBCXX. Containers will just have to have a compatible version of the 
> libstdc++ as a side effect of the way we load thermos into the container
> 
> Zameer Manji wrote:
> To be clear, this is with the DockerContainerizer right?

Oops, forgot to mention that. Yep! This only applies to DockerContainerizer.


- Renan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52437/#review152813
---


On Oct. 12, 2016, 4:17 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52437/
> ---
> 
> (Updated Oct. 12, 2016, 4:17 p.m.)
> 
> 
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Added builder and test environment for Xenial as well as updated instructions 
> on how to test it.
> 
> Added distributtion to release-candidate script.
> 
> 
> Diffs
> -
> 
>   build-support/release/release-candidate 
> c08c88529ec036989032869198da7a21dcf6ac35 
>   builder/deb/ubuntu-xenial/Dockerfile PRE-CREATION 
>   builder/deb/ubuntu-xenial/build.sh PRE-CREATION 
>   specs/debian/aurora-scheduler.startup.sh PRE-CREATION 
>   specs/ubuntu-xenial/aurora-doc.docs PRE-CREATION 
>   specs/ubuntu-xenial/aurora-doc.examples PRE-CREATION 
>   specs/ubuntu-xenial/aurora-pants.ini PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.default PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.install PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.links PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.postinst PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.service PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.startup.sh PRE-CREATION 
>   specs/ubuntu-xenial/aurora-tools.install PRE-CREATION 
>   specs/ubuntu-xenial/aurora-tools.links PRE-CREATION 
>   specs/ubuntu-xenial/changelog PRE-CREATION 
>   specs/ubuntu-xenial/clusters.json PRE-CREATION 
>   specs/ubuntu-xenial/compat PRE-CREATION 
>   specs/ubuntu-xenial/control PRE-CREATION 
>   specs/ubuntu-xenial/copyright PRE-CREATION 
>   specs/ubuntu-xenial/rules PRE-CREATION 
>   specs/ubuntu-xenial/source/format PRE-CREATION 
>   specs/ubuntu-xenial/thermos.default PRE-CREATION 
>   specs/ubuntu-xenial/thermos.dirs PRE-CREATION 
>   specs/ubuntu-xenial/thermos.install PRE-CREATION 
>   specs/ubuntu-xenial/thermos.links PRE-CREATION 
>   specs/ubuntu-xenial/thermos.service PRE-CREATION 
>   test/deb/ubuntu-xenial/README.md PRE-CREATION 
>   test/deb/ubuntu-xenial/Vagrantfile PRE-CREATION 
>   test/deb/ubuntu-xenial/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52437/diff/
> 
> 
> Testing
> ---
> 
> Created artifacts using the build-artifacts script.
> 
> Brought a vagrant image up, installed all deb files created by the artifacts 
> script, started both aurora-scheduler and thermos services, and launched a 
> sample job.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-10-19 Thread Zameer Manji 


> On Oct. 16, 2016, 2:35 p.m., Renan DelValle wrote:
> > Attempted to deploy binaries generated by this on my cluster. Everything 
> > seemed to install fine, but I had issues deploying docker containers. 
> > Thermos crashes with the following error:
> > ```
> > ImportError: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version 
> > `GLIBCXX_3.4.20' not found
> > ```
> > I suspect that the GLIBC that thermos is compiled with is one of the newer 
> > ones, causing issues with Docker containers that contain older versions of 
> > it. I'll have to experiment a bit to see if this is true.
> 
> Renan DelValle wrote:
> Looked into his and the take away is that if Mesos is compiled with a 
> version of GLIBC, we can't compile an egg for Mesos with a lower version of 
> the GLIBCXX. Containers will just have to have a compatible version of the 
> libstdc++ as a side effect of the way we load thermos into the container

To be clear, this is with the DockerContainerizer right?


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52437/#review152813
---


On Oct. 12, 2016, 4:17 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52437/
> ---
> 
> (Updated Oct. 12, 2016, 4:17 p.m.)
> 
> 
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Added builder and test environment for Xenial as well as updated instructions 
> on how to test it.
> 
> Added distributtion to release-candidate script.
> 
> 
> Diffs
> -
> 
>   build-support/release/release-candidate 
> c08c88529ec036989032869198da7a21dcf6ac35 
>   builder/deb/ubuntu-xenial/Dockerfile PRE-CREATION 
>   builder/deb/ubuntu-xenial/build.sh PRE-CREATION 
>   specs/debian/aurora-scheduler.startup.sh PRE-CREATION 
>   specs/ubuntu-xenial/aurora-doc.docs PRE-CREATION 
>   specs/ubuntu-xenial/aurora-doc.examples PRE-CREATION 
>   specs/ubuntu-xenial/aurora-pants.ini PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.default PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.install PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.links PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.postinst PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.service PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.startup.sh PRE-CREATION 
>   specs/ubuntu-xenial/aurora-tools.install PRE-CREATION 
>   specs/ubuntu-xenial/aurora-tools.links PRE-CREATION 
>   specs/ubuntu-xenial/changelog PRE-CREATION 
>   specs/ubuntu-xenial/clusters.json PRE-CREATION 
>   specs/ubuntu-xenial/compat PRE-CREATION 
>   specs/ubuntu-xenial/control PRE-CREATION 
>   specs/ubuntu-xenial/copyright PRE-CREATION 
>   specs/ubuntu-xenial/rules PRE-CREATION 
>   specs/ubuntu-xenial/source/format PRE-CREATION 
>   specs/ubuntu-xenial/thermos.default PRE-CREATION 
>   specs/ubuntu-xenial/thermos.dirs PRE-CREATION 
>   specs/ubuntu-xenial/thermos.install PRE-CREATION 
>   specs/ubuntu-xenial/thermos.links PRE-CREATION 
>   specs/ubuntu-xenial/thermos.service PRE-CREATION 
>   test/deb/ubuntu-xenial/README.md PRE-CREATION 
>   test/deb/ubuntu-xenial/Vagrantfile PRE-CREATION 
>   test/deb/ubuntu-xenial/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52437/diff/
> 
> 
> Testing
> ---
> 
> Created artifacts using the build-artifacts script.
> 
> Brought a vagrant image up, installed all deb files created by the artifacts 
> script, started both aurora-scheduler and thermos services, and launched a 
> sample job.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-10-19 Thread Renan DelValle 


> On Oct. 16, 2016, 2:35 p.m., Renan DelValle wrote:
> > Attempted to deploy binaries generated by this on my cluster. Everything 
> > seemed to install fine, but I had issues deploying docker containers. 
> > Thermos crashes with the following error:
> > ```
> > ImportError: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version 
> > `GLIBCXX_3.4.20' not found
> > ```
> > I suspect that the GLIBC that thermos is compiled with is one of the newer 
> > ones, causing issues with Docker containers that contain older versions of 
> > it. I'll have to experiment a bit to see if this is true.

Looked into his and the take away is that if Mesos is compiled with a version 
of GLIBC, we can't compile an egg for Mesos with a lower version of the 
GLIBCXX. Containers will just have to have a compatible version of the 
libstdc++ as a side effect of the way we load thermos into the container


- Renan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52437/#review152813
---


On Oct. 12, 2016, 4:17 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52437/
> ---
> 
> (Updated Oct. 12, 2016, 4:17 p.m.)
> 
> 
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Added builder and test environment for Xenial as well as updated instructions 
> on how to test it.
> 
> Added distributtion to release-candidate script.
> 
> 
> Diffs
> -
> 
>   build-support/release/release-candidate 
> c08c88529ec036989032869198da7a21dcf6ac35 
>   builder/deb/ubuntu-xenial/Dockerfile PRE-CREATION 
>   builder/deb/ubuntu-xenial/build.sh PRE-CREATION 
>   specs/debian/aurora-scheduler.startup.sh PRE-CREATION 
>   specs/ubuntu-xenial/aurora-doc.docs PRE-CREATION 
>   specs/ubuntu-xenial/aurora-doc.examples PRE-CREATION 
>   specs/ubuntu-xenial/aurora-pants.ini PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.default PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.install PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.links PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.postinst PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.service PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.startup.sh PRE-CREATION 
>   specs/ubuntu-xenial/aurora-tools.install PRE-CREATION 
>   specs/ubuntu-xenial/aurora-tools.links PRE-CREATION 
>   specs/ubuntu-xenial/changelog PRE-CREATION 
>   specs/ubuntu-xenial/clusters.json PRE-CREATION 
>   specs/ubuntu-xenial/compat PRE-CREATION 
>   specs/ubuntu-xenial/control PRE-CREATION 
>   specs/ubuntu-xenial/copyright PRE-CREATION 
>   specs/ubuntu-xenial/rules PRE-CREATION 
>   specs/ubuntu-xenial/source/format PRE-CREATION 
>   specs/ubuntu-xenial/thermos.default PRE-CREATION 
>   specs/ubuntu-xenial/thermos.dirs PRE-CREATION 
>   specs/ubuntu-xenial/thermos.install PRE-CREATION 
>   specs/ubuntu-xenial/thermos.links PRE-CREATION 
>   specs/ubuntu-xenial/thermos.service PRE-CREATION 
>   test/deb/ubuntu-xenial/README.md PRE-CREATION 
>   test/deb/ubuntu-xenial/Vagrantfile PRE-CREATION 
>   test/deb/ubuntu-xenial/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52437/diff/
> 
> 
> Testing
> ---
> 
> Created artifacts using the build-artifacts script.
> 
> Brought a vagrant image up, installed all deb files created by the artifacts 
> script, started both aurora-scheduler and thermos services, and launched a 
> sample job.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-10-12 Thread Renan DelValle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52437/
---

(Updated Oct. 12, 2016, 4:17 p.m.)


Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.


Changes
---

Several changes in this version (and a lot of them are up for discussion).

I have created a new folder under specs for ubuntu-xenial. I took the RPM 
systemd scripts and ported them to debian in such a way that it, hopefully, has 
very little effect on those running the jessie packages. However, I did not 
want to impose the changes in the systemd files.  Furthermore, the 
aurora-pants.ini is now distro specific. That having been said, there's a lot 
that the debian family can share. Sharing can cause issues as well but it'll 
cut down on duplicate places that have to be updated if changes are made.

Finally, I renamed the aurora-executor package to thermos as it didn't make 
sense to have the service be called thermos but the package be called 
aurora-executor. In fact, maybe I should rename the service to be called 
thermos observer as that what it really is, but at least now it is in line with 
the rpm naming scheme.

Any suggestions, comments, welcome. This patch is for generating 0.16.0, I'll 
provide a separate one for > 0.17.0.


Repository: aurora-packaging


Description
---

Added builder and test environment for Xenial as well as updated instructions 
on how to test it.

Added distributtion to release-candidate script.


Diffs (updated)
-

  build-support/release/release-candidate 
c08c88529ec036989032869198da7a21dcf6ac35 
  builder/deb/ubuntu-xenial/Dockerfile PRE-CREATION 
  builder/deb/ubuntu-xenial/build.sh PRE-CREATION 
  specs/debian/aurora-scheduler.startup.sh PRE-CREATION 
  specs/ubuntu-xenial/aurora-doc.docs PRE-CREATION 
  specs/ubuntu-xenial/aurora-doc.examples PRE-CREATION 
  specs/ubuntu-xenial/aurora-pants.ini PRE-CREATION 
  specs/ubuntu-xenial/aurora-scheduler.default PRE-CREATION 
  specs/ubuntu-xenial/aurora-scheduler.install PRE-CREATION 
  specs/ubuntu-xenial/aurora-scheduler.links PRE-CREATION 
  specs/ubuntu-xenial/aurora-scheduler.postinst PRE-CREATION 
  specs/ubuntu-xenial/aurora-scheduler.service PRE-CREATION 
  specs/ubuntu-xenial/aurora-scheduler.startup.sh PRE-CREATION 
  specs/ubuntu-xenial/aurora-tools.install PRE-CREATION 
  specs/ubuntu-xenial/aurora-tools.links PRE-CREATION 
  specs/ubuntu-xenial/changelog PRE-CREATION 
  specs/ubuntu-xenial/clusters.json PRE-CREATION 
  specs/ubuntu-xenial/compat PRE-CREATION 
  specs/ubuntu-xenial/control PRE-CREATION 
  specs/ubuntu-xenial/copyright PRE-CREATION 
  specs/ubuntu-xenial/rules PRE-CREATION 
  specs/ubuntu-xenial/source/format PRE-CREATION 
  specs/ubuntu-xenial/thermos.default PRE-CREATION 
  specs/ubuntu-xenial/thermos.dirs PRE-CREATION 
  specs/ubuntu-xenial/thermos.install PRE-CREATION 
  specs/ubuntu-xenial/thermos.links PRE-CREATION 
  specs/ubuntu-xenial/thermos.service PRE-CREATION 
  test/deb/ubuntu-xenial/README.md PRE-CREATION 
  test/deb/ubuntu-xenial/Vagrantfile PRE-CREATION 
  test/deb/ubuntu-xenial/provision.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/52437/diff/


Testing
---

Created artifacts using the build-artifacts script.

Brought a vagrant image up, installed all deb files created by the artifacts 
script, started both aurora-scheduler and thermos services, and launched a 
sample job.


Thanks,

Renan DelValle

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-10-03 Thread Zameer Manji 


> On Oct. 3, 2016, 8:46 a.m., Stephan Erb wrote:
> > Packages created for Xenial will still embed the executor eggs for Trusty. 
> > This is the same problem described here 
> > https://issues.apache.org/jira/browse/AURORA-1712
> > 
> > We have to find a way how we can inject the appropriate distribution into 
> > `specs/debian/aurora-pants.ini`.

Good catch. I will hold of on shipping this until that story is resolved.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52437/#review151172
---


On Sept. 30, 2016, 12:23 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52437/
> ---
> 
> (Updated Sept. 30, 2016, 12:23 p.m.)
> 
> 
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Added builder and test environment for Xenial as well as updated instructions 
> on how to test it.
> 
> Added distributtion to release-candidate script.
> 
> 
> Diffs
> -
> 
>   build-support/release/release-candidate 
> c08c88529ec036989032869198da7a21dcf6ac35 
>   builder/deb/ubuntu-xenial/Dockerfile PRE-CREATION 
>   builder/deb/ubuntu-xenial/build.sh PRE-CREATION 
>   test/deb/ubuntu-xenial/README.md PRE-CREATION 
>   test/deb/ubuntu-xenial/Vagrantfile PRE-CREATION 
>   test/deb/ubuntu-xenial/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52437/diff/
> 
> 
> Testing
> ---
> 
> Created artifacts using the build-artifacts script.
> 
> Brought a vagrant image up, installed all deb files created by the artifacts 
> script, started both aurora-scheduler and thermos services, and launched a 
> sample job.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-10-03 Thread Stephan Erb 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52437/#review151172
---



Packages created for Xenial will still embed the executor eggs for Trusty. This 
is the same problem described here 
https://issues.apache.org/jira/browse/AURORA-1712

We have to find a way how we can inject the appropriate distribution into 
`specs/debian/aurora-pants.ini`.

- Stephan Erb


On Sept. 30, 2016, 9:23 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52437/
> ---
> 
> (Updated Sept. 30, 2016, 9:23 p.m.)
> 
> 
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Added builder and test environment for Xenial as well as updated instructions 
> on how to test it.
> 
> Added distributtion to release-candidate script.
> 
> 
> Diffs
> -
> 
>   build-support/release/release-candidate 
> c08c88529ec036989032869198da7a21dcf6ac35 
>   builder/deb/ubuntu-xenial/Dockerfile PRE-CREATION 
>   builder/deb/ubuntu-xenial/build.sh PRE-CREATION 
>   test/deb/ubuntu-xenial/README.md PRE-CREATION 
>   test/deb/ubuntu-xenial/Vagrantfile PRE-CREATION 
>   test/deb/ubuntu-xenial/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52437/diff/
> 
> 
> Testing
> ---
> 
> Created artifacts using the build-artifacts script.
> 
> Brought a vagrant image up, installed all deb files created by the artifacts 
> script, started both aurora-scheduler and thermos services, and launched a 
> sample job.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-09-30 Thread Renan DelValle 


> On Sept. 30, 2016, 2:31 p.m., Dmitriy Shirchenko wrote:
> > builder/deb/ubuntu-xenial/Dockerfile, lines 36-40
> > 
> >
> > For my own curiousity: is the step of adding gpg keys strictly 
> > necessary? Why does ubuntu need it but not debian?

Hmmm, I'm actually not too sure on this since I cribbed this from the Ubuntu 
Trusty setup. It seems that the version we want in this case isn't the default 
one in Ubuntu so we set the repo and keys manually.


- Renan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52437/#review151066
---


On Sept. 30, 2016, 12:23 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52437/
> ---
> 
> (Updated Sept. 30, 2016, 12:23 p.m.)
> 
> 
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Added builder and test environment for Xenial as well as updated instructions 
> on how to test it.
> 
> Added distributtion to release-candidate script.
> 
> 
> Diffs
> -
> 
>   build-support/release/release-candidate 
> c08c88529ec036989032869198da7a21dcf6ac35 
>   builder/deb/ubuntu-xenial/Dockerfile PRE-CREATION 
>   builder/deb/ubuntu-xenial/build.sh PRE-CREATION 
>   test/deb/ubuntu-xenial/README.md PRE-CREATION 
>   test/deb/ubuntu-xenial/Vagrantfile PRE-CREATION 
>   test/deb/ubuntu-xenial/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52437/diff/
> 
> 
> Testing
> ---
> 
> Created artifacts using the build-artifacts script.
> 
> Brought a vagrant image up, installed all deb files created by the artifacts 
> script, started both aurora-scheduler and thermos services, and launched a 
> sample job.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-09-30 Thread Dmitriy Shirchenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52437/#review151091
---


Ship it!




Ship It!

- Dmitriy Shirchenko


On Sept. 30, 2016, 7:23 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52437/
> ---
> 
> (Updated Sept. 30, 2016, 7:23 p.m.)
> 
> 
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Added builder and test environment for Xenial as well as updated instructions 
> on how to test it.
> 
> Added distributtion to release-candidate script.
> 
> 
> Diffs
> -
> 
>   build-support/release/release-candidate 
> c08c88529ec036989032869198da7a21dcf6ac35 
>   builder/deb/ubuntu-xenial/Dockerfile PRE-CREATION 
>   builder/deb/ubuntu-xenial/build.sh PRE-CREATION 
>   test/deb/ubuntu-xenial/README.md PRE-CREATION 
>   test/deb/ubuntu-xenial/Vagrantfile PRE-CREATION 
>   test/deb/ubuntu-xenial/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52437/diff/
> 
> 
> Testing
> ---
> 
> Created artifacts using the build-artifacts script.
> 
> Brought a vagrant image up, installed all deb files created by the artifacts 
> script, started both aurora-scheduler and thermos services, and launched a 
> sample job.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 52437: Adding support for Ubuntu Xenial packages

2016-09-30 Thread Dmitriy Shirchenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52437/#review151066
---




builder/deb/ubuntu-xenial/Dockerfile (lines 36 - 40)


For my own curiousity: is the step of adding gpg keys strictly necessary? 
Why does ubuntu need it but not debian?


- Dmitriy Shirchenko


On Sept. 30, 2016, 7:23 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52437/
> ---
> 
> (Updated Sept. 30, 2016, 7:23 p.m.)
> 
> 
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> ---
> 
> Added builder and test environment for Xenial as well as updated instructions 
> on how to test it.
> 
> Added distributtion to release-candidate script.
> 
> 
> Diffs
> -
> 
>   build-support/release/release-candidate 
> c08c88529ec036989032869198da7a21dcf6ac35 
>   builder/deb/ubuntu-xenial/Dockerfile PRE-CREATION 
>   builder/deb/ubuntu-xenial/build.sh PRE-CREATION 
>   test/deb/ubuntu-xenial/README.md PRE-CREATION 
>   test/deb/ubuntu-xenial/Vagrantfile PRE-CREATION 
>   test/deb/ubuntu-xenial/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52437/diff/
> 
> 
> Testing
> ---
> 
> Created artifacts using the build-artifacts script.
> 
> Brought a vagrant image up, installed all deb files created by the artifacts 
> script, started both aurora-scheduler and thermos services, and launched a 
> sample job.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>