Re: Review Request 52588: Enable per task volume mounts via scheduler API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/ --- (Updated Oct. 31, 2016, 4:10 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 52588: Enable per task volume mounts via scheduler API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/#review153978 --- Ship it! LGTM - Santhosh Kumar Shanmugham On Oct. 26, 2016,

Re: Review Request 52588: Enable per task volume mounts via scheduler API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/#review153960 --- Ship it! Master (7ac639b) is green with this patch.

Re: Review Request 52588: Enable per task volume mounts via scheduler API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/ --- (Updated Oct. 26, 2016, 3:41 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 52588: Enable per task volume mounts via scheduler API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/#review153956 --- Master (7ac639b) is red with this patch.

Re: Review Request 52588: Enable per task volume mounts via scheduler API

> On Oct. 8, 2016, 12:40 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java, > > lines 246-248 > > > > > > I believe this is not true. Mesos is ignoring

Re: Review Request 52588: Enable per task volume mounts via scheduler API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/ --- (Updated Oct. 26, 2016, 3:02 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 52588: Enable per task volume mounts via scheduler API

> On Oct. 10, 2016, 7:44 p.m., Santhosh Kumar Shanmugham wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbContainer.java, > > line 40 > > > > > > .setVolumes(volumes) ? > > Zameer Manji

Re: Review Request 52588: Enable per task volume mounts via scheduler API

> On Oct. 8, 2016, 9:40 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java, > > lines 246-248 > > > > > > I believe this is not true. Mesos is ignoring

Re: Review Request 52588: Enable per task volume mounts via scheduler API

> On Oct. 10, 2016, 7:44 p.m., Santhosh Kumar Shanmugham wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbContainer.java, > > line 40 > > > > > > .setVolumes(volumes) ? > > Zameer Manji

Re: Review Request 52588: Enable per task volume mounts via scheduler API

> On Oct. 8, 2016, 9:40 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java, > > lines 246-248 > > > > > > I believe this is not true. Mesos is ignoring

Re: Review Request 52588: Enable per task volume mounts via scheduler API

> On Oct. 8, 2016, 9:40 a.m., Stephan Erb wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, lines > > 225-240 > > > > > > I am new to the Aurora DB layer, so question ahead: Why do we

Re: Review Request 52588: Enable per task volume mounts via scheduler API

> On Oct. 8, 2016, 7:40 a.m., Stephan Erb wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, lines > > 225-240 > > > > > > I am new to the Aurora DB layer, so question ahead: Why do we

Re: Review Request 52588: Enable per task volume mounts via scheduler API

> On Oct. 8, 2016, 9:40 a.m., Stephan Erb wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 207 > > > > > > Thrift noob question: What is the semantic difference to an empty list? > > Do we the

Re: Review Request 52588: Enable per task volume mounts via scheduler API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/#review152092 --- Mostly looks good. docs/reference/scheduler-configuration.md

Re: Review Request 52588: Enable per task volume mounts via scheduler API

> On Oct. 8, 2016, 12:40 a.m., Stephan Erb wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 207 > > > > > > Thrift noob question: What is the semantic difference to an empty list? > > Do we the

Re: Review Request 52588: Enable per task volume mounts via scheduler API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/#review151682 --- api/src/main/thrift/org/apache/aurora/gen/api.thrift (line 207)

Re: Review Request 52588: Enable per task volume mounts via scheduler API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/#review151870 --- Ship it! Ship It! - Joshua Cohen On Oct. 7, 2016, 7:19

Re: Review Request 52588: Enable per task volume mounts via scheduler API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/#review151864 --- Ship it! Master (09b8e58) is green with this patch.

Re: Review Request 52588: Enable per task volume mounts via scheduler API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/ --- (Updated Oct. 7, 2016, 12:19 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 52588: Enable per task volume mounts via scheduler API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/#review151755 --- Ship it! lgtm modulo style issues from review bot and updating

Re: Review Request 52588: Enable per task volume mounts via scheduler API

> On Oct. 6, 2016, 2:52 a.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/app/AppModule.java, line 102 > > > > > > Update `scheduler-configuration.md` to pick up this new flag? > > Zameer

Re: Review Request 52588: Enable per task volume mounts via scheduler API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/#review151750 --- Master (09b8e58) is red with this patch.

Re: Review Request 52588: Enable per task volume mounts via scheduler API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/ --- (Updated Oct. 6, 2016, 6:21 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 52588: Enable per task volume mounts via scheduler API

> On Oct. 5, 2016, 7:52 p.m., Joshua Cohen wrote: > > Overall looks good to me. One question: the executor currently only > > supports RO volumes (everything is a bind mount). This is because [Mesos > > itself only supports RO > >

Re: Review Request 52588: Enable per task volume mounts via scheduler API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/#review151615 --- Overall looks good to me. One question: the executor currently

Re: Review Request 52588: Enable per task volume mounts via scheduler API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/#review151618 --- Ship it! Master (e91130e) is green with this patch.

Re: Review Request 52588: Enable per task volume mounts via scheduler API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/ --- (Updated Oct. 5, 2016, 6:23 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 52588: Enable per task volume mounts via scheduler API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/#review151613 --- Master (e91130e) is red with this patch.