Re: Review Request 54269: Improve scheduling throughput via logging changes.

2016-12-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54269/#review157838 --- Master (3ea0331) is green with this patch.

Re: Review Request 54269: Improve scheduling throughput via logging changes.

2016-12-02 Thread Zameer Manji
> On Dec. 1, 2016, 5:41 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java, line > > 474 > > > > > > Please use the logging builtin formatting rather than doing the

Re: Review Request 54269: Improve scheduling throughput via logging changes.

2016-12-02 Thread Zameer Manji
> On Dec. 2, 2016, 11:29 a.m., Joshua Cohen wrote: > > src/main/resources/logback.xml, line 26 > > > > > > Can you add a comment here explaining why we're not using `%class` and > > `%line`? They're definitely

Re: Review Request 54269: Improve scheduling throughput via logging changes.

2016-12-02 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54269/ --- (Updated Dec. 2, 2016, 1:51 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 54269: Improve scheduling throughput via logging changes.

2016-12-02 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54269/#review157799 --- Ship it! src/main/resources/logback.xml (line 26)

Re: Review Request 54269: Improve scheduling throughput via logging changes.

2016-12-01 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54269/#review157687 --- Fix it, then Ship it! Lgtm. Two comments below.

Re: Review Request 54269: Improve scheduling throughput via logging changes.

2016-12-01 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54269/ --- (Updated Dec. 1, 2016, 3:13 p.m.) Review request for Aurora, David McLaughlin,