Re: Review Request 54439: Add support for an mttu metric (median time to updated)

2016-12-09 Thread Santhosh Kumar Shanmugham
> On Dec. 7, 2016, 10:28 a.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, lines > > 200-202 > > > > > > Why do we only sample active updates, seems like we

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

2016-12-09 Thread Joshua Cohen
> On Dec. 7, 2016, 6:28 p.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, lines > > 200-202 > > > > > > Why do we only sample active updates, seems like we could

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

2016-12-09 Thread Joshua Cohen
> On Dec. 7, 2016, 6:28 p.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, lines > > 200-202 > > > > > > Why do we only sample active updates, seems like we could

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

2016-12-09 Thread Santhosh Kumar Shanmugham
> On Dec. 7, 2016, 10:28 a.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, lines > > 200-202 > > > > > > Why do we only sample active updates, seems like we

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

2016-12-09 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54439/#review158651 --- src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

2016-12-08 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54439/#review158575 --- Please remove me from the reviewers list. I have no time to

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

2016-12-08 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54439/#review158573 --- LGTM. Please add: * a changelog entry * a short section to our

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

2016-12-08 Thread Mehrdad Nurolahzade
> On Dec. 7, 2016, 8:42 a.m., Mehrdad Nurolahzade wrote: > > A general side note: SLA metrics calculation is currently the most > > expensive cpu-bound operation handled by the scheduler (it can take as much > > as 50% master cpu cycles). The calculators seem like a good fit for > >

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

2016-12-08 Thread Joshua Cohen
> On Dec. 7, 2016, 6:28 p.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, lines > > 200-202 > > > > > > Why do we only sample active updates, seems like we could

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

2016-12-07 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54439/#review158363 ---

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

2016-12-07 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54439/#review158360 ---

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

2016-12-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54439/#review158357 --- Ship it! Master (91ddb07) is green with this patch.

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

2016-12-07 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54439/ --- (Updated Dec. 7, 2016, 5:50 p.m.) Review request for Aurora, Mehrdad

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

2016-12-07 Thread Mehrdad Nurolahzade
> On Dec. 7, 2016, 8:42 a.m., Mehrdad Nurolahzade wrote: > > A general side note: SLA metrics calculation is currently the most > > expensive cpu-bound operation handled by the scheduler (it can take as much > > as 50% master cpu cycles). The calculators seem like a good fit for > >

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

2016-12-07 Thread Joshua Cohen
> On Dec. 7, 2016, 4:42 p.m., Mehrdad Nurolahzade wrote: > > A general side note: SLA metrics calculation is currently the most > > expensive cpu-bound operation handled by the scheduler (it can take as much > > as 50% master cpu cycles). The calculators seem like a good fit for > >

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

2016-12-07 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54439/#review158343 --- A general side note: SLA metrics calculation is currently the

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

2016-12-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54439/#review158216 --- Ship it! Master (91ddb07) is green with this patch.

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

2016-12-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54439/#review158214 --- Master (91ddb07) is red with this patch.