Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.

2016-12-08 Thread John Sirois
> On Dec. 8, 2016, 8:29 p.m., John Sirois wrote: > > build-support/thrift/prepare_binary.sh, line 29 > > > > > > aha - popd on linux echos the dirstack - presumably it does not do this > > on osx... so needs a

Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.

2016-12-08 Thread John Sirois
> On Dec. 8, 2016, 8:29 p.m., John Sirois wrote: > > build-support/thrift/prepare_binary.sh, line 29 > > > > > > aha - popd on linux echos the dirstack - presumably it does not do this > > on osx... so needs a

Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.

2016-12-08 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54550/#review158632 --- build-support/thrift/prepare_binary.sh (line 29)

Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.

2016-12-08 Thread John Sirois
> On Dec. 8, 2016, 7:37 p.m., Aurora ReviewBot wrote: > > Master (f5749ce) is red with this patch. > > ./build-support/jenkins/build.sh > > > > You are using pip version 8.1.2, however version 9.0.1 is available. > > You should consider upgrading via the 'pip install --upgrade pip' command. >

Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.

2016-12-08 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54550/#review158630 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On Dec. 8,

Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.

2016-12-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54550/#review158629 --- Master (f5749ce) is red with this patch.

Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.

2016-12-08 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54550/ --- (Updated Dec. 9, 2016, 2:30 a.m.) Review request for Aurora and Santhosh Kumar

Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.

2016-12-08 Thread Joshua Cohen
> On Dec. 9, 2016, 2:22 a.m., Zameer Manji wrote: > > build-support/thrift/prepare_binary.sh, line 3 > > > > > > To be consistent can you do `set -o xtrace`? TIL - Joshua

Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.

2016-12-08 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54550/#review158627 --- Master (f5749ce) is red with this patch.

Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap.

2016-12-08 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54550/#review158626 --- Ship it! Ship It! - John Sirois On Dec. 8, 2016, 7:15 p.m.,