Re: Review Request 60942: Remove task level resource fields from thrift interface and db

> On Nov. 23, 2017, 12:46 p.m., Stephan Erb wrote: > > RELEASE-NOTES.md > > Lines 57 (patched) > > > > > > You will need to move this to 0.20.0. Also please state that you > > removed it. The fields have been

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

> On Nov. 23, 2017, 8:46 p.m., Stephan Erb wrote: > > RELEASE-NOTES.md > > Lines 57 (patched) > > > > > > You will need to move this to 0.20.0. Also please state that you > > removed it. The fields have been

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

> On Nov. 23, 2017, 12:46 p.m., Stephan Erb wrote: > > RELEASE-NOTES.md > > Lines 57 (patched) > > > > > > You will need to move this to 0.20.0. Also please state that you > > removed it. The fields have been

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/#review191931 --- Ship it! Sharing my own check on backwards compatibility -

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/#review191811 --- Ship it! Master (0f3dc93) is green with this patch.

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/ --- (Updated Nov. 23, 2017, 8:52 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/ --- (Updated Nov. 23, 2017, 8:35 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/#review190449 --- Ship it! Master (5dfe51c) is green with this patch.

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/ --- (Updated Nov. 8, 2017, 2:37 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

> On Oct. 18, 2017, 7:38 p.m., Nicolás Donatucci wrote: > > I found an issue a while back after talking to Joshua. > > It is regarding the downgrade script for my db migration. > > It works just fine assuming there is only one entry of ram, cpu and disk > > per taskId on the task_resource

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

> On Oct. 18, 2017, 12:38 p.m., Nicolás Donatucci wrote: > > I found an issue a while back after talking to Joshua. > > It is regarding the downgrade script for my db migration. > > It works just fine assuming there is only one entry of ram, cpu and disk > > per taskId on the task_resource

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/#review188555 --- I found an issue a while back after talking to Joshua. It is

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

> On Aug. 31, 2017, 1:34 a.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/migration/V004_CreateTaskResourceTable.java > > Lines 34-41 (original), 33 (patched) > > > > > > I wonder if

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/#review184226 --- Overall looks good to me. Just a couple of questions about the

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/#review183778 --- Ship it! Master (62e46cd) is green with this patch.

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/#review183769 --- Fix it, then Ship it! RELEASE-NOTES.md Lines 21 (patched)

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/#review182494 --- Ship it! Master (aae2b0d) is green with this patch.

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/ --- (Updated Aug. 9, 2017, 4:47 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/#review182482 --- RELEASE-NOTES.md Lines 18 (patched)

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/#review182293 --- Ship it! Master (aae2b0d) is green with this patch.

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/#review182288 --- This patch does not apply cleanly against master (aae2b0d), do

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/ --- (Updated Aug. 7, 2017, 4:53 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/#review182277 --- Ship it! Ship It! - Stephan Erb On Aug. 7, 2017, 4:25 p.m.,

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/#review182276 --- Ship it! Master (aae2b0d) is green with this patch.

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/ --- (Updated Aug. 7, 2017, 2:25 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/#review182262 --- The failing test case is `TestDiffCommand.test_cron_diff`. It

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/#review182260 --- Master (aae2b0d) is red with this patch.

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/ --- (Updated Aug. 4, 2017, 2:04 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

> On Aug. 3, 2017, 9:50 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/migration/V004_CreateTaskResourceTable.java > > Lines 33-42 (original), 32-34 (patched) > > > > > > Isn't that

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/#review182164 --- Thanks for the patch! Good work with the cleanup. I am not an

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/#review180836 --- Master (243d6fa) is red with this patch.

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/#review180811 --- Master (243d6fa) is red with this patch.